* [PATCH] ceph: Avoid to propagate the invalid page point
@ 2015-12-19 2:54 Minfei Huang
2015-12-21 4:12 ` Yan, Zheng
0 siblings, 1 reply; 2+ messages in thread
From: Minfei Huang @ 2015-12-19 2:54 UTC (permalink / raw)
To: zyan, sage, idryomov; +Cc: ceph-devel, linux-kernel, mhuang, Minfei Huang
The variant pagep will still get the invalid page point, although ceph
fails in function ceph_update_writeable_page.
To fix this issue, Assigne the page to pagep until there is no failure
in function ceph_update_writeable_page.
Signed-off-by: Minfei Huang <mnfhuang@gmail.com>
---
fs/ceph/addr.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
index b7d218a..6491079 100644
--- a/fs/ceph/addr.c
+++ b/fs/ceph/addr.c
@@ -1149,7 +1149,6 @@ static int ceph_write_begin(struct file *file, struct address_space *mapping,
page = grab_cache_page_write_begin(mapping, index, 0);
if (!page)
return -ENOMEM;
- *pagep = page;
dout("write_begin file %p inode %p page %p %d~%d\n", file,
inode, page, (int)pos, (int)len);
--
2.6.3
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ceph: Avoid to propagate the invalid page point
2015-12-19 2:54 [PATCH] ceph: Avoid to propagate the invalid page point Minfei Huang
@ 2015-12-21 4:12 ` Yan, Zheng
0 siblings, 0 replies; 2+ messages in thread
From: Yan, Zheng @ 2015-12-21 4:12 UTC (permalink / raw)
To: Minfei Huang; +Cc: sage, idryomov, ceph-devel, linux-kernel, mhuang
> On Dec 19, 2015, at 10:54, Minfei Huang <mnfhuang@gmail.com> wrote:
>
> The variant pagep will still get the invalid page point, although ceph
> fails in function ceph_update_writeable_page.
>
> To fix this issue, Assigne the page to pagep until there is no failure
> in function ceph_update_writeable_page.
>
> Signed-off-by: Minfei Huang <mnfhuang@gmail.com>
> ---
> fs/ceph/addr.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
> index b7d218a..6491079 100644
> --- a/fs/ceph/addr.c
> +++ b/fs/ceph/addr.c
> @@ -1149,7 +1149,6 @@ static int ceph_write_begin(struct file *file, struct address_space *mapping,
> page = grab_cache_page_write_begin(mapping, index, 0);
> if (!page)
> return -ENOMEM;
> - *pagep = page;
>
> dout("write_begin file %p inode %p page %p %d~%d\n", file,
> inode, page, (int)pos, (int)len);
applied, thanks
Yan, Zheng
> --
> 2.6.3
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-21 4:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-19 2:54 [PATCH] ceph: Avoid to propagate the invalid page point Minfei Huang
2015-12-21 4:12 ` Yan, Zheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®