From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: [PATCH 2/8] ppdev: remove whitespace around pointers
Date: Fri, 12 Feb 2016 18:33:40 +0530 [thread overview]
Message-ID: <1455282226-1968-2-git-send-email-sudipm.mukherjee@gmail.com> (raw)
In-Reply-To: <1455282226-1968-1-git-send-email-sudipm.mukherjee@gmail.com>
checkpatch was complaining about space around the pointer.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
drivers/char/ppdev.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/char/ppdev.c b/drivers/char/ppdev.c
index 80ab757..8a168c4 100644
--- a/drivers/char/ppdev.c
+++ b/drivers/char/ppdev.c
@@ -75,7 +75,7 @@
#define CHRDEV "ppdev"
struct pp_struct {
- struct pardevice * pdev;
+ struct pardevice *pdev;
wait_queue_head_t irq_wait;
atomic_t irqc;
unsigned int flags;
@@ -112,12 +112,12 @@ static inline void pp_enable_irq(struct pp_struct *pp)
port->ops->enable_irq(port);
}
-static ssize_t pp_read(struct file * file, char __user * buf, size_t count,
- loff_t * ppos)
+static ssize_t pp_read(struct file *file, char __user *buf, size_t count,
+ loff_t *ppos)
{
unsigned int minor = iminor(file_inode(file));
struct pp_struct *pp = file->private_data;
- char * kbuffer;
+ char *kbuffer;
ssize_t bytes_read = 0;
struct parport *pport;
int mode;
@@ -194,12 +194,12 @@ static ssize_t pp_read(struct file * file, char __user * buf, size_t count,
return bytes_read;
}
-static ssize_t pp_write(struct file * file, const char __user * buf,
- size_t count, loff_t * ppos)
+static ssize_t pp_write(struct file *file, const char __user *buf,
+ size_t count, loff_t *ppos)
{
unsigned int minor = iminor(file_inode(file));
struct pp_struct *pp = file->private_data;
- char * kbuffer;
+ char *kbuffer;
ssize_t bytes_written = 0;
ssize_t wrote;
int mode;
@@ -288,7 +288,7 @@ static void pp_irq(void *private)
static int register_device(int minor, struct pp_struct *pp)
{
struct parport *port;
- struct pardevice * pdev = NULL;
+ struct pardevice *pdev = NULL;
char *name;
int fl;
@@ -350,7 +350,7 @@ static int pp_do_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
{
unsigned int minor = iminor(file_inode(file));
struct pp_struct *pp = file->private_data;
- struct parport * port;
+ struct parport *port;
void __user *argp = (void __user *)arg;
/* First handle the cases that don't take arguments. */
@@ -679,7 +679,7 @@ static long pp_compat_ioctl(struct file *file, unsigned int cmd,
}
#endif
-static int pp_open(struct inode * inode, struct file * file)
+static int pp_open(struct inode *inode, struct file *file)
{
unsigned int minor = iminor(inode);
struct pp_struct *pp;
@@ -708,7 +708,7 @@ static int pp_open(struct inode * inode, struct file * file)
return 0;
}
-static int pp_release(struct inode * inode, struct file * file)
+static int pp_release(struct inode *inode, struct file *file)
{
unsigned int minor = iminor(inode);
struct pp_struct *pp = file->private_data;
@@ -767,7 +767,7 @@ static int pp_release(struct inode * inode, struct file * file)
}
/* No kernel lock held - fine */
-static unsigned int pp_poll(struct file * file, poll_table * wait)
+static unsigned int pp_poll(struct file *file, poll_table *wait)
{
struct pp_struct *pp = file->private_data;
unsigned int mask = 0;
--
1.9.1
next prev parent reply other threads:[~2016-02-12 13:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 13:03 [PATCH 1/8] ppdev: space prohibited between function name and parenthesis Sudip Mukherjee
2016-02-12 13:03 ` Sudip Mukherjee [this message]
2016-02-12 13:03 ` [PATCH 3/8] ppdev: add missing blank line Sudip Mukherjee
2016-02-12 13:03 ` [PATCH 4/8] ppdev: remove braces Sudip Mukherjee
2016-02-12 13:03 ` [PATCH 5/8] ppdev: fix parenthesis alignment Sudip Mukherjee
2016-02-12 13:03 ` [PATCH 6/8] ppdev: remove space before tab Sudip Mukherjee
2016-02-12 13:03 ` [PATCH 7/8] ppdev: use new parport device model Sudip Mukherjee
2016-02-12 13:03 ` [PATCH 8/8] ppdev: use dev_* macros Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455282226-1968-2-git-send-email-sudipm.mukherjee@gmail.com \
--to=sudipm.mukherjee@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®