From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: [PATCH 5/8] ppdev: fix parenthesis alignment
Date: Fri, 12 Feb 2016 18:33:43 +0530 [thread overview]
Message-ID: <1455282226-1968-5-git-send-email-sudipm.mukherjee@gmail.com> (raw)
In-Reply-To: <1455282226-1968-1-git-send-email-sudipm.mukherjee@gmail.com>
checkpatch was complaining that the alignment was not matching with the
open parenthesis.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
drivers/char/ppdev.c | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/char/ppdev.c b/drivers/char/ppdev.c
index dfb4197..39dedb7 100644
--- a/drivers/char/ppdev.c
+++ b/drivers/char/ppdev.c
@@ -114,7 +114,7 @@ static inline void pp_enable_irq(struct pp_struct *pp)
}
static ssize_t pp_read(struct file *file, char __user *buf, size_t count,
- loff_t *ppos)
+ loff_t *ppos)
{
unsigned int minor = iminor(file_inode(file));
struct pp_struct *pp = file->private_data;
@@ -140,9 +140,9 @@ static ssize_t pp_read(struct file *file, char __user *buf, size_t count,
mode = pport->ieee1284.mode & ~(IEEE1284_DEVICEID | IEEE1284_ADDR);
parport_set_timeout(pp->pdev,
- (file->f_flags & O_NONBLOCK) ?
- PARPORT_INACTIVITY_O_NONBLOCK :
- pp->default_inactivity);
+ (file->f_flags & O_NONBLOCK) ?
+ PARPORT_INACTIVITY_O_NONBLOCK :
+ pp->default_inactivity);
while (bytes_read == 0) {
ssize_t need = min_t(unsigned long, count, PP_BUFFER_SIZE);
@@ -192,7 +192,7 @@ static ssize_t pp_read(struct file *file, char __user *buf, size_t count,
}
static ssize_t pp_write(struct file *file, const char __user *buf,
- size_t count, loff_t *ppos)
+ size_t count, loff_t *ppos)
{
unsigned int minor = iminor(file_inode(file));
struct pp_struct *pp = file->private_data;
@@ -216,9 +216,9 @@ static ssize_t pp_write(struct file *file, const char __user *buf,
mode = pport->ieee1284.mode & ~(IEEE1284_DEVICEID | IEEE1284_ADDR);
parport_set_timeout(pp->pdev,
- (file->f_flags & O_NONBLOCK) ?
- PARPORT_INACTIVITY_O_NONBLOCK :
- pp->default_inactivity);
+ (file->f_flags & O_NONBLOCK) ?
+ PARPORT_INACTIVITY_O_NONBLOCK :
+ pp->default_inactivity);
while (bytes_written < count) {
ssize_t n = min_t(unsigned long, count - bytes_written, PP_BUFFER_SIZE);
@@ -301,7 +301,7 @@ static int register_device(int minor, struct pp_struct *pp)
fl = (pp->flags & PP_EXCL) ? PARPORT_FLAG_EXCL : 0;
pdev = parport_register_device(port, name, NULL,
- NULL, pp_irq, fl, pp);
+ NULL, pp_irq, fl, pp);
parport_put_port(port);
if (!pdev) {
@@ -559,10 +559,10 @@ static int pp_do_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
case PPFCONTROL:
if (copy_from_user(&mask, argp,
- sizeof(mask)))
+ sizeof(mask)))
return -EFAULT;
if (copy_from_user(®, 1 + (unsigned char __user *) arg,
- sizeof(reg)))
+ sizeof(reg)))
return -EFAULT;
parport_frob_control(port, mask, reg);
return 0;
@@ -665,7 +665,7 @@ static long pp_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
#ifdef CONFIG_COMPAT
static long pp_compat_ioctl(struct file *file, unsigned int cmd,
- unsigned long arg)
+ unsigned long arg)
{
return pp_ioctl(file, cmd, (unsigned long)compat_ptr(arg));
}
@@ -811,7 +811,7 @@ static int __init ppdev_init(void)
if (register_chrdev(PP_MAJOR, CHRDEV, &pp_fops)) {
printk(KERN_WARNING CHRDEV ": unable to get major %d\n",
- PP_MAJOR);
+ PP_MAJOR);
return -EIO;
}
ppdev_class = class_create(THIS_MODULE, CHRDEV);
--
1.9.1
next prev parent reply other threads:[~2016-02-12 13:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 13:03 [PATCH 1/8] ppdev: space prohibited between function name and parenthesis Sudip Mukherjee
2016-02-12 13:03 ` [PATCH 2/8] ppdev: remove whitespace around pointers Sudip Mukherjee
2016-02-12 13:03 ` [PATCH 3/8] ppdev: add missing blank line Sudip Mukherjee
2016-02-12 13:03 ` [PATCH 4/8] ppdev: remove braces Sudip Mukherjee
2016-02-12 13:03 ` Sudip Mukherjee [this message]
2016-02-12 13:03 ` [PATCH 6/8] ppdev: remove space before tab Sudip Mukherjee
2016-02-12 13:03 ` [PATCH 7/8] ppdev: use new parport device model Sudip Mukherjee
2016-02-12 13:03 ` [PATCH 8/8] ppdev: use dev_* macros Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455282226-1968-5-git-send-email-sudipm.mukherjee@gmail.com \
--to=sudipm.mukherjee@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®