mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org,
	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: [PATCH 3/8] ppdev: add missing blank line
Date: Fri, 12 Feb 2016 18:33:41 +0530	[thread overview]
Message-ID: <1455282226-1968-3-git-send-email-sudipm.mukherjee@gmail.com> (raw)
In-Reply-To: <1455282226-1968-1-git-send-email-sudipm.mukherjee@gmail.com>

kernel coding style recommends a blank line after varaiable declaration.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
 drivers/char/ppdev.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/char/ppdev.c b/drivers/char/ppdev.c
index 8a168c4..c551c0c 100644
--- a/drivers/char/ppdev.c
+++ b/drivers/char/ppdev.c
@@ -109,6 +109,7 @@ static DEFINE_MUTEX(pp_do_mutex);
 static inline void pp_enable_irq(struct pp_struct *pp)
 {
 	struct parport *port = pp->pdev->port;
+
 	port->ops->enable_irq(port);
 }
 
@@ -368,6 +369,7 @@ static int pp_do_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
 		/* Deferred device registration. */
 		if (!pp->pdev) {
 			int err = register_device(minor, pp);
+
 			if (err) {
 				return err;
 			}
@@ -412,6 +414,7 @@ static int pp_do_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
 	case PPSETMODE:
 	    {
 		int mode;
+
 		if (copy_from_user(&mode, argp, sizeof(mode)))
 			return -EFAULT;
 		/* FIXME: validate mode */
@@ -442,6 +445,7 @@ static int pp_do_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
 	case PPSETPHASE:
 	    {
 		int phase;
+
 		if (copy_from_user(&phase, argp, sizeof(phase))) {
 			return -EFAULT;
 		}
@@ -665,6 +669,7 @@ static int pp_do_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
 static long pp_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
 {
 	long ret;
+
 	mutex_lock(&pp_do_mutex);
 	ret = pp_do_ioctl(file, cmd, arg);
 	mutex_unlock(&pp_do_mutex);
@@ -755,6 +760,7 @@ static int pp_release(struct inode *inode, struct file *file)
 
 	if (pp->pdev) {
 		const char *name = pp->pdev->name;
+
 		parport_unregister_device(pp->pdev);
 		kfree(name);
 		pp->pdev = NULL;
-- 
1.9.1

  parent reply	other threads:[~2016-02-12 13:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-12 13:03 [PATCH 1/8] ppdev: space prohibited between function name and parenthesis Sudip Mukherjee
2016-02-12 13:03 ` [PATCH 2/8] ppdev: remove whitespace around pointers Sudip Mukherjee
2016-02-12 13:03 ` Sudip Mukherjee [this message]
2016-02-12 13:03 ` [PATCH 4/8] ppdev: remove braces Sudip Mukherjee
2016-02-12 13:03 ` [PATCH 5/8] ppdev: fix parenthesis alignment Sudip Mukherjee
2016-02-12 13:03 ` [PATCH 6/8] ppdev: remove space before tab Sudip Mukherjee
2016-02-12 13:03 ` [PATCH 7/8] ppdev: use new parport device model Sudip Mukherjee
2016-02-12 13:03 ` [PATCH 8/8] ppdev: use dev_* macros Sudip Mukherjee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1455282226-1968-3-git-send-email-sudipm.mukherjee@gmail.com \
    --to=sudipm.mukherjee@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®