mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: green@linuxhacker.ru
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org,
	Andreas Dilger <andreas.dilger@intel.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Lustre Development List <lustre-devel@lists.lustre.org>,
	Oleg Drokin <green@linuxhacker.ru>
Subject: [PATCH v2 24/84] staging/lustre: Remove lustre_build_version.h
Date: Wed, 24 Feb 2016 22:00:07 -0500	[thread overview]
Message-ID: <1456369267-904461-25-git-send-email-green@linuxhacker.ru> (raw)
In-Reply-To: <1456369267-904461-1-git-send-email-green@linuxhacker.ru>

From: Oleg Drokin <green@linuxhacker.ru>

of the two macroses is contained the LUSTRE_RELEASE was unused and
BUILD_VERSION is too generically named and was replaced with
LUSTRE_VERSION_STRING with all the users (provided by lustre_ver.h)

With in-kernel client the build version should be combined with
kernel build information anyway.

Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
---
 .../lustre/lustre/include/lustre/lustre_build_version.h       |  2 --
 drivers/staging/lustre/lustre/obdclass/class_obd.c            | 11 +++++------
 drivers/staging/lustre/lustre/obdclass/linux/linux-module.c   |  1 -
 3 files changed, 5 insertions(+), 9 deletions(-)
 delete mode 100644 drivers/staging/lustre/lustre/include/lustre/lustre_build_version.h

diff --git a/drivers/staging/lustre/lustre/include/lustre/lustre_build_version.h b/drivers/staging/lustre/lustre/include/lustre/lustre_build_version.h
deleted file mode 100644
index 93a3d7d..0000000
--- a/drivers/staging/lustre/lustre/include/lustre/lustre_build_version.h
+++ /dev/null
@@ -1,2 +0,0 @@
-#define BUILD_VERSION "v2_3_64_0-g6e62c21-CHANGED-3.9.0"
-#define LUSTRE_RELEASE 3.9.0_g6e62c21
diff --git a/drivers/staging/lustre/lustre/obdclass/class_obd.c b/drivers/staging/lustre/lustre/obdclass/class_obd.c
index 4b7e21f..f805693 100644
--- a/drivers/staging/lustre/lustre/obdclass/class_obd.c
+++ b/drivers/staging/lustre/lustre/obdclass/class_obd.c
@@ -42,7 +42,6 @@
 #include "../../include/linux/lnet/lnetctl.h"
 #include "../include/lustre_debug.h"
 #include "../include/lprocfs_status.h"
-#include "../include/lustre/lustre_build_version.h"
 #include <linux/list.h>
 #include "../include/cl_object.h"
 #include "llog_internal.h"
@@ -218,14 +217,14 @@ int class_handle_ioctl(unsigned int cmd, unsigned long arg)
 			goto out;
 		}
 
-		if (strlen(BUILD_VERSION) + 1 > data->ioc_inllen1) {
+		if (strlen(LUSTRE_VERSION_STRING) + 1 > data->ioc_inllen1) {
 			CERROR("ioctl buffer too small to hold version\n");
 			err = -EINVAL;
 			goto out;
 		}
 
-		memcpy(data->ioc_bulk, BUILD_VERSION,
-		       strlen(BUILD_VERSION) + 1);
+		memcpy(data->ioc_bulk, LUSTRE_VERSION_STRING,
+		       strlen(LUSTRE_VERSION_STRING) + 1);
 
 		err = obd_ioctl_popdata((void __user *)arg, data, len);
 		if (err)
@@ -481,7 +480,7 @@ static int __init init_obdclass(void)
 
 	int lustre_register_fs(void);
 
-	LCONSOLE_INFO("Lustre: Build Version: "BUILD_VERSION"\n");
+	LCONSOLE_INFO("Lustre: Build Version: " LUSTRE_VERSION_STRING "\n");
 
 	spin_lock_init(&obd_types_lock);
 	obd_zombie_impexp_init();
@@ -579,7 +578,7 @@ static void cleanup_obdclass(void)
 }
 
 MODULE_AUTHOR("OpenSFS, Inc. <http://www.lustre.org/>");
-MODULE_DESCRIPTION("Lustre Class Driver Build Version: " BUILD_VERSION);
+MODULE_DESCRIPTION("Lustre Class Driver Build Version: " LUSTRE_VERSION_STRING);
 MODULE_LICENSE("GPL");
 MODULE_VERSION(LUSTRE_VERSION_STRING);
 
diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c b/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c
index 689f33a..f3c4a17 100644
--- a/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c
+++ b/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c
@@ -70,7 +70,6 @@
 #include "../../include/obd_class.h"
 #include "../../include/lprocfs_status.h"
 #include "../../include/lustre_ver.h"
-#include "../../include/lustre/lustre_build_version.h"
 
 /* buffer MUST be at least the size of obd_ioctl_hdr */
 int obd_ioctl_getdata(char **buf, int *len, void __user *arg)
-- 
2.1.0

  parent reply	other threads:[~2016-02-25  3:02 UTC|newest]

Thread overview: 87+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-25  2:59 [PATCH v2 00/84] Lustre cleanups green
2016-02-25  2:59 ` [PATCH v2 01/84] staging/lustre/ldlm: Remove unused lr_most_restr from struct ldlm_resource green
2016-02-25  2:59 ` [PATCH v2 02/84] staging/lustre/fld: Remove useless typedefs green
2016-02-25  2:59 ` [PATCH v2 03/84] staging/lustre: Get rid of client_obd_lock_t typedef green
2016-02-25  2:59 ` [PATCH v2 04/84] staging/lustre: Get rid of loc_flags_t typedef green
2016-02-25  2:59 ` [PATCH v2 05/84] staging/lustre: Get rid of cksum_type_t typedef green
2016-02-25  2:59 ` [PATCH v2 06/84] staging/lustre: Get rid of ost_cmd_t typedef green
2016-02-25  2:59 ` [PATCH v2 07/84] staging/lustre: Get rid of quota_cmd_t typedef green
2016-02-25  2:59 ` [PATCH v2 08/84] staging/lustre: Get rid of mds_cmd_t typedef green
2016-02-25  2:59 ` [PATCH v2 09/84] staging/lustre: Get rid of mds_reint_t, mdt_reint_t typedefs green
2016-02-25  2:59 ` [PATCH v2 10/84] staging/lustre: Get rid of ldlm_cmd_t typedef green
2016-02-25  2:59 ` [PATCH v2 11/84] staging/lustre: Remove ldlm type/mode typedefs green
2016-02-25  2:59 ` [PATCH v2 12/84] staging/lustre: Get rid of mgs_cmd_t typedef green
2016-02-25  2:59 ` [PATCH v2 13/84] staging/lustre: Get rid of obd_cmd_t typedef green
2016-02-25  2:59 ` [PATCH v2 14/84] staging/lustre: Get rid of llog_op_type typedef green
2016-02-25  2:59 ` [PATCH v2 15/84] staging/lustre: Get rid of sec_cmd_t typedef green
2016-02-25  2:59 ` [PATCH v2 16/84] staging/lustre: Get rid of object update code green
2016-02-25  3:00 ` [PATCH v2 17/84] staging/lustre: Get rid of lustre_fid typedef green
2016-02-25  3:00 ` [PATCH v2 18/84] staging/lustre: Get rid of lustre_quota_version typedef green
2016-02-25  3:00 ` [PATCH v2 19/84] staging/lustre: Get rid of ldlm_error_t typedef green
2016-02-25  3:00 ` [PATCH v2 20/84] staging/lustre: Remove ldlm_appetite_t typedef green
2016-02-25  3:00 ` [PATCH v2 21/84] staging/lustre: Get rid of ldlm_ns_type_t typedef green
2016-02-25  3:00 ` [PATCH v2 22/84] staging/lustre: Get rid of ldlm_cancel_flags_t typedef green
2016-02-25  3:00 ` [PATCH v2 23/84] staging/lustre/llite: Get rid of se_stat_t typedef green
2016-02-25  3:00 ` green [this message]
2016-02-25  3:00 ` [PATCH v2 25/84] staging/lustre: Get rid of C99 comments in lustre_idl.h green
2016-02-25  3:00 ` [PATCH v2 26/84] staging/lustre: Remove server-side changelog defines green
2016-02-25  3:00 ` [PATCH v2 27/84] staging/lustre: Remove FSF mailing address from GPL notices green
2016-02-25  3:00 ` [PATCH v2 28/84] staging/lustre: Remove server-only values from enum lu_dirent_attrs green
2016-02-25  3:00 ` [PATCH v2 29/84] staging/lustre: Remove *_CONNECT_SUPPORTED defines green
2016-02-25  3:00 ` [PATCH v2 30/84] staging/lustre: Remove duplicated quota defines green
2016-02-25  3:00 ` [PATCH v2 31/84] staging/lustre: Remove unused struct quota_body green
2016-02-25  3:00 ` [PATCH v2 32/84] staging/lustre: Remove lquota_glb_rec, lquota_slv_rec and lquota_acct_rec green
2016-02-25  3:00 ` [PATCH v2 33/84] staging/lustre: S_DIRSYNC is always defined in kernel green
2016-02-25  3:00 ` [PATCH v2 34/84] staging/lustre: FMODE_READ and FMODE_WRITE are always defined in the kernel green
2016-02-25  3:00 ` [PATCH v2 35/84] staging/lustre: Remove index file transfer structures green
2016-02-25  3:00 ` [PATCH v2 36/84] staging/lustre: Remove server data from struct obd_export green
2016-02-25  3:00 ` [PATCH v2 37/84] staging/lustre: Remove last_rcvd-file related data green
2016-02-25  3:00 ` [PATCH v2 38/84] staging/lustre: Remove dead code in ldlm_lock_destroy_internal green
2016-02-25  3:00 ` [PATCH v2 39/84] staging/lustre: MAY_NOT_BLOCK is always defined, don't check for it green
2016-02-25  3:00 ` [PATCH v2 40/84] staging/lustre: Remove unused lli_open_count from struct ll_inode_info green
2016-02-25  3:00 ` [PATCH v2 41/84] staging/lustre: Reformat comments and structures in lustre_idl.h green
2016-02-25  3:00 ` [PATCH v2 42/84] staging/lustre/include: Adjust comment style green
2016-02-25  3:00 ` [PATCH v2 43/84] staging/lustre/fld: Adjust comments to better conform to coding style green
2016-02-25  3:00 ` [PATCH v2 44/84] staging/lustre/fid: " green
2016-02-25  3:00 ` [PATCH v2 45/84] staging/lustre/lclient: " green
2016-02-25  3:00 ` [PATCH v2 46/84] staging/lustre/ldlm: " green
2016-02-25  3:00 ` [PATCH v2 47/84] staging/lustre/llite: " green
2016-02-25  3:00 ` [PATCH v2 48/84] staging/lustre/lmv: " green
2016-02-25  3:00 ` [PATCH v2 49/84] staging/lustre/lov: " green
2016-02-25  3:00 ` [PATCH v2 50/84] staging/lustre/mdc: " green
2016-02-25  3:00 ` [PATCH v2 51/84] staging/lustre/mgc: " green
2016-02-25  3:00 ` [PATCH v2 52/84] staging/lustre/obdclass: " green
2016-02-25  3:00 ` [PATCH v2 53/84] staging/lustre/obdecho: " green
2016-02-25  3:00 ` [PATCH v2 54/84] staging/lustre/osc: " green
2016-02-25  3:00 ` [PATCH v2 55/84] staging/lustre/ptlrpc: " green
2016-02-25  3:00 ` [PATCH v2 56/84] staging/lustre: Fix indentation mistakes green
2016-02-25  3:00 ` [PATCH v2 57/84] staging/lustre: Remove stray space before newline in messages green
2016-02-25  3:00 ` [PATCH v2 58/84] staging/lustre: Remove commented out obd functions green
2016-02-25  3:00 ` [PATCH v2 59/84] staging/lustre: Remove unused members of struct ll_sb_info green
2016-02-25  3:00 ` [PATCH v2 60/84] staging/lustre/llite: Fix style vs open parenthesis alignment green
2016-02-26  6:10   ` Greg Kroah-Hartman
2016-02-26  6:13     ` Oleg Drokin
2016-02-25  3:00 ` [PATCH v2 61/84] staging/lustre/include: Fix style of function declarations green
2016-02-25  3:00 ` [PATCH v2 62/84] staging/lustre/fld: Fix style vs open parenthesis alignment green
2016-02-25  3:00 ` [PATCH v2 63/84] staging/lustre: Remove unused liblustre_check_services prototype green
2016-02-25  3:00 ` [PATCH v2 64/84] staging/lustre: Remove unused lustre_build_lock_params() green
2016-02-25  3:00 ` [PATCH v2 65/84] staging/lustre: Convert ptlrpc_at_check_timed to void green
2016-02-25  3:00 ` [PATCH v2 66/84] staging/lustre: Remove misleading liblustre comments green
2016-02-25  3:00 ` [PATCH v2 67/84] staging/lustre: Remove liblustre references from explanations green
2016-02-25  3:00 ` [PATCH v2 68/84] staging/lustre/lmv: Remove commented out MDS selection policies green
2016-02-25  3:00 ` [PATCH v2 69/84] staging/lustre: F_SETLKW64 F_SETLK64 F_GETLK64 are always defined green
2016-02-25  3:00 ` [PATCH v2 70/84] staging/lustre: MS_POSIXACL is always defined, don't check for it green
2016-02-25  3:00 ` [PATCH v2 71/84] staging/lustre: Remove RELEASEPAGE_ARG_TYPE compat macro green
2016-02-25  3:00 ` [PATCH v2 72/84] staging/lustre: NEED_QUOTA_DEFS is never defined, drop it green
2016-02-25  3:00 ` [PATCH v2 73/84] staging/lustre/ptlrpc: Fix style vs open parenthesis alignment green
2016-02-25  3:00 ` [PATCH v2 74/84] staging/lustre/osc: " green
2016-02-25  3:00 ` [PATCH v2 75/84] staging/lustre/obdclass: " green
2016-02-25  3:00 ` [PATCH v2 76/84] staging/lustre/lov: " green
2016-02-25  3:01 ` [PATCH v2 77/84] staging/lustre/mdc: " green
2016-02-25  3:01 ` [PATCH v2 78/84] staging/lustre/mgc: " green
2016-02-25  3:01 ` [PATCH v2 79/84] staging/lustre/obdecho: " green
2016-02-25  3:01 ` [PATCH v2 80/84] staging/lustre/lmv: " green
2016-02-25  3:01 ` [PATCH v2 81/84] staging/lustre: Fix lines that start with spaces green
2016-02-25  3:01 ` [PATCH v2 82/84] staging/lustre: Rework MAX_DIO_SIZE macro green
2016-02-25  3:01 ` [PATCH v2 83/84] staging/lustre: Remove unneeded {} in lprocfs_stats_unlock() green
2016-02-25  3:01 ` [PATCH v2 84/84] staging/lustre/ptlrpc: Fix ENABLE_PINGER ifdef green

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1456369267-904461-25-git-send-email-green@linuxhacker.ru \
    --to=green@linuxhacker.ru \
    --cc=andreas.dilger@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lustre-devel@lists.lustre.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome