mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: green@linuxhacker.ru
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org,
	Andreas Dilger <andreas.dilger@intel.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Lustre Development List <lustre-devel@lists.lustre.org>,
	Oleg Drokin <green@linuxhacker.ru>
Subject: [PATCH v2 48/84] staging/lustre/lmv: Adjust comments to better conform to coding style
Date: Wed, 24 Feb 2016 22:00:31 -0500	[thread overview]
Message-ID: <1456369267-904461-49-git-send-email-green@linuxhacker.ru> (raw)
In-Reply-To: <1456369267-904461-1-git-send-email-green@linuxhacker.ru>

From: Oleg Drokin <green@linuxhacker.ru>

This patch fixes "Block comments use a trailing */ on a separate line"
warnings from checkpatch.

Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
---
 drivers/staging/lustre/lustre/lmv/lmv_fld.c    |  3 ++-
 drivers/staging/lustre/lustre/lmv/lmv_intent.c |  9 ++++---
 drivers/staging/lustre/lustre/lmv/lmv_obd.c    | 37 +++++++++++++++++---------
 3 files changed, 32 insertions(+), 17 deletions(-)

diff --git a/drivers/staging/lustre/lustre/lmv/lmv_fld.c b/drivers/staging/lustre/lustre/lmv/lmv_fld.c
index ee23592..378691b 100644
--- a/drivers/staging/lustre/lustre/lmv/lmv_fld.c
+++ b/drivers/staging/lustre/lustre/lmv/lmv_fld.c
@@ -58,7 +58,8 @@ int lmv_fld_lookup(struct lmv_obd *lmv,
 	int rc;
 
 	/* FIXME: Currently ZFS still use local seq for ROOT unfortunately, and
-	 * this fid_is_local check should be removed once LU-2240 is fixed */
+	 * this fid_is_local check should be removed once LU-2240 is fixed
+	 */
 	LASSERTF((fid_seq_in_fldb(fid_seq(fid)) ||
 		  fid_seq_is_local_file(fid_seq(fid))) &&
 		 fid_is_sane(fid), DFID" is insane!\n", PFID(fid));
diff --git a/drivers/staging/lustre/lustre/lmv/lmv_intent.c b/drivers/staging/lustre/lustre/lmv/lmv_intent.c
index cb1ed42..259b211 100644
--- a/drivers/staging/lustre/lustre/lmv/lmv_intent.c
+++ b/drivers/staging/lustre/lustre/lmv/lmv_intent.c
@@ -110,11 +110,13 @@ static int lmv_intent_remote(struct obd_export *exp, void *lmm,
 	if (parent_fid) {
 		/* The parent fid is only for remote open to
 		 * check whether the open is from OBF,
-		 * see mdt_cross_open */
+		 * see mdt_cross_open
+		 */
 		LASSERT(it->it_op & IT_OPEN);
 		op_data->op_fid2 = *parent_fid;
 		/* Add object FID to op_fid3, in case it needs to check stale
-		 * (M_CHECK_STALE), see mdc_finish_intent_lock */
+		 * (M_CHECK_STALE), see mdc_finish_intent_lock
+		 */
 		op_data->op_fid3 = body->fid1;
 	}
 
@@ -173,7 +175,8 @@ static int lmv_intent_open(struct obd_export *exp, struct md_op_data *op_data,
 		return PTR_ERR(tgt);
 
 	/* If it is ready to open the file by FID, do not need
-	 * allocate FID at all, otherwise it will confuse MDT */
+	 * allocate FID at all, otherwise it will confuse MDT
+	 */
 	if ((it->it_op & IT_CREAT) &&
 	    !(it->it_flags & MDS_OPEN_BY_FID)) {
 		/*
diff --git a/drivers/staging/lustre/lustre/lmv/lmv_obd.c b/drivers/staging/lustre/lustre/lmv/lmv_obd.c
index eb1c85f..67746c9 100644
--- a/drivers/staging/lustre/lustre/lmv/lmv_obd.c
+++ b/drivers/staging/lustre/lustre/lmv/lmv_obd.c
@@ -679,7 +679,8 @@ repeat_fid2path:
 		goto out_fid2path;
 
 	/* If remote_gf != NULL, it means just building the
-	 * path on the remote MDT, copy this path segment to gf */
+	 * path on the remote MDT, copy this path segment to gf
+	 */
 	if (remote_gf) {
 		struct getinfo_fid2path *ori_gf;
 		char *ptr;
@@ -797,7 +798,8 @@ static int lmv_hsm_ct_unregister(struct lmv_obd *lmv, unsigned int cmd, int len,
 	/* unregister request (call from llapi_hsm_copytool_fini) */
 	for (i = 0; i < lmv->desc.ld_tgt_count; i++) {
 		/* best effort: try to clean as much as possible
-		 * (continue on error) */
+		 * (continue on error)
+		 */
 		obd_iocontrol(cmd, lmv->tgts[i]->ltd_exp, len, lk, uarg);
 	}
 
@@ -821,7 +823,8 @@ static int lmv_hsm_ct_register(struct lmv_obd *lmv, unsigned int cmd, int len,
 
 	/* All or nothing: try to register to all MDS.
 	 * In case of failure, unregister from previous MDS,
-	 * except if it because of inactive target. */
+	 * except if it because of inactive target.
+	 */
 	for (i = 0; i < lmv->desc.ld_tgt_count; i++) {
 		err = obd_iocontrol(cmd, lmv->tgts[i]->ltd_exp,
 				   len, lk, uarg);
@@ -841,8 +844,8 @@ static int lmv_hsm_ct_register(struct lmv_obd *lmv, unsigned int cmd, int len,
 				return rc;
 			}
 			/* else: transient error.
-			 * kuc will register to the missing MDT
-			 * when it is back */
+			 * kuc will register to the missing MDT when it is back
+			 */
 		} else {
 			any_set = true;
 		}
@@ -1028,7 +1031,8 @@ static int lmv_iocontrol(unsigned int cmd, struct obd_export *exp,
 
 		/* if the request is about a single fid
 		 * or if there is a single MDS, no need to split
-		 * the request. */
+		 * the request.
+		 */
 		if (reqcount == 1 || count == 1) {
 			tgt = lmv_find_target(lmv,
 					      &hur->hur_user_item[0].hui_fid);
@@ -1104,7 +1108,8 @@ static int lmv_iocontrol(unsigned int cmd, struct obd_export *exp,
 			if (!lmv->tgts[i] || !lmv->tgts[i]->ltd_exp)
 				continue;
 			/* ll_umount_begin() sets force flag but for lmv, not
-			 * mdc. Let's pass it through */
+			 * mdc. Let's pass it through
+			 */
 			mdc_obd = class_exp2obd(lmv->tgts[i]->ltd_exp);
 			mdc_obd->obd_force = obddev->obd_force;
 			err = obd_iocontrol(cmd, lmv->tgts[i]->ltd_exp, len,
@@ -1211,7 +1216,8 @@ static int lmv_placement_policy(struct obd_device *obd,
 	}
 
 	/* Allocate new fid on target according to operation type and parent
-	 * home mds. */
+	 * home mds.
+	 */
 	*mds = op_data->op_mds;
 	return 0;
 }
@@ -1363,7 +1369,8 @@ static int lmv_process_config(struct obd_device *obd, u32 len, void *buf)
 	switch (lcfg->lcfg_command) {
 	case LCFG_ADD_MDC:
 		/* modify_mdc_tgts add 0:lustre-clilmv  1:lustre-MDT0000_UUID
-		 * 2:0  3:1  4:lustre-MDT0000-mdc_UUID */
+		 * 2:0  3:1  4:lustre-MDT0000-mdc_UUID
+		 */
 		if (LUSTRE_CFG_BUFLEN(lcfg, 1) > sizeof(obd_uuid.uuid)) {
 			rc = -EINVAL;
 			goto out;
@@ -1427,7 +1434,8 @@ static int lmv_statfs(const struct lu_env *env, struct obd_export *exp,
 			 * i.e. mount does not need the merged osfs
 			 * from all of MDT.
 			 * And also clients can be mounted as long as
-			 * MDT0 is in service*/
+			 * MDT0 is in service
+			 */
 			if (flags & OBD_STATFS_FOR_MDT0)
 				goto out_free_temp;
 		} else {
@@ -2122,7 +2130,8 @@ static void lmv_adjust_dirpages(struct page **pages, int ncfspgs, int nlupgs)
 				break;
 
 			/* Enlarge the end entry lde_reclen from 0 to
-			 * first entry of next lu_dirpage. */
+			 * first entry of next lu_dirpage.
+			 */
 			LASSERT(le16_to_cpu(end_dirent->lde_reclen) == 0);
 			end_dirent->lde_reclen =
 				cpu_to_le16((char *)(dp->ldp_entries) -
@@ -2260,7 +2269,8 @@ retry:
 	 * 4. Then A will resend unlink RPC to MDT0. (retry 2nd times).
 	 *
 	 * In theory, it might try unlimited time here, but it should
-	 * be very rare case.  */
+	 * be very rare case.
+	 */
 	op_data->op_fid2 = body->fid1;
 	ptlrpc_req_finished(*request);
 	*request = NULL;
@@ -2275,7 +2285,8 @@ static int lmv_precleanup(struct obd_device *obd, enum obd_cleanup_stage stage)
 	switch (stage) {
 	case OBD_CLEANUP_EARLY:
 		/* XXX: here should be calling obd_precleanup() down to
-		 * stack. */
+		 * stack.
+		 */
 		break;
 	case OBD_CLEANUP_EXPORTS:
 		fld_client_debugfs_fini(&lmv->lmv_fld);
-- 
2.1.0

  parent reply	other threads:[~2016-02-25  3:15 UTC|newest]

Thread overview: 87+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-25  2:59 [PATCH v2 00/84] Lustre cleanups green
2016-02-25  2:59 ` [PATCH v2 01/84] staging/lustre/ldlm: Remove unused lr_most_restr from struct ldlm_resource green
2016-02-25  2:59 ` [PATCH v2 02/84] staging/lustre/fld: Remove useless typedefs green
2016-02-25  2:59 ` [PATCH v2 03/84] staging/lustre: Get rid of client_obd_lock_t typedef green
2016-02-25  2:59 ` [PATCH v2 04/84] staging/lustre: Get rid of loc_flags_t typedef green
2016-02-25  2:59 ` [PATCH v2 05/84] staging/lustre: Get rid of cksum_type_t typedef green
2016-02-25  2:59 ` [PATCH v2 06/84] staging/lustre: Get rid of ost_cmd_t typedef green
2016-02-25  2:59 ` [PATCH v2 07/84] staging/lustre: Get rid of quota_cmd_t typedef green
2016-02-25  2:59 ` [PATCH v2 08/84] staging/lustre: Get rid of mds_cmd_t typedef green
2016-02-25  2:59 ` [PATCH v2 09/84] staging/lustre: Get rid of mds_reint_t, mdt_reint_t typedefs green
2016-02-25  2:59 ` [PATCH v2 10/84] staging/lustre: Get rid of ldlm_cmd_t typedef green
2016-02-25  2:59 ` [PATCH v2 11/84] staging/lustre: Remove ldlm type/mode typedefs green
2016-02-25  2:59 ` [PATCH v2 12/84] staging/lustre: Get rid of mgs_cmd_t typedef green
2016-02-25  2:59 ` [PATCH v2 13/84] staging/lustre: Get rid of obd_cmd_t typedef green
2016-02-25  2:59 ` [PATCH v2 14/84] staging/lustre: Get rid of llog_op_type typedef green
2016-02-25  2:59 ` [PATCH v2 15/84] staging/lustre: Get rid of sec_cmd_t typedef green
2016-02-25  2:59 ` [PATCH v2 16/84] staging/lustre: Get rid of object update code green
2016-02-25  3:00 ` [PATCH v2 17/84] staging/lustre: Get rid of lustre_fid typedef green
2016-02-25  3:00 ` [PATCH v2 18/84] staging/lustre: Get rid of lustre_quota_version typedef green
2016-02-25  3:00 ` [PATCH v2 19/84] staging/lustre: Get rid of ldlm_error_t typedef green
2016-02-25  3:00 ` [PATCH v2 20/84] staging/lustre: Remove ldlm_appetite_t typedef green
2016-02-25  3:00 ` [PATCH v2 21/84] staging/lustre: Get rid of ldlm_ns_type_t typedef green
2016-02-25  3:00 ` [PATCH v2 22/84] staging/lustre: Get rid of ldlm_cancel_flags_t typedef green
2016-02-25  3:00 ` [PATCH v2 23/84] staging/lustre/llite: Get rid of se_stat_t typedef green
2016-02-25  3:00 ` [PATCH v2 24/84] staging/lustre: Remove lustre_build_version.h green
2016-02-25  3:00 ` [PATCH v2 25/84] staging/lustre: Get rid of C99 comments in lustre_idl.h green
2016-02-25  3:00 ` [PATCH v2 26/84] staging/lustre: Remove server-side changelog defines green
2016-02-25  3:00 ` [PATCH v2 27/84] staging/lustre: Remove FSF mailing address from GPL notices green
2016-02-25  3:00 ` [PATCH v2 28/84] staging/lustre: Remove server-only values from enum lu_dirent_attrs green
2016-02-25  3:00 ` [PATCH v2 29/84] staging/lustre: Remove *_CONNECT_SUPPORTED defines green
2016-02-25  3:00 ` [PATCH v2 30/84] staging/lustre: Remove duplicated quota defines green
2016-02-25  3:00 ` [PATCH v2 31/84] staging/lustre: Remove unused struct quota_body green
2016-02-25  3:00 ` [PATCH v2 32/84] staging/lustre: Remove lquota_glb_rec, lquota_slv_rec and lquota_acct_rec green
2016-02-25  3:00 ` [PATCH v2 33/84] staging/lustre: S_DIRSYNC is always defined in kernel green
2016-02-25  3:00 ` [PATCH v2 34/84] staging/lustre: FMODE_READ and FMODE_WRITE are always defined in the kernel green
2016-02-25  3:00 ` [PATCH v2 35/84] staging/lustre: Remove index file transfer structures green
2016-02-25  3:00 ` [PATCH v2 36/84] staging/lustre: Remove server data from struct obd_export green
2016-02-25  3:00 ` [PATCH v2 37/84] staging/lustre: Remove last_rcvd-file related data green
2016-02-25  3:00 ` [PATCH v2 38/84] staging/lustre: Remove dead code in ldlm_lock_destroy_internal green
2016-02-25  3:00 ` [PATCH v2 39/84] staging/lustre: MAY_NOT_BLOCK is always defined, don't check for it green
2016-02-25  3:00 ` [PATCH v2 40/84] staging/lustre: Remove unused lli_open_count from struct ll_inode_info green
2016-02-25  3:00 ` [PATCH v2 41/84] staging/lustre: Reformat comments and structures in lustre_idl.h green
2016-02-25  3:00 ` [PATCH v2 42/84] staging/lustre/include: Adjust comment style green
2016-02-25  3:00 ` [PATCH v2 43/84] staging/lustre/fld: Adjust comments to better conform to coding style green
2016-02-25  3:00 ` [PATCH v2 44/84] staging/lustre/fid: " green
2016-02-25  3:00 ` [PATCH v2 45/84] staging/lustre/lclient: " green
2016-02-25  3:00 ` [PATCH v2 46/84] staging/lustre/ldlm: " green
2016-02-25  3:00 ` [PATCH v2 47/84] staging/lustre/llite: " green
2016-02-25  3:00 ` green [this message]
2016-02-25  3:00 ` [PATCH v2 49/84] staging/lustre/lov: " green
2016-02-25  3:00 ` [PATCH v2 50/84] staging/lustre/mdc: " green
2016-02-25  3:00 ` [PATCH v2 51/84] staging/lustre/mgc: " green
2016-02-25  3:00 ` [PATCH v2 52/84] staging/lustre/obdclass: " green
2016-02-25  3:00 ` [PATCH v2 53/84] staging/lustre/obdecho: " green
2016-02-25  3:00 ` [PATCH v2 54/84] staging/lustre/osc: " green
2016-02-25  3:00 ` [PATCH v2 55/84] staging/lustre/ptlrpc: " green
2016-02-25  3:00 ` [PATCH v2 56/84] staging/lustre: Fix indentation mistakes green
2016-02-25  3:00 ` [PATCH v2 57/84] staging/lustre: Remove stray space before newline in messages green
2016-02-25  3:00 ` [PATCH v2 58/84] staging/lustre: Remove commented out obd functions green
2016-02-25  3:00 ` [PATCH v2 59/84] staging/lustre: Remove unused members of struct ll_sb_info green
2016-02-25  3:00 ` [PATCH v2 60/84] staging/lustre/llite: Fix style vs open parenthesis alignment green
2016-02-26  6:10   ` Greg Kroah-Hartman
2016-02-26  6:13     ` Oleg Drokin
2016-02-25  3:00 ` [PATCH v2 61/84] staging/lustre/include: Fix style of function declarations green
2016-02-25  3:00 ` [PATCH v2 62/84] staging/lustre/fld: Fix style vs open parenthesis alignment green
2016-02-25  3:00 ` [PATCH v2 63/84] staging/lustre: Remove unused liblustre_check_services prototype green
2016-02-25  3:00 ` [PATCH v2 64/84] staging/lustre: Remove unused lustre_build_lock_params() green
2016-02-25  3:00 ` [PATCH v2 65/84] staging/lustre: Convert ptlrpc_at_check_timed to void green
2016-02-25  3:00 ` [PATCH v2 66/84] staging/lustre: Remove misleading liblustre comments green
2016-02-25  3:00 ` [PATCH v2 67/84] staging/lustre: Remove liblustre references from explanations green
2016-02-25  3:00 ` [PATCH v2 68/84] staging/lustre/lmv: Remove commented out MDS selection policies green
2016-02-25  3:00 ` [PATCH v2 69/84] staging/lustre: F_SETLKW64 F_SETLK64 F_GETLK64 are always defined green
2016-02-25  3:00 ` [PATCH v2 70/84] staging/lustre: MS_POSIXACL is always defined, don't check for it green
2016-02-25  3:00 ` [PATCH v2 71/84] staging/lustre: Remove RELEASEPAGE_ARG_TYPE compat macro green
2016-02-25  3:00 ` [PATCH v2 72/84] staging/lustre: NEED_QUOTA_DEFS is never defined, drop it green
2016-02-25  3:00 ` [PATCH v2 73/84] staging/lustre/ptlrpc: Fix style vs open parenthesis alignment green
2016-02-25  3:00 ` [PATCH v2 74/84] staging/lustre/osc: " green
2016-02-25  3:00 ` [PATCH v2 75/84] staging/lustre/obdclass: " green
2016-02-25  3:00 ` [PATCH v2 76/84] staging/lustre/lov: " green
2016-02-25  3:01 ` [PATCH v2 77/84] staging/lustre/mdc: " green
2016-02-25  3:01 ` [PATCH v2 78/84] staging/lustre/mgc: " green
2016-02-25  3:01 ` [PATCH v2 79/84] staging/lustre/obdecho: " green
2016-02-25  3:01 ` [PATCH v2 80/84] staging/lustre/lmv: " green
2016-02-25  3:01 ` [PATCH v2 81/84] staging/lustre: Fix lines that start with spaces green
2016-02-25  3:01 ` [PATCH v2 82/84] staging/lustre: Rework MAX_DIO_SIZE macro green
2016-02-25  3:01 ` [PATCH v2 83/84] staging/lustre: Remove unneeded {} in lprocfs_stats_unlock() green
2016-02-25  3:01 ` [PATCH v2 84/84] staging/lustre/ptlrpc: Fix ENABLE_PINGER ifdef green

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1456369267-904461-49-git-send-email-green@linuxhacker.ru \
    --to=green@linuxhacker.ru \
    --cc=andreas.dilger@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lustre-devel@lists.lustre.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome