From: green@linuxhacker.ru
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org,
Andreas Dilger <andreas.dilger@intel.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lustre Development List <lustre-devel@lists.lustre.org>,
Oleg Drokin <green@linuxhacker.ru>
Subject: [PATCH v2 45/84] staging/lustre/lclient: Adjust comments to better conform to coding style
Date: Wed, 24 Feb 2016 22:00:28 -0500 [thread overview]
Message-ID: <1456369267-904461-46-git-send-email-green@linuxhacker.ru> (raw)
In-Reply-To: <1456369267-904461-1-git-send-email-green@linuxhacker.ru>
From: Oleg Drokin <green@linuxhacker.ru>
This patch fixes "Block comments use a trailing */ on a separate line"
warnings from checkpatch.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
---
drivers/staging/lustre/lustre/lclient/glimpse.c | 3 ++-
drivers/staging/lustre/lustre/lclient/lcommon_cl.c | 24 ++++++++++++++--------
.../staging/lustre/lustre/lclient/lcommon_misc.c | 6 ++++--
3 files changed, 22 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/lustre/lustre/lclient/glimpse.c b/drivers/staging/lustre/lustre/lclient/glimpse.c
index 8533a1e..c4e8a08 100644
--- a/drivers/staging/lustre/lustre/lclient/glimpse.c
+++ b/drivers/staging/lustre/lustre/lclient/glimpse.c
@@ -109,7 +109,8 @@ int cl_glimpse_lock(const struct lu_env *env, struct cl_io *io,
* if there were no conflicting locks. If there
* were conflicting locks, enqueuing or waiting
* fails with -ENAVAIL, but valid inode
- * attributes are returned anyway. */
+ * attributes are returned anyway.
+ */
*descr = whole_file;
descr->cld_obj = clob;
descr->cld_mode = CLM_PHANTOM;
diff --git a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
index efa6e2e..30651f2 100644
--- a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
+++ b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
@@ -613,7 +613,8 @@ void ccc_lock_state(const struct lu_env *env,
* stale i_size when doing appending writes and effectively
* cancel the result of the truncate. Getting the
* ll_inode_size_lock() after the enqueue maintains the DLM
- * -> ll_inode_size_lock() acquiring order. */
+ * -> ll_inode_size_lock() acquiring order.
+ */
if (lock->cll_descr.cld_start == 0 &&
lock->cll_descr.cld_end == CL_PAGE_EOF)
cl_merge_lvb(env, inode);
@@ -754,7 +755,8 @@ int ccc_prep_size(const struct lu_env *env, struct cl_object *obj,
* page index, return directly. Do not expect
* kernel will check such case correctly.
* linux-2.6.18-128.1.1 miss to do that.
- * --bug 17336 */
+ * --bug 17336
+ */
loff_t size = cl_isize_read(inode);
loff_t cur_index = start >> PAGE_CACHE_SHIFT;
loff_t size_index = (size - 1) >>
@@ -884,7 +886,8 @@ again:
if (attr->ia_valid & ATTR_FILE)
/* populate the file descriptor for ftruncate to honor
- * group lock - see LU-787 */
+ * group lock - see LU-787
+ */
cio->cui_fd = cl_iattr2fd(inode, attr);
result = cl_io_loop(env, io);
@@ -896,7 +899,8 @@ again:
goto again;
/* HSM import case: file is released, cannot be restored
* no need to fail except if restore registration failed
- * with -ENODATA */
+ * with -ENODATA
+ */
if (result == -ENODATA && io->ci_restore_needed &&
io->ci_result != -ENODATA)
result = 0;
@@ -1026,7 +1030,8 @@ int cl_file_inode_init(struct inode *inode, struct lustre_md *md)
/* clob is slave of inode, empty lli_clob means for new inode,
* there is no clob in cache with the given fid, so it is
* unnecessary to perform lookup-alloc-lookup-insert, just
- * alloc and insert directly. */
+ * alloc and insert directly.
+ */
LASSERT(inode->i_state & I_NEW);
conf.coc_lu.loc_flags = LOC_F_NEW;
clob = cl_object_find(env, lu2cl_dev(site->ls_top_dev),
@@ -1151,7 +1156,8 @@ __u16 ll_dirent_type_get(struct lu_dirent *ent)
}
/**
- * build inode number from passed @fid */
+ * build inode number from passed @fid
+ */
__u64 cl_fid_build_ino(const struct lu_fid *fid, int api32)
{
if (BITS_PER_LONG == 32 || api32)
@@ -1162,7 +1168,8 @@ __u64 cl_fid_build_ino(const struct lu_fid *fid, int api32)
/**
* build inode generation from passed @fid. If our FID overflows the 32-bit
- * inode number then return a non-zero generation to distinguish them. */
+ * inode number then return a non-zero generation to distinguish them.
+ */
__u32 cl_fid_build_gen(const struct lu_fid *fid)
{
__u32 gen;
@@ -1183,7 +1190,8 @@ __u32 cl_fid_build_gen(const struct lu_fid *fid)
* have to wait for the refcount to become zero to destroy the older layout.
*
* Notice that the lsm returned by this function may not be valid unless called
- * inside layout lock - MDS_INODELOCK_LAYOUT. */
+ * inside layout lock - MDS_INODELOCK_LAYOUT.
+ */
struct lov_stripe_md *ccc_inode_lsm_get(struct inode *inode)
{
return lov_lsm_get(cl_i2info(inode)->lli_clob);
diff --git a/drivers/staging/lustre/lustre/lclient/lcommon_misc.c b/drivers/staging/lustre/lustre/lclient/lcommon_misc.c
index 8389a0e..d80bcedd 100644
--- a/drivers/staging/lustre/lustre/lclient/lcommon_misc.c
+++ b/drivers/staging/lustre/lustre/lclient/lcommon_misc.c
@@ -48,7 +48,8 @@
/* Initialize the default and maximum LOV EA and cookie sizes. This allows
* us to make MDS RPCs with large enough reply buffers to hold the
* maximum-sized (= maximum striped) EA and cookie without having to
- * calculate this (via a call into the LOV + OSCs) each time we make an RPC. */
+ * calculate this (via a call into the LOV + OSCs) each time we make an RPC.
+ */
int cl_init_ea_size(struct obd_export *md_exp, struct obd_export *dt_exp)
{
struct lov_stripe_md lsm = { .lsm_magic = LOV_MAGIC_V3 };
@@ -74,7 +75,8 @@ int cl_init_ea_size(struct obd_export *md_exp, struct obd_export *dt_exp)
cookiesize = stripes * sizeof(struct llog_cookie);
/* default cookiesize is 0 because from 2.4 server doesn't send
- * llog cookies to client. */
+ * llog cookies to client.
+ */
CDEBUG(D_HA,
"updating def/max_easize: %d/%d def/max_cookiesize: 0/%d\n",
def_easize, easize, cookiesize);
--
2.1.0
next prev parent reply other threads:[~2016-02-25 3:16 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 2:59 [PATCH v2 00/84] Lustre cleanups green
2016-02-25 2:59 ` [PATCH v2 01/84] staging/lustre/ldlm: Remove unused lr_most_restr from struct ldlm_resource green
2016-02-25 2:59 ` [PATCH v2 02/84] staging/lustre/fld: Remove useless typedefs green
2016-02-25 2:59 ` [PATCH v2 03/84] staging/lustre: Get rid of client_obd_lock_t typedef green
2016-02-25 2:59 ` [PATCH v2 04/84] staging/lustre: Get rid of loc_flags_t typedef green
2016-02-25 2:59 ` [PATCH v2 05/84] staging/lustre: Get rid of cksum_type_t typedef green
2016-02-25 2:59 ` [PATCH v2 06/84] staging/lustre: Get rid of ost_cmd_t typedef green
2016-02-25 2:59 ` [PATCH v2 07/84] staging/lustre: Get rid of quota_cmd_t typedef green
2016-02-25 2:59 ` [PATCH v2 08/84] staging/lustre: Get rid of mds_cmd_t typedef green
2016-02-25 2:59 ` [PATCH v2 09/84] staging/lustre: Get rid of mds_reint_t, mdt_reint_t typedefs green
2016-02-25 2:59 ` [PATCH v2 10/84] staging/lustre: Get rid of ldlm_cmd_t typedef green
2016-02-25 2:59 ` [PATCH v2 11/84] staging/lustre: Remove ldlm type/mode typedefs green
2016-02-25 2:59 ` [PATCH v2 12/84] staging/lustre: Get rid of mgs_cmd_t typedef green
2016-02-25 2:59 ` [PATCH v2 13/84] staging/lustre: Get rid of obd_cmd_t typedef green
2016-02-25 2:59 ` [PATCH v2 14/84] staging/lustre: Get rid of llog_op_type typedef green
2016-02-25 2:59 ` [PATCH v2 15/84] staging/lustre: Get rid of sec_cmd_t typedef green
2016-02-25 2:59 ` [PATCH v2 16/84] staging/lustre: Get rid of object update code green
2016-02-25 3:00 ` [PATCH v2 17/84] staging/lustre: Get rid of lustre_fid typedef green
2016-02-25 3:00 ` [PATCH v2 18/84] staging/lustre: Get rid of lustre_quota_version typedef green
2016-02-25 3:00 ` [PATCH v2 19/84] staging/lustre: Get rid of ldlm_error_t typedef green
2016-02-25 3:00 ` [PATCH v2 20/84] staging/lustre: Remove ldlm_appetite_t typedef green
2016-02-25 3:00 ` [PATCH v2 21/84] staging/lustre: Get rid of ldlm_ns_type_t typedef green
2016-02-25 3:00 ` [PATCH v2 22/84] staging/lustre: Get rid of ldlm_cancel_flags_t typedef green
2016-02-25 3:00 ` [PATCH v2 23/84] staging/lustre/llite: Get rid of se_stat_t typedef green
2016-02-25 3:00 ` [PATCH v2 24/84] staging/lustre: Remove lustre_build_version.h green
2016-02-25 3:00 ` [PATCH v2 25/84] staging/lustre: Get rid of C99 comments in lustre_idl.h green
2016-02-25 3:00 ` [PATCH v2 26/84] staging/lustre: Remove server-side changelog defines green
2016-02-25 3:00 ` [PATCH v2 27/84] staging/lustre: Remove FSF mailing address from GPL notices green
2016-02-25 3:00 ` [PATCH v2 28/84] staging/lustre: Remove server-only values from enum lu_dirent_attrs green
2016-02-25 3:00 ` [PATCH v2 29/84] staging/lustre: Remove *_CONNECT_SUPPORTED defines green
2016-02-25 3:00 ` [PATCH v2 30/84] staging/lustre: Remove duplicated quota defines green
2016-02-25 3:00 ` [PATCH v2 31/84] staging/lustre: Remove unused struct quota_body green
2016-02-25 3:00 ` [PATCH v2 32/84] staging/lustre: Remove lquota_glb_rec, lquota_slv_rec and lquota_acct_rec green
2016-02-25 3:00 ` [PATCH v2 33/84] staging/lustre: S_DIRSYNC is always defined in kernel green
2016-02-25 3:00 ` [PATCH v2 34/84] staging/lustre: FMODE_READ and FMODE_WRITE are always defined in the kernel green
2016-02-25 3:00 ` [PATCH v2 35/84] staging/lustre: Remove index file transfer structures green
2016-02-25 3:00 ` [PATCH v2 36/84] staging/lustre: Remove server data from struct obd_export green
2016-02-25 3:00 ` [PATCH v2 37/84] staging/lustre: Remove last_rcvd-file related data green
2016-02-25 3:00 ` [PATCH v2 38/84] staging/lustre: Remove dead code in ldlm_lock_destroy_internal green
2016-02-25 3:00 ` [PATCH v2 39/84] staging/lustre: MAY_NOT_BLOCK is always defined, don't check for it green
2016-02-25 3:00 ` [PATCH v2 40/84] staging/lustre: Remove unused lli_open_count from struct ll_inode_info green
2016-02-25 3:00 ` [PATCH v2 41/84] staging/lustre: Reformat comments and structures in lustre_idl.h green
2016-02-25 3:00 ` [PATCH v2 42/84] staging/lustre/include: Adjust comment style green
2016-02-25 3:00 ` [PATCH v2 43/84] staging/lustre/fld: Adjust comments to better conform to coding style green
2016-02-25 3:00 ` [PATCH v2 44/84] staging/lustre/fid: " green
2016-02-25 3:00 ` green [this message]
2016-02-25 3:00 ` [PATCH v2 46/84] staging/lustre/ldlm: " green
2016-02-25 3:00 ` [PATCH v2 47/84] staging/lustre/llite: " green
2016-02-25 3:00 ` [PATCH v2 48/84] staging/lustre/lmv: " green
2016-02-25 3:00 ` [PATCH v2 49/84] staging/lustre/lov: " green
2016-02-25 3:00 ` [PATCH v2 50/84] staging/lustre/mdc: " green
2016-02-25 3:00 ` [PATCH v2 51/84] staging/lustre/mgc: " green
2016-02-25 3:00 ` [PATCH v2 52/84] staging/lustre/obdclass: " green
2016-02-25 3:00 ` [PATCH v2 53/84] staging/lustre/obdecho: " green
2016-02-25 3:00 ` [PATCH v2 54/84] staging/lustre/osc: " green
2016-02-25 3:00 ` [PATCH v2 55/84] staging/lustre/ptlrpc: " green
2016-02-25 3:00 ` [PATCH v2 56/84] staging/lustre: Fix indentation mistakes green
2016-02-25 3:00 ` [PATCH v2 57/84] staging/lustre: Remove stray space before newline in messages green
2016-02-25 3:00 ` [PATCH v2 58/84] staging/lustre: Remove commented out obd functions green
2016-02-25 3:00 ` [PATCH v2 59/84] staging/lustre: Remove unused members of struct ll_sb_info green
2016-02-25 3:00 ` [PATCH v2 60/84] staging/lustre/llite: Fix style vs open parenthesis alignment green
2016-02-26 6:10 ` Greg Kroah-Hartman
2016-02-26 6:13 ` Oleg Drokin
2016-02-25 3:00 ` [PATCH v2 61/84] staging/lustre/include: Fix style of function declarations green
2016-02-25 3:00 ` [PATCH v2 62/84] staging/lustre/fld: Fix style vs open parenthesis alignment green
2016-02-25 3:00 ` [PATCH v2 63/84] staging/lustre: Remove unused liblustre_check_services prototype green
2016-02-25 3:00 ` [PATCH v2 64/84] staging/lustre: Remove unused lustre_build_lock_params() green
2016-02-25 3:00 ` [PATCH v2 65/84] staging/lustre: Convert ptlrpc_at_check_timed to void green
2016-02-25 3:00 ` [PATCH v2 66/84] staging/lustre: Remove misleading liblustre comments green
2016-02-25 3:00 ` [PATCH v2 67/84] staging/lustre: Remove liblustre references from explanations green
2016-02-25 3:00 ` [PATCH v2 68/84] staging/lustre/lmv: Remove commented out MDS selection policies green
2016-02-25 3:00 ` [PATCH v2 69/84] staging/lustre: F_SETLKW64 F_SETLK64 F_GETLK64 are always defined green
2016-02-25 3:00 ` [PATCH v2 70/84] staging/lustre: MS_POSIXACL is always defined, don't check for it green
2016-02-25 3:00 ` [PATCH v2 71/84] staging/lustre: Remove RELEASEPAGE_ARG_TYPE compat macro green
2016-02-25 3:00 ` [PATCH v2 72/84] staging/lustre: NEED_QUOTA_DEFS is never defined, drop it green
2016-02-25 3:00 ` [PATCH v2 73/84] staging/lustre/ptlrpc: Fix style vs open parenthesis alignment green
2016-02-25 3:00 ` [PATCH v2 74/84] staging/lustre/osc: " green
2016-02-25 3:00 ` [PATCH v2 75/84] staging/lustre/obdclass: " green
2016-02-25 3:00 ` [PATCH v2 76/84] staging/lustre/lov: " green
2016-02-25 3:01 ` [PATCH v2 77/84] staging/lustre/mdc: " green
2016-02-25 3:01 ` [PATCH v2 78/84] staging/lustre/mgc: " green
2016-02-25 3:01 ` [PATCH v2 79/84] staging/lustre/obdecho: " green
2016-02-25 3:01 ` [PATCH v2 80/84] staging/lustre/lmv: " green
2016-02-25 3:01 ` [PATCH v2 81/84] staging/lustre: Fix lines that start with spaces green
2016-02-25 3:01 ` [PATCH v2 82/84] staging/lustre: Rework MAX_DIO_SIZE macro green
2016-02-25 3:01 ` [PATCH v2 83/84] staging/lustre: Remove unneeded {} in lprocfs_stats_unlock() green
2016-02-25 3:01 ` [PATCH v2 84/84] staging/lustre/ptlrpc: Fix ENABLE_PINGER ifdef green
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456369267-904461-46-git-send-email-green@linuxhacker.ru \
--to=green@linuxhacker.ru \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome