mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Laxman Dewangan <ldewangan@nvidia.com>
To: <linus.walleij@linaro.org>, <robh+dt@kernel.org>,
	<pawel.moll@arm.com>, <mark.rutland@arm.com>,
	<mpa@pengutronix.de>, <swarren@wwwdotorg.org>,
	<treding@nvidia.com>
Cc: <bparrot@ti.com>, <acourbot@nvidia.com>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Laxman Dewangan <ldewangan@nvidia.com>
Subject: [PATCH V2 2/5] gpio: gpiolib: Print error number if gpio hog failed
Date: Fri, 11 Mar 2016 19:13:21 +0530	[thread overview]
Message-ID: <1457703804-3016-3-git-send-email-ldewangan@nvidia.com> (raw)
In-Reply-To: <1457703804-3016-1-git-send-email-ldewangan@nvidia.com>

Print the error number of GPIO hog failed during its configurations.
This helps in identifying the failure without instrumenting the code.

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>

---
Changes from V1:
- Keep originality of error message, just add the error number.
- It makes line to be >80 for string and understood that it is
  fine for string on some cases.
---
 drivers/gpio/gpiolib.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 1741ef4..b682d73 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -2680,15 +2680,16 @@ int gpiod_hog(struct gpio_desc *desc, const char *name,
 
 	local_desc = gpiochip_request_own_desc(chip, hwnum, name);
 	if (IS_ERR(local_desc)) {
-		pr_err("requesting hog GPIO %s (chip %s, offset %d) failed\n",
-		       name, chip->label, hwnum);
-		return PTR_ERR(local_desc);
+		status = PTR_ERR(local_desc);
+		pr_err("requesting hog GPIO %s (chip %s, offset %d) failed, %d\n",
+		       name, chip->label, hwnum, status);
+		return status;
 	}
 
 	status = gpiod_configure_flags(desc, name, dflags);
 	if (status < 0) {
-		pr_err("setup of hog GPIO %s (chip %s, offset %d) failed\n",
-		       name, chip->label, hwnum);
+		pr_err("setup of hog GPIO %s (chip %s, offset %d) failed, %d\n",
+		       name, chip->label, hwnum, status);
 		gpiochip_free_own_desc(desc);
 		return status;
 	}
-- 
2.1.4

  parent reply	other threads:[~2016-03-11 13:58 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-11 13:43 [PATCH V2 0/5] gpio: of: Add error handling and support for multiple gpio in gpio-hog Laxman Dewangan
2016-03-11 13:43 ` [PATCH V2 1/5] gpio: of: Scan available child node for gpio-hog Laxman Dewangan
2016-03-15 14:09   ` Linus Walleij
2016-03-11 13:43 ` Laxman Dewangan [this message]
2016-03-15 14:11   ` [PATCH V2 2/5] gpio: gpiolib: Print error number if gpio hog failed Linus Walleij
2016-03-11 13:43 ` [PATCH V2 3/5] gpio: of: Return error if gpio hog configuration failed Laxman Dewangan
2016-03-15 14:12   ` Linus Walleij
2016-03-16 11:10     ` Laxman Dewangan
2016-04-13 12:43   ` Linus Walleij
2016-04-13 12:54     ` Laxman Dewangan
2016-04-14 12:52       ` Linus Walleij
2016-03-11 13:43 ` [PATCH V2 4/5] gpio: DT: Rephrase "gpios" of hog node to support multiple gpios Laxman Dewangan
2016-03-14 16:31   ` Stephen Warren
2016-03-15  6:37     ` Laxman Dewangan
2016-03-15 15:40       ` Stephen Warren
2016-03-15 14:16   ` Linus Walleij
2016-03-11 13:43 ` [PATCH V2 5/5] gpio: of: Add support to have multiple gpios in gpio-hog Laxman Dewangan
2016-03-15 14:21   ` Linus Walleij
2016-03-16 11:18     ` Laxman Dewangan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1457703804-3016-3-git-send-email-ldewangan@nvidia.com \
    --to=ldewangan@nvidia.com \
    --cc=acourbot@nvidia.com \
    --cc=bparrot@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mpa@pengutronix.de \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=swarren@wwwdotorg.org \
    --cc=treding@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®