From: Laxman Dewangan <ldewangan@nvidia.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "Rob Herring" <robh+dt@kernel.org>,
"Paweł Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Markus Pargmann" <mpa@pengutronix.de>,
"Stephen Warren" <swarren@wwwdotorg.org>,
"Thierry Reding" <treding@nvidia.com>,
"Benoit Parrot" <bparrot@ti.com>,
"Alexandre Courbot" <acourbot@nvidia.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 3/5] gpio: of: Return error if gpio hog configuration failed
Date: Wed, 16 Mar 2016 16:40:34 +0530 [thread overview]
Message-ID: <56E93F2A.60303@nvidia.com> (raw)
In-Reply-To: <CACRpkdbsu+yfFvCR2=vKO3+S46+GHSy+3wu+5uwMmsu0_mfP-Q@mail.gmail.com>
On Tuesday 15 March 2016 07:42 PM, Linus Walleij wrote:
> On Fri, Mar 11, 2016 at 2:43 PM, Laxman Dewangan <ldewangan@nvidia.com> wrote:
>
>> If GPIO hog configuration failed while adding OF based
>> gpiochip() then return the error instead of ignoring it.
>>
>> This helps of properly handling the gpio driver dependency.
>>
>> When adding the gpio hog nodes for NVIDIA's Tegra210 platforms,
>> the gpio_hogd() fails with EPROBE_DEFER because pinctrl is not
>> ready at this time and gpio_request() for Tegra GPIO driver
>> returns error. The error was not causing the Tegra GPIO driver
>> to fail as the error was getting ignored.
>>
>> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
>> Cc: Benoit Parrot <bparrot@ti.com>
>> Cc: Alexandre Courbot <acourbot@nvidia.com>
>> Reviewed-by: Thierry Reding <treding@nvidia.com>
> Oops is this something I should apply for fixes and tag
> for stable?
>
I dont think that it is needed for stable as this is newly added feature.
next prev parent reply other threads:[~2016-03-16 11:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 13:43 [PATCH V2 0/5] gpio: of: Add error handling and support for multiple gpio in gpio-hog Laxman Dewangan
2016-03-11 13:43 ` [PATCH V2 1/5] gpio: of: Scan available child node for gpio-hog Laxman Dewangan
2016-03-15 14:09 ` Linus Walleij
2016-03-11 13:43 ` [PATCH V2 2/5] gpio: gpiolib: Print error number if gpio hog failed Laxman Dewangan
2016-03-15 14:11 ` Linus Walleij
2016-03-11 13:43 ` [PATCH V2 3/5] gpio: of: Return error if gpio hog configuration failed Laxman Dewangan
2016-03-15 14:12 ` Linus Walleij
2016-03-16 11:10 ` Laxman Dewangan [this message]
2016-04-13 12:43 ` Linus Walleij
2016-04-13 12:54 ` Laxman Dewangan
2016-04-14 12:52 ` Linus Walleij
2016-03-11 13:43 ` [PATCH V2 4/5] gpio: DT: Rephrase "gpios" of hog node to support multiple gpios Laxman Dewangan
2016-03-14 16:31 ` Stephen Warren
2016-03-15 6:37 ` Laxman Dewangan
2016-03-15 15:40 ` Stephen Warren
2016-03-15 14:16 ` Linus Walleij
2016-03-11 13:43 ` [PATCH V2 5/5] gpio: of: Add support to have multiple gpios in gpio-hog Laxman Dewangan
2016-03-15 14:21 ` Linus Walleij
2016-03-16 11:18 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E93F2A.60303@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=acourbot@nvidia.com \
--cc=bparrot@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mpa@pengutronix.de \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome