[PATCH] drivers: staging: unisys: visornic: Fixed block comment coding style warnings

[PATCH] drivers: staging: unisys: visornic: Fixed block comment coding style warnings

[Gavin O'Leary]

Fixed block comment checkpatch warnings.

Signed-off-by: Gavin O'Leary <gavinoleary3@gmail.com>
---
 drivers/staging/unisys/visornic/visornic_main.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/unisys/visornic/visornic_main.c b/drivers/staging/unisys/visornic/visornic_main.c
index 0519470..eefbacc 100644
--- a/drivers/staging/unisys/visornic/visornic_main.c
+++ b/drivers/staging/unisys/visornic/visornic_main.c
@@ -1315,12 +1315,14 @@ visornic_rx(struct uiscmdrsp *cmdrsp)
 				}
 				if (found_mc)
 					break;	/* accept packet, dest
-						   matches a multicast
-						   address */
+						 * matches a multicast
+						 * address
+						 */
 			}
 		} else if (skb->pkt_type == PACKET_HOST) {
 			break;	/* accept packet, h_dest must match vnic
-				   mac address */
+				 * mac address
+				 */
 		} else if (skb->pkt_type == PACKET_OTHERHOST) {
 			/* something is not right */
 			dev_err(&devdata->netdev->dev,
@@ -1618,8 +1620,7 @@ service_resp_queue(struct uiscmdrsp *cmdrsp, struct visornic_devdata *devdata,
 	unsigned long flags;
 	struct net_device *netdev;
 
-	/* TODO: CLIENT ACQUIRE -- Don't really need this at the
-	 * moment */
+	/* TODO: CLIENT ACQUIRE -- Don't really need this at the moment */
 	for (;;) {
 		if (!visorchannel_signalremove(devdata->dev->visorchannel,
 					       IOCHAN_FROM_IOPART,
-- 
1.9.1

Re: [PATCH] drivers: staging: unisys: visornic: Fixed block comment coding style warnings

[Greg KH]

On Wed, Mar 16, 2016 at 07:01:51PM -0700, Gavin O'Leary wrote:
> Fixed block comment checkpatch warnings.
> 
> Signed-off-by: Gavin O'Leary <gavinoleary3@gmail.com>
> ---
>  drivers/staging/unisys/visornic/visornic_main.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/unisys/visornic/visornic_main.c b/drivers/staging/unisys/visornic/visornic_main.c
> index 0519470..eefbacc 100644
> --- a/drivers/staging/unisys/visornic/visornic_main.c
> +++ b/drivers/staging/unisys/visornic/visornic_main.c
> @@ -1315,12 +1315,14 @@ visornic_rx(struct uiscmdrsp *cmdrsp)
>  				}
>  				if (found_mc)
>  					break;	/* accept packet, dest
> -						   matches a multicast
> -						   address */
> +						 * matches a multicast
> +						 * address
> +						 */

That looks horrible, don't you think?

>  			}
>  		} else if (skb->pkt_type == PACKET_HOST) {
>  			break;	/* accept packet, h_dest must match vnic
> -				   mac address */
> +				 * mac address
> +				 */

Same here.

Please fix up to look better, that's your goal, right?

thanks,

greg k-h