From: Andrew Goodbody <andrew.goodbody@cambrionix.com>
To: <b-liu@ti.com>
Cc: <gregkh@linuxfoundation.org>, <linux-usb@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Andrew Goodbody <andrew.goodbody@cambrionix.com>
Subject: [PATCH 0/2] usb: musb: fix dropped packets
Date: Fri, 20 May 2016 15:51:40 +0100 [thread overview]
Message-ID: <1463755902-12922-1-git-send-email-andrew.goodbody@cambrionix.com> (raw)
The musb driver can drop rx packets when heavily loaded. These two
patches address two issues that can cause this. Both issues arose
when an endpoint was reprogrammed. The first patch is a logic bug
that resulted in a shared_fifo in rx mode not having its state
cleared out. The second patch fixes a race condition caused by
not stopping the dedicated endpoint for bulk packets before
rotating its queue which allowed a packet to be recieved and then
thrown away.
Andrew Goodbody (2):
usb: musb: Ensure rx reinit occurs for shared_fifo endpoints
usb: musb: Stop bulk endpoint while queue is rotated
drivers/usb/musb/musb_host.c | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)
--
2.7.4
next reply other threads:[~2016-05-20 14:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 14:51 Andrew Goodbody [this message]
2016-05-20 14:51 ` [PATCH 1/2] usb: musb: Ensure rx reinit occurs for shared_fifo endpoints Andrew Goodbody
2016-05-20 15:26 ` Sergei Shtylyov
2016-05-20 17:01 ` Andrew Goodbody
2016-05-20 14:51 ` [PATCH 2/2] usb: musb: Stop bulk endpoint while queue is rotated Andrew Goodbody
2016-05-20 16:21 ` Sergei Shtylyov
2016-05-20 17:06 ` Andrew Goodbody
2016-05-20 17:14 ` Sergei Shtylyov
2016-05-20 17:24 ` Andrew Goodbody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463755902-12922-1-git-send-email-andrew.goodbody@cambrionix.com \
--to=andrew.goodbody@cambrionix.com \
--cc=b-liu@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®