From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Andrew Goodbody <andrew.goodbody@cambrionix.com>, b-liu@ti.com
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 2/2] usb: musb: Stop bulk endpoint while queue is rotated
Date: Fri, 20 May 2016 19:21:12 +0300 [thread overview]
Message-ID: <b1fd7c79-b5c1-f8c0-9620-bb353b0405bc@cogentembedded.com> (raw)
In-Reply-To: <1463755902-12922-3-git-send-email-andrew.goodbody@cambrionix.com>
On 05/20/2016 05:51 PM, Andrew Goodbody wrote:
> Ensure that the endpoint is stopped by clearing REQPKT before
> clearing DATAERR_NAKTIMEOUT before rotating the queue on the
> dedicated bulk endpoint.
> This addresses an issue where a race could result in the endpoint
> receiving data before it was reprogrammed resulting in a warning
> about such data from musb_rx_reinit before it was thrown away.
> The data thrown away was a valid packet that had been correctly
> ACKed which meant the host and device got out of sync.
>
> Signed-off-by: Andrew Goodbody <andrew.goodbody@cambrionix.com>
> Cc: stable@vger.kernel.org
> ---
> drivers/usb/musb/musb_host.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
> index 30e0d65..777ff30 100644
> --- a/drivers/usb/musb/musb_host.c
> +++ b/drivers/usb/musb/musb_host.c
> @@ -999,6 +999,8 @@ static void musb_bulk_nak_timeout(struct musb *musb, struct musb_hw_ep *ep,
> /* clear nak timeout bit */
> rx_csr = musb_readw(epio, MUSB_RXCSR);
> rx_csr |= MUSB_RXCSR_H_WZC_BITS;
> + rx_csr &= ~MUSB_RXCSR_H_REQPKT;
> + musb_writew(epio, MUSB_RXCSR, rx_csr);
> rx_csr &= ~MUSB_RXCSR_DATAERROR;
> musb_writew(epio, MUSB_RXCSR, rx_csr);
Can we not clear both in one write?
[...]
MBR, Sergei
next prev parent reply other threads:[~2016-05-20 16:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 14:51 [PATCH 0/2] usb: musb: fix dropped packets Andrew Goodbody
2016-05-20 14:51 ` [PATCH 1/2] usb: musb: Ensure rx reinit occurs for shared_fifo endpoints Andrew Goodbody
2016-05-20 15:26 ` Sergei Shtylyov
2016-05-20 17:01 ` Andrew Goodbody
2016-05-20 14:51 ` [PATCH 2/2] usb: musb: Stop bulk endpoint while queue is rotated Andrew Goodbody
2016-05-20 16:21 ` Sergei Shtylyov [this message]
2016-05-20 17:06 ` Andrew Goodbody
2016-05-20 17:14 ` Sergei Shtylyov
2016-05-20 17:24 ` Andrew Goodbody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1fd7c79-b5c1-f8c0-9620-bb353b0405bc@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=andrew.goodbody@cambrionix.com \
--cc=b-liu@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®