mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 1/2] net: ethernet: nb8800: use phydev from struct net_device
@ 2016-06-18 21:16 Philippe Reynes
  2016-06-18 21:16 ` [PATCH 2/2] net: ethernet: nb8800: use phy_ethtool_{get|set}_link_ksettings Philippe Reynes
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Philippe Reynes @ 2016-06-18 21:16 UTC (permalink / raw)
  To: mans, davem, sf84, arnd; +Cc: netdev, linux-kernel, Philippe Reynes

The private structure contain a pointer to phydev, but the structure
net_device already contain such pointer. So we can remove the pointer
phydev in the private structure, and update the driver to use the
one contained in struct net_device.

Signed-off-by: Philippe Reynes <tremyfr@gmail.com>
---
 drivers/net/ethernet/aurora/nb8800.c |   57 +++++++++++++++++----------------
 drivers/net/ethernet/aurora/nb8800.h |    1 -
 2 files changed, 29 insertions(+), 29 deletions(-)

diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/nb8800.c
index 08a23e6..4989d31 100644
--- a/drivers/net/ethernet/aurora/nb8800.c
+++ b/drivers/net/ethernet/aurora/nb8800.c
@@ -631,7 +631,7 @@ static void nb8800_mac_config(struct net_device *dev)
 static void nb8800_pause_config(struct net_device *dev)
 {
 	struct nb8800_priv *priv = netdev_priv(dev);
-	struct phy_device *phydev = priv->phydev;
+	struct phy_device *phydev = dev->phydev;
 	u32 rxcr;
 
 	if (priv->pause_aneg) {
@@ -664,7 +664,7 @@ static void nb8800_pause_config(struct net_device *dev)
 static void nb8800_link_reconfigure(struct net_device *dev)
 {
 	struct nb8800_priv *priv = netdev_priv(dev);
-	struct phy_device *phydev = priv->phydev;
+	struct phy_device *phydev = dev->phydev;
 	int change = 0;
 
 	if (phydev->link) {
@@ -690,7 +690,7 @@ static void nb8800_link_reconfigure(struct net_device *dev)
 	}
 
 	if (change)
-		phy_print_status(priv->phydev);
+		phy_print_status(phydev);
 }
 
 static void nb8800_update_mac_addr(struct net_device *dev)
@@ -935,9 +935,10 @@ static int nb8800_dma_stop(struct net_device *dev)
 static void nb8800_pause_adv(struct net_device *dev)
 {
 	struct nb8800_priv *priv = netdev_priv(dev);
+	struct phy_device *phydev = dev->phydev;
 	u32 adv = 0;
 
-	if (!priv->phydev)
+	if (!phydev)
 		return;
 
 	if (priv->pause_rx)
@@ -945,13 +946,14 @@ static void nb8800_pause_adv(struct net_device *dev)
 	if (priv->pause_tx)
 		adv ^= ADVERTISED_Asym_Pause;
 
-	priv->phydev->supported |= adv;
-	priv->phydev->advertising |= adv;
+	phydev->supported |= adv;
+	phydev->advertising |= adv;
 }
 
 static int nb8800_open(struct net_device *dev)
 {
 	struct nb8800_priv *priv = netdev_priv(dev);
+	struct phy_device *phydev;
 	int err;
 
 	/* clear any pending interrupts */
@@ -969,10 +971,10 @@ static int nb8800_open(struct net_device *dev)
 	nb8800_mac_rx(dev, true);
 	nb8800_mac_tx(dev, true);
 
-	priv->phydev = of_phy_connect(dev, priv->phy_node,
-				      nb8800_link_reconfigure, 0,
-				      priv->phy_mode);
-	if (!priv->phydev)
+	phydev = of_phy_connect(dev, priv->phy_node,
+				nb8800_link_reconfigure, 0,
+				priv->phy_mode);
+	if (!phydev)
 		goto err_free_irq;
 
 	nb8800_pause_adv(dev);
@@ -982,7 +984,7 @@ static int nb8800_open(struct net_device *dev)
 	netif_start_queue(dev);
 
 	nb8800_start_rx(dev);
-	phy_start(priv->phydev);
+	phy_start(phydev);
 
 	return 0;
 
@@ -997,8 +999,9 @@ err_free_dma:
 static int nb8800_stop(struct net_device *dev)
 {
 	struct nb8800_priv *priv = netdev_priv(dev);
+	struct phy_device *phydev = dev->phydev;
 
-	phy_stop(priv->phydev);
+	phy_stop(phydev);
 
 	netif_stop_queue(dev);
 	napi_disable(&priv->napi);
@@ -1007,8 +1010,7 @@ static int nb8800_stop(struct net_device *dev)
 	nb8800_mac_rx(dev, false);
 	nb8800_mac_tx(dev, false);
 
-	phy_disconnect(priv->phydev);
-	priv->phydev = NULL;
+	phy_disconnect(phydev);
 
 	free_irq(dev->irq, dev);
 
@@ -1019,9 +1021,7 @@ static int nb8800_stop(struct net_device *dev)
 
 static int nb8800_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
 {
-	struct nb8800_priv *priv = netdev_priv(dev);
-
-	return phy_mii_ioctl(priv->phydev, rq, cmd);
+	return phy_mii_ioctl(dev->phydev, rq, cmd);
 }
 
 static const struct net_device_ops nb8800_netdev_ops = {
@@ -1037,32 +1037,32 @@ static const struct net_device_ops nb8800_netdev_ops = {
 
 static int nb8800_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
 {
-	struct nb8800_priv *priv = netdev_priv(dev);
+	struct phy_device *phydev = dev->phydev;
 
-	if (!priv->phydev)
+	if (!phydev)
 		return -ENODEV;
 
-	return phy_ethtool_gset(priv->phydev, cmd);
+	return phy_ethtool_gset(phydev, cmd);
 }
 
 static int nb8800_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
 {
-	struct nb8800_priv *priv = netdev_priv(dev);
+	struct phy_device *phydev = dev->phydev;
 
-	if (!priv->phydev)
+	if (!phydev)
 		return -ENODEV;
 
-	return phy_ethtool_sset(priv->phydev, cmd);
+	return phy_ethtool_sset(phydev, cmd);
 }
 
 static int nb8800_nway_reset(struct net_device *dev)
 {
-	struct nb8800_priv *priv = netdev_priv(dev);
+	struct phy_device *phydev = dev->phydev;
 
-	if (!priv->phydev)
+	if (!phydev)
 		return -ENODEV;
 
-	return genphy_restart_aneg(priv->phydev);
+	return genphy_restart_aneg(phydev);
 }
 
 static void nb8800_get_pauseparam(struct net_device *dev,
@@ -1079,6 +1079,7 @@ static int nb8800_set_pauseparam(struct net_device *dev,
 				 struct ethtool_pauseparam *pp)
 {
 	struct nb8800_priv *priv = netdev_priv(dev);
+	struct phy_device *phydev = dev->phydev;
 
 	priv->pause_aneg = pp->autoneg;
 	priv->pause_rx = pp->rx_pause;
@@ -1088,8 +1089,8 @@ static int nb8800_set_pauseparam(struct net_device *dev,
 
 	if (!priv->pause_aneg)
 		nb8800_pause_config(dev);
-	else if (priv->phydev)
-		phy_start_aneg(priv->phydev);
+	else if (phydev)
+		phy_start_aneg(phydev);
 
 	return 0;
 }
diff --git a/drivers/net/ethernet/aurora/nb8800.h b/drivers/net/ethernet/aurora/nb8800.h
index e5adbc2..6ec4a95 100644
--- a/drivers/net/ethernet/aurora/nb8800.h
+++ b/drivers/net/ethernet/aurora/nb8800.h
@@ -284,7 +284,6 @@ struct nb8800_priv {
 
 	struct mii_bus			*mii_bus;
 	struct device_node		*phy_node;
-	struct phy_device		*phydev;
 
 	/* PHY connection type from DT */
 	int				phy_mode;
-- 
1.7.4.4

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 2/2] net: ethernet: nb8800: use phy_ethtool_{get|set}_link_ksettings
  2016-06-18 21:16 [PATCH 1/2] net: ethernet: nb8800: use phydev from struct net_device Philippe Reynes
@ 2016-06-18 21:16 ` Philippe Reynes
  2016-06-19 11:32   ` Måns Rullgård
  2016-06-19 17:55   ` David Miller
  2016-06-19 11:31 ` [PATCH 1/2] net: ethernet: nb8800: use phydev from struct net_device Måns Rullgård
  2016-06-19 17:55 ` David Miller
  2 siblings, 2 replies; 6+ messages in thread
From: Philippe Reynes @ 2016-06-18 21:16 UTC (permalink / raw)
  To: mans, davem, sf84, arnd; +Cc: netdev, linux-kernel, Philippe Reynes

There are two generics functions phy_ethtool_{get|set}_link_ksettings,
so we can use them instead of defining the same code in the driver.

Signed-off-by: Philippe Reynes <tremyfr@gmail.com>
---
 drivers/net/ethernet/aurora/nb8800.c |   24 ++----------------------
 1 files changed, 2 insertions(+), 22 deletions(-)

diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/nb8800.c
index 4989d31..dc2c35d 100644
--- a/drivers/net/ethernet/aurora/nb8800.c
+++ b/drivers/net/ethernet/aurora/nb8800.c
@@ -1035,26 +1035,6 @@ static const struct net_device_ops nb8800_netdev_ops = {
 	.ndo_validate_addr	= eth_validate_addr,
 };
 
-static int nb8800_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
-{
-	struct phy_device *phydev = dev->phydev;
-
-	if (!phydev)
-		return -ENODEV;
-
-	return phy_ethtool_gset(phydev, cmd);
-}
-
-static int nb8800_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
-{
-	struct phy_device *phydev = dev->phydev;
-
-	if (!phydev)
-		return -ENODEV;
-
-	return phy_ethtool_sset(phydev, cmd);
-}
-
 static int nb8800_nway_reset(struct net_device *dev)
 {
 	struct phy_device *phydev = dev->phydev;
@@ -1183,8 +1163,6 @@ static void nb8800_get_ethtool_stats(struct net_device *dev,
 }
 
 static const struct ethtool_ops nb8800_ethtool_ops = {
-	.get_settings		= nb8800_get_settings,
-	.set_settings		= nb8800_set_settings,
 	.nway_reset		= nb8800_nway_reset,
 	.get_link		= ethtool_op_get_link,
 	.get_pauseparam		= nb8800_get_pauseparam,
@@ -1192,6 +1170,8 @@ static const struct ethtool_ops nb8800_ethtool_ops = {
 	.get_sset_count		= nb8800_get_sset_count,
 	.get_strings		= nb8800_get_strings,
 	.get_ethtool_stats	= nb8800_get_ethtool_stats,
+	.get_link_ksettings	= phy_ethtool_get_link_ksettings,
+	.set_link_ksettings	= phy_ethtool_set_link_ksettings,
 };
 
 static int nb8800_hw_init(struct net_device *dev)
-- 
1.7.4.4

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] net: ethernet: nb8800: use phydev from struct net_device
  2016-06-18 21:16 [PATCH 1/2] net: ethernet: nb8800: use phydev from struct net_device Philippe Reynes
  2016-06-18 21:16 ` [PATCH 2/2] net: ethernet: nb8800: use phy_ethtool_{get|set}_link_ksettings Philippe Reynes
@ 2016-06-19 11:31 ` Måns Rullgård
  2016-06-19 17:55 ` David Miller
  2 siblings, 0 replies; 6+ messages in thread
From: Måns Rullgård @ 2016-06-19 11:31 UTC (permalink / raw)
  To: Philippe Reynes; +Cc: davem, sf84, arnd, netdev, linux-kernel

Philippe Reynes <tremyfr@gmail.com> writes:

> The private structure contain a pointer to phydev, but the structure
> net_device already contain such pointer. So we can remove the pointer
> phydev in the private structure, and update the driver to use the
> one contained in struct net_device.
>
> Signed-off-by: Philippe Reynes <tremyfr@gmail.com>

Acked-by: Mans Rullgard <mans@mansr.com>

> ---
>  drivers/net/ethernet/aurora/nb8800.c |   57 +++++++++++++++++----------------
>  drivers/net/ethernet/aurora/nb8800.h |    1 -
>  2 files changed, 29 insertions(+), 29 deletions(-)
>
> diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/nb8800.c
> index 08a23e6..4989d31 100644
> --- a/drivers/net/ethernet/aurora/nb8800.c
> +++ b/drivers/net/ethernet/aurora/nb8800.c
> @@ -631,7 +631,7 @@ static void nb8800_mac_config(struct net_device *dev)
>  static void nb8800_pause_config(struct net_device *dev)
>  {
>  	struct nb8800_priv *priv = netdev_priv(dev);
> -	struct phy_device *phydev = priv->phydev;
> +	struct phy_device *phydev = dev->phydev;
>  	u32 rxcr;
>
>  	if (priv->pause_aneg) {
> @@ -664,7 +664,7 @@ static void nb8800_pause_config(struct net_device *dev)
>  static void nb8800_link_reconfigure(struct net_device *dev)
>  {
>  	struct nb8800_priv *priv = netdev_priv(dev);
> -	struct phy_device *phydev = priv->phydev;
> +	struct phy_device *phydev = dev->phydev;
>  	int change = 0;
>
>  	if (phydev->link) {
> @@ -690,7 +690,7 @@ static void nb8800_link_reconfigure(struct net_device *dev)
>  	}
>
>  	if (change)
> -		phy_print_status(priv->phydev);
> +		phy_print_status(phydev);
>  }
>
>  static void nb8800_update_mac_addr(struct net_device *dev)
> @@ -935,9 +935,10 @@ static int nb8800_dma_stop(struct net_device *dev)
>  static void nb8800_pause_adv(struct net_device *dev)
>  {
>  	struct nb8800_priv *priv = netdev_priv(dev);
> +	struct phy_device *phydev = dev->phydev;
>  	u32 adv = 0;
>
> -	if (!priv->phydev)
> +	if (!phydev)
>  		return;
>
>  	if (priv->pause_rx)
> @@ -945,13 +946,14 @@ static void nb8800_pause_adv(struct net_device *dev)
>  	if (priv->pause_tx)
>  		adv ^= ADVERTISED_Asym_Pause;
>
> -	priv->phydev->supported |= adv;
> -	priv->phydev->advertising |= adv;
> +	phydev->supported |= adv;
> +	phydev->advertising |= adv;
>  }
>
>  static int nb8800_open(struct net_device *dev)
>  {
>  	struct nb8800_priv *priv = netdev_priv(dev);
> +	struct phy_device *phydev;
>  	int err;
>
>  	/* clear any pending interrupts */
> @@ -969,10 +971,10 @@ static int nb8800_open(struct net_device *dev)
>  	nb8800_mac_rx(dev, true);
>  	nb8800_mac_tx(dev, true);
>
> -	priv->phydev = of_phy_connect(dev, priv->phy_node,
> -				      nb8800_link_reconfigure, 0,
> -				      priv->phy_mode);
> -	if (!priv->phydev)
> +	phydev = of_phy_connect(dev, priv->phy_node,
> +				nb8800_link_reconfigure, 0,
> +				priv->phy_mode);
> +	if (!phydev)
>  		goto err_free_irq;
>
>  	nb8800_pause_adv(dev);
> @@ -982,7 +984,7 @@ static int nb8800_open(struct net_device *dev)
>  	netif_start_queue(dev);
>
>  	nb8800_start_rx(dev);
> -	phy_start(priv->phydev);
> +	phy_start(phydev);
>
>  	return 0;
>
> @@ -997,8 +999,9 @@ err_free_dma:
>  static int nb8800_stop(struct net_device *dev)
>  {
>  	struct nb8800_priv *priv = netdev_priv(dev);
> +	struct phy_device *phydev = dev->phydev;
>
> -	phy_stop(priv->phydev);
> +	phy_stop(phydev);
>
>  	netif_stop_queue(dev);
>  	napi_disable(&priv->napi);
> @@ -1007,8 +1010,7 @@ static int nb8800_stop(struct net_device *dev)
>  	nb8800_mac_rx(dev, false);
>  	nb8800_mac_tx(dev, false);
>
> -	phy_disconnect(priv->phydev);
> -	priv->phydev = NULL;
> +	phy_disconnect(phydev);
>
>  	free_irq(dev->irq, dev);
>
> @@ -1019,9 +1021,7 @@ static int nb8800_stop(struct net_device *dev)
>
>  static int nb8800_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
>  {
> -	struct nb8800_priv *priv = netdev_priv(dev);
> -
> -	return phy_mii_ioctl(priv->phydev, rq, cmd);
> +	return phy_mii_ioctl(dev->phydev, rq, cmd);
>  }
>
>  static const struct net_device_ops nb8800_netdev_ops = {
> @@ -1037,32 +1037,32 @@ static const struct net_device_ops nb8800_netdev_ops = {
>
>  static int nb8800_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
>  {
> -	struct nb8800_priv *priv = netdev_priv(dev);
> +	struct phy_device *phydev = dev->phydev;
>
> -	if (!priv->phydev)
> +	if (!phydev)
>  		return -ENODEV;
>
> -	return phy_ethtool_gset(priv->phydev, cmd);
> +	return phy_ethtool_gset(phydev, cmd);
>  }
>
>  static int nb8800_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
>  {
> -	struct nb8800_priv *priv = netdev_priv(dev);
> +	struct phy_device *phydev = dev->phydev;
>
> -	if (!priv->phydev)
> +	if (!phydev)
>  		return -ENODEV;
>
> -	return phy_ethtool_sset(priv->phydev, cmd);
> +	return phy_ethtool_sset(phydev, cmd);
>  }
>
>  static int nb8800_nway_reset(struct net_device *dev)
>  {
> -	struct nb8800_priv *priv = netdev_priv(dev);
> +	struct phy_device *phydev = dev->phydev;
>
> -	if (!priv->phydev)
> +	if (!phydev)
>  		return -ENODEV;
>
> -	return genphy_restart_aneg(priv->phydev);
> +	return genphy_restart_aneg(phydev);
>  }
>
>  static void nb8800_get_pauseparam(struct net_device *dev,
> @@ -1079,6 +1079,7 @@ static int nb8800_set_pauseparam(struct net_device *dev,
>  				 struct ethtool_pauseparam *pp)
>  {
>  	struct nb8800_priv *priv = netdev_priv(dev);
> +	struct phy_device *phydev = dev->phydev;
>
>  	priv->pause_aneg = pp->autoneg;
>  	priv->pause_rx = pp->rx_pause;
> @@ -1088,8 +1089,8 @@ static int nb8800_set_pauseparam(struct net_device *dev,
>
>  	if (!priv->pause_aneg)
>  		nb8800_pause_config(dev);
> -	else if (priv->phydev)
> -		phy_start_aneg(priv->phydev);
> +	else if (phydev)
> +		phy_start_aneg(phydev);
>
>  	return 0;
>  }
> diff --git a/drivers/net/ethernet/aurora/nb8800.h b/drivers/net/ethernet/aurora/nb8800.h
> index e5adbc2..6ec4a95 100644
> --- a/drivers/net/ethernet/aurora/nb8800.h
> +++ b/drivers/net/ethernet/aurora/nb8800.h
> @@ -284,7 +284,6 @@ struct nb8800_priv {
>
>  	struct mii_bus			*mii_bus;
>  	struct device_node		*phy_node;
> -	struct phy_device		*phydev;
>
>  	/* PHY connection type from DT */
>  	int				phy_mode;
> -- 
> 1.7.4.4
>

-- 
Måns Rullgård

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] net: ethernet: nb8800: use phy_ethtool_{get|set}_link_ksettings
  2016-06-18 21:16 ` [PATCH 2/2] net: ethernet: nb8800: use phy_ethtool_{get|set}_link_ksettings Philippe Reynes
@ 2016-06-19 11:32   ` Måns Rullgård
  2016-06-19 17:55   ` David Miller
  1 sibling, 0 replies; 6+ messages in thread
From: Måns Rullgård @ 2016-06-19 11:32 UTC (permalink / raw)
  To: Philippe Reynes; +Cc: davem, sf84, arnd, netdev, linux-kernel

Philippe Reynes <tremyfr@gmail.com> writes:

> There are two generics functions phy_ethtool_{get|set}_link_ksettings,
> so we can use them instead of defining the same code in the driver.
>
> Signed-off-by: Philippe Reynes <tremyfr@gmail.com>

Acked-by: Mans Rullgard <mans@mansr.com>

> ---
>  drivers/net/ethernet/aurora/nb8800.c |   24 ++----------------------
>  1 files changed, 2 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/nb8800.c
> index 4989d31..dc2c35d 100644
> --- a/drivers/net/ethernet/aurora/nb8800.c
> +++ b/drivers/net/ethernet/aurora/nb8800.c
> @@ -1035,26 +1035,6 @@ static const struct net_device_ops nb8800_netdev_ops = {
>  	.ndo_validate_addr	= eth_validate_addr,
>  };
>
> -static int nb8800_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
> -{
> -	struct phy_device *phydev = dev->phydev;
> -
> -	if (!phydev)
> -		return -ENODEV;
> -
> -	return phy_ethtool_gset(phydev, cmd);
> -}
> -
> -static int nb8800_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
> -{
> -	struct phy_device *phydev = dev->phydev;
> -
> -	if (!phydev)
> -		return -ENODEV;
> -
> -	return phy_ethtool_sset(phydev, cmd);
> -}
> -
>  static int nb8800_nway_reset(struct net_device *dev)
>  {
>  	struct phy_device *phydev = dev->phydev;
> @@ -1183,8 +1163,6 @@ static void nb8800_get_ethtool_stats(struct net_device *dev,
>  }
>
>  static const struct ethtool_ops nb8800_ethtool_ops = {
> -	.get_settings		= nb8800_get_settings,
> -	.set_settings		= nb8800_set_settings,
>  	.nway_reset		= nb8800_nway_reset,
>  	.get_link		= ethtool_op_get_link,
>  	.get_pauseparam		= nb8800_get_pauseparam,
> @@ -1192,6 +1170,8 @@ static const struct ethtool_ops nb8800_ethtool_ops = {
>  	.get_sset_count		= nb8800_get_sset_count,
>  	.get_strings		= nb8800_get_strings,
>  	.get_ethtool_stats	= nb8800_get_ethtool_stats,
> +	.get_link_ksettings	= phy_ethtool_get_link_ksettings,
> +	.set_link_ksettings	= phy_ethtool_set_link_ksettings,
>  };
>
>  static int nb8800_hw_init(struct net_device *dev)
> -- 
> 1.7.4.4
>

-- 
Måns Rullgård

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] net: ethernet: nb8800: use phydev from struct net_device
  2016-06-18 21:16 [PATCH 1/2] net: ethernet: nb8800: use phydev from struct net_device Philippe Reynes
  2016-06-18 21:16 ` [PATCH 2/2] net: ethernet: nb8800: use phy_ethtool_{get|set}_link_ksettings Philippe Reynes
  2016-06-19 11:31 ` [PATCH 1/2] net: ethernet: nb8800: use phydev from struct net_device Måns Rullgård
@ 2016-06-19 17:55 ` David Miller
  2 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2016-06-19 17:55 UTC (permalink / raw)
  To: tremyfr; +Cc: mans, sf84, arnd, netdev, linux-kernel

From: Philippe Reynes <tremyfr@gmail.com>
Date: Sat, 18 Jun 2016 23:16:54 +0200

> The private structure contain a pointer to phydev, but the structure
> net_device already contain such pointer. So we can remove the pointer
> phydev in the private structure, and update the driver to use the
> one contained in struct net_device.
> 
> Signed-off-by: Philippe Reynes <tremyfr@gmail.com>

Applied.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] net: ethernet: nb8800: use phy_ethtool_{get|set}_link_ksettings
  2016-06-18 21:16 ` [PATCH 2/2] net: ethernet: nb8800: use phy_ethtool_{get|set}_link_ksettings Philippe Reynes
  2016-06-19 11:32   ` Måns Rullgård
@ 2016-06-19 17:55   ` David Miller
  1 sibling, 0 replies; 6+ messages in thread
From: David Miller @ 2016-06-19 17:55 UTC (permalink / raw)
  To: tremyfr; +Cc: mans, sf84, arnd, netdev, linux-kernel

From: Philippe Reynes <tremyfr@gmail.com>
Date: Sat, 18 Jun 2016 23:16:55 +0200

> There are two generics functions phy_ethtool_{get|set}_link_ksettings,
> so we can use them instead of defining the same code in the driver.
> 
> Signed-off-by: Philippe Reynes <tremyfr@gmail.com>

Applied.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-06-19 17:56 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-18 21:16 [PATCH 1/2] net: ethernet: nb8800: use phydev from struct net_device Philippe Reynes
2016-06-18 21:16 ` [PATCH 2/2] net: ethernet: nb8800: use phy_ethtool_{get|set}_link_ksettings Philippe Reynes
2016-06-19 11:32   ` Måns Rullgård
2016-06-19 17:55   ` David Miller
2016-06-19 11:31 ` [PATCH 1/2] net: ethernet: nb8800: use phydev from struct net_device Måns Rullgård
2016-06-19 17:55 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome