* [PATCH] reset: return -ENOTSUPP if CONFIG_RESET_CONTROLLER is undefined
@ 2016-07-21 5:06 Masahiro Yamada
2016-07-22 12:39 ` Philipp Zabel
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2016-07-21 5:06 UTC (permalink / raw)
To: linux-kernel; +Cc: Hans de Goede, Philipp Zabel, Lee Jones, Masahiro Yamada
This has been inconsistent; some returns -EINVAL, some -ENOTSUPP.
Make it consistent in this header, in favor of -ENOTSUPP.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
include/linux/reset.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/reset.h b/include/linux/reset.h
index 5894f0f..c875b4b 100644
--- a/include/linux/reset.h
+++ b/include/linux/reset.h
@@ -71,14 +71,14 @@ static inline struct reset_control *__of_reset_control_get(
struct device_node *node,
const char *id, int index, int shared)
{
- return ERR_PTR(-EINVAL);
+ return ERR_PTR(-ENOTSUPP);
}
static inline struct reset_control *__devm_reset_control_get(
struct device *dev,
const char *id, int index, int shared)
{
- return ERR_PTR(-EINVAL);
+ return ERR_PTR(-ENOTSUPP);
}
#endif /* CONFIG_RESET_CONTROLLER */
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] reset: return -ENOTSUPP if CONFIG_RESET_CONTROLLER is undefined
2016-07-21 5:06 [PATCH] reset: return -ENOTSUPP if CONFIG_RESET_CONTROLLER is undefined Masahiro Yamada
@ 2016-07-22 12:39 ` Philipp Zabel
0 siblings, 0 replies; 2+ messages in thread
From: Philipp Zabel @ 2016-07-22 12:39 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: linux-kernel, Hans de Goede, Lee Jones
Hi Masahiro,
Am Donnerstag, den 21.07.2016, 14:06 +0900 schrieb Masahiro Yamada:
> This has been inconsistent; some returns -EINVAL, some -ENOTSUPP.
> Make it consistent in this header, in favor of -ENOTSUPP.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> include/linux/reset.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/reset.h b/include/linux/reset.h
> index 5894f0f..c875b4b 100644
> --- a/include/linux/reset.h
> +++ b/include/linux/reset.h
> @@ -71,14 +71,14 @@ static inline struct reset_control *__of_reset_control_get(
> struct device_node *node,
> const char *id, int index, int shared)
> {
> - return ERR_PTR(-EINVAL);
> + return ERR_PTR(-ENOTSUPP);
> }
>
> static inline struct reset_control *__devm_reset_control_get(
> struct device *dev,
> const char *id, int index, int shared)
> {
> - return ERR_PTR(-EINVAL);
> + return ERR_PTR(-ENOTSUPP);
> }
>
> #endif /* CONFIG_RESET_CONTROLLER */
Thanks, this has already been changed in commit 168d7c4e8bb2 ("reset:
Return -ENOTSUPP when not configured").
regards
Philipp
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-22 12:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-21 5:06 [PATCH] reset: return -ENOTSUPP if CONFIG_RESET_CONTROLLER is undefined Masahiro Yamada
2016-07-22 12:39 ` Philipp Zabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®