* [PATCH] xen: Make VPMU init message look less scary
@ 2016-08-01 11:41 Juergen Gross
2016-08-01 14:11 ` Boris Ostrovsky
2016-08-01 14:11 ` [Xen-devel] " Konrad Rzeszutek Wilk
0 siblings, 2 replies; 5+ messages in thread
From: Juergen Gross @ 2016-08-01 11:41 UTC (permalink / raw)
To: linux-kernel, xen-devel; +Cc: boris.ostrovsky, david.vrabel, Juergen Gross
The default for the Xen hypervisor is to not enable VPMU in order to
avoid security issues. In this case the Linux kernel will issue the
message "Could not initialize VPMU for cpu 0, error -95" which looks
more like an error than a normal state.
Change the message to something less scary in case the hypervisor
returns EOPNOTSUPP when trying to activate VPMU.
Signed-off-by: Juergen Gross <jgross@suse.com>
---
arch/x86/xen/pmu.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/arch/x86/xen/pmu.c b/arch/x86/xen/pmu.c
index 32bdc2c..e9d66fa 100644
--- a/arch/x86/xen/pmu.c
+++ b/arch/x86/xen/pmu.c
@@ -547,8 +547,11 @@ void xen_pmu_init(int cpu)
return;
fail:
- pr_info_once("Could not initialize VPMU for cpu %d, error %d\n",
- cpu, err);
+ if (err == -EOPNOTSUPP)
+ pr_info_once("VPMU usage disabled due to Xen settings\n");
+ else
+ pr_info_once("Could not initialize VPMU for cpu %d, error %d\n",
+ cpu, err);
free_pages((unsigned long)xenpmu_data, 0);
}
--
2.6.6
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] xen: Make VPMU init message look less scary
2016-08-01 11:41 [PATCH] xen: Make VPMU init message look less scary Juergen Gross
@ 2016-08-01 14:11 ` Boris Ostrovsky
2016-08-01 14:11 ` [Xen-devel] " Konrad Rzeszutek Wilk
1 sibling, 0 replies; 5+ messages in thread
From: Boris Ostrovsky @ 2016-08-01 14:11 UTC (permalink / raw)
To: Juergen Gross, linux-kernel, xen-devel; +Cc: david.vrabel
On 08/01/2016 07:41 AM, Juergen Gross wrote:
> The default for the Xen hypervisor is to not enable VPMU in order to
> avoid security issues. In this case the Linux kernel will issue the
> message "Could not initialize VPMU for cpu 0, error -95" which looks
> more like an error than a normal state.
>
> Change the message to something less scary in case the hypervisor
> returns EOPNOTSUPP when trying to activate VPMU.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Xen-devel] [PATCH] xen: Make VPMU init message look less scary
2016-08-01 11:41 [PATCH] xen: Make VPMU init message look less scary Juergen Gross
2016-08-01 14:11 ` Boris Ostrovsky
@ 2016-08-01 14:11 ` Konrad Rzeszutek Wilk
2016-08-01 15:48 ` Juergen Gross
1 sibling, 1 reply; 5+ messages in thread
From: Konrad Rzeszutek Wilk @ 2016-08-01 14:11 UTC (permalink / raw)
To: Juergen Gross; +Cc: linux-kernel, xen-devel, boris.ostrovsky, david.vrabel
On Mon, Aug 01, 2016 at 01:41:20PM +0200, Juergen Gross wrote:
> The default for the Xen hypervisor is to not enable VPMU in order to
> avoid security issues. In this case the Linux kernel will issue the
> message "Could not initialize VPMU for cpu 0, error -95" which looks
> more like an error than a normal state.
>
> Change the message to something less scary in case the hypervisor
> returns EOPNOTSUPP when trying to activate VPMU.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
> arch/x86/xen/pmu.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/xen/pmu.c b/arch/x86/xen/pmu.c
> index 32bdc2c..e9d66fa 100644
> --- a/arch/x86/xen/pmu.c
> +++ b/arch/x86/xen/pmu.c
> @@ -547,8 +547,11 @@ void xen_pmu_init(int cpu)
> return;
>
> fail:
> - pr_info_once("Could not initialize VPMU for cpu %d, error %d\n",
> - cpu, err);
> + if (err == -EOPNOTSUPP)
> + pr_info_once("VPMU usage disabled due to Xen settings\n");
How about 'VPMU disabled by hypevisor.'
> + else
> + pr_info_once("Could not initialize VPMU for cpu %d, error %d\n",
> + cpu, err);
> free_pages((unsigned long)xenpmu_data, 0);
> }
>
> --
> 2.6.6
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Xen-devel] [PATCH] xen: Make VPMU init message look less scary
2016-08-01 14:11 ` [Xen-devel] " Konrad Rzeszutek Wilk
@ 2016-08-01 15:48 ` Juergen Gross
2016-08-01 15:50 ` Boris Ostrovsky
0 siblings, 1 reply; 5+ messages in thread
From: Juergen Gross @ 2016-08-01 15:48 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk
Cc: linux-kernel, xen-devel, boris.ostrovsky, david.vrabel
On 01/08/16 16:11, Konrad Rzeszutek Wilk wrote:
> On Mon, Aug 01, 2016 at 01:41:20PM +0200, Juergen Gross wrote:
>> The default for the Xen hypervisor is to not enable VPMU in order to
>> avoid security issues. In this case the Linux kernel will issue the
>> message "Could not initialize VPMU for cpu 0, error -95" which looks
>> more like an error than a normal state.
>>
>> Change the message to something less scary in case the hypervisor
>> returns EOPNOTSUPP when trying to activate VPMU.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>> ---
>> arch/x86/xen/pmu.c | 7 +++++--
>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/x86/xen/pmu.c b/arch/x86/xen/pmu.c
>> index 32bdc2c..e9d66fa 100644
>> --- a/arch/x86/xen/pmu.c
>> +++ b/arch/x86/xen/pmu.c
>> @@ -547,8 +547,11 @@ void xen_pmu_init(int cpu)
>> return;
>>
>> fail:
>> - pr_info_once("Could not initialize VPMU for cpu %d, error %d\n",
>> - cpu, err);
>> + if (err == -EOPNOTSUPP)
>> + pr_info_once("VPMU usage disabled due to Xen settings\n");
>
> How about 'VPMU disabled by hypevisor.'
Hmm, why not. Boris, are you okay with this message, too?
Juergen
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Xen-devel] [PATCH] xen: Make VPMU init message look less scary
2016-08-01 15:48 ` Juergen Gross
@ 2016-08-01 15:50 ` Boris Ostrovsky
0 siblings, 0 replies; 5+ messages in thread
From: Boris Ostrovsky @ 2016-08-01 15:50 UTC (permalink / raw)
To: Juergen Gross, Konrad Rzeszutek Wilk
Cc: linux-kernel, xen-devel, david.vrabel
On 08/01/2016 11:48 AM, Juergen Gross wrote:
> On 01/08/16 16:11, Konrad Rzeszutek Wilk wrote:
>> On Mon, Aug 01, 2016 at 01:41:20PM +0200, Juergen Gross wrote:
>>> The default for the Xen hypervisor is to not enable VPMU in order to
>>> avoid security issues. In this case the Linux kernel will issue the
>>> message "Could not initialize VPMU for cpu 0, error -95" which looks
>>> more like an error than a normal state.
>>>
>>> Change the message to something less scary in case the hypervisor
>>> returns EOPNOTSUPP when trying to activate VPMU.
>>>
>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>> ---
>>> arch/x86/xen/pmu.c | 7 +++++--
>>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/arch/x86/xen/pmu.c b/arch/x86/xen/pmu.c
>>> index 32bdc2c..e9d66fa 100644
>>> --- a/arch/x86/xen/pmu.c
>>> +++ b/arch/x86/xen/pmu.c
>>> @@ -547,8 +547,11 @@ void xen_pmu_init(int cpu)
>>> return;
>>>
>>> fail:
>>> - pr_info_once("Could not initialize VPMU for cpu %d, error %d\n",
>>> - cpu, err);
>>> + if (err == -EOPNOTSUPP)
>>> + pr_info_once("VPMU usage disabled due to Xen settings\n");
>> How about 'VPMU disabled by hypevisor.'
> Hmm, why not. Boris, are you okay with this message, too?
Sure.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-08-01 17:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-01 11:41 [PATCH] xen: Make VPMU init message look less scary Juergen Gross
2016-08-01 14:11 ` Boris Ostrovsky
2016-08-01 14:11 ` [Xen-devel] " Konrad Rzeszutek Wilk
2016-08-01 15:48 ` Juergen Gross
2016-08-01 15:50 ` Boris Ostrovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®