[PATCH 2/2] scripts/sortextable: set the variable mmap_failure

[PATCH 2/2] scripts/sortextable: set the variable mmap_failure

[Maninder Singh]

Currently mmap_failed variable is 1 for every case, so make it 0
if mmap is success.

Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
Signed-off-by: Vaneet Narang <v.narang@samsung.com>
---
 scripts/sortextable.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/sortextable.c b/scripts/sortextable.c
index 30b4e7c..0b6a31b 100644
--- a/scripts/sortextable.c
+++ b/scripts/sortextable.c
@@ -106,6 +106,7 @@ static void *mmap_file(char const *fname)
 	}
 	addr = mmap(0, sb.st_size, PROT_READ|PROT_WRITE, MAP_SHARED,
 		    fd_map, 0);
+	mmap_failed = 0;
 	if (addr == MAP_FAILED) {
 		mmap_failed = 1;
 		fprintf(stderr, "Could not mmap file: %s\n", fname);
-- 
1.7.9.5

Re: [PATCH 2/2] scripts/sortextable: set the variable mmap_failure

[Borislav Petkov]

On Thu, Aug 11, 2016 at 09:52:55AM +0530, Maninder Singh wrote:
> Currently mmap_failed variable is 1 for every case, so make it 0
> if mmap is success.
> 
> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> Signed-off-by: Vaneet Narang <v.narang@samsung.com>

See section 11) of Documentation/SubmittingPatches on how the sign-off
chain should be done.

It is not clear from your current submission what Vaneet's role is in
the creation of this patch is. Ditto for your other patch.

> ---
>  scripts/sortextable.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/scripts/sortextable.c b/scripts/sortextable.c
> index 30b4e7c..0b6a31b 100644
> --- a/scripts/sortextable.c
> +++ b/scripts/sortextable.c
> @@ -106,6 +106,7 @@ static void *mmap_file(char const *fname)
>  	}
>  	addr = mmap(0, sb.st_size, PROT_READ|PROT_WRITE, MAP_SHARED,
>  		    fd_map, 0);
> +	mmap_failed = 0;

This mmap_failed thing looks like a disaster. It is only needed so
that we know to do munmap() but munmap() works even if the range is
not mapped so you probably could go and remove that mmap_failed thing
altogether.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--