* [PATCH net-next] net: bgmac: make it clear when setting interface type to RMII
@ 2016-08-17 21:11 Rafał Miłecki
2016-08-19 6:36 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Rafał Miłecki @ 2016-08-17 21:11 UTC (permalink / raw)
To: David S. Miller, netdev
Cc: Rafał Miłecki, Florian Fainelli, Jon Mason,
Arnd Bergmann, Philippe Reynes, open list
From: Rafał Miłecki <rafal@milecki.pl>
It doesn't really change anything as BGMAC_CHIPCTL_1_IF_TYPE_RMII is
equal to 0. It make code a bit clener, so far when reading it one could
think we forgot to set a proper mode. It also keeps this mode code in
sync with other ones.
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
drivers/net/ethernet/broadcom/bgmac.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c
index 63ef7235..6ea0e5f 100644
--- a/drivers/net/ethernet/broadcom/bgmac.c
+++ b/drivers/net/ethernet/broadcom/bgmac.c
@@ -932,7 +932,8 @@ static void bgmac_chip_reset(struct bgmac *bgmac)
et_swtype <<= 4;
sw_type = et_swtype;
} else if (bgmac->feature_flags & BGMAC_FEAT_SW_TYPE_EPHYRMII) {
- sw_type = BGMAC_CHIPCTL_1_SW_TYPE_EPHYRMII;
+ sw_type = BGMAC_CHIPCTL_1_IF_TYPE_RMII |
+ BGMAC_CHIPCTL_1_SW_TYPE_EPHYRMII;
} else if (bgmac->feature_flags & BGMAC_FEAT_SW_TYPE_RGMII) {
sw_type = BGMAC_CHIPCTL_1_IF_TYPE_RGMII |
BGMAC_CHIPCTL_1_SW_TYPE_RGMII;
--
1.8.4.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: bgmac: make it clear when setting interface type to RMII
2016-08-17 21:11 [PATCH net-next] net: bgmac: make it clear when setting interface type to RMII Rafał Miłecki
@ 2016-08-19 6:36 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-08-19 6:36 UTC (permalink / raw)
To: zajec5; +Cc: netdev, rafal, f.fainelli, jon.mason, arnd, tremyfr, linux-kernel
From: Rafał Miłecki <zajec5@gmail.com>
Date: Wed, 17 Aug 2016 23:11:52 +0200
> From: Rafał Miłecki <rafal@milecki.pl>
>
> It doesn't really change anything as BGMAC_CHIPCTL_1_IF_TYPE_RMII is
> equal to 0. It make code a bit clener, so far when reading it one could
> think we forgot to set a proper mode. It also keeps this mode code in
> sync with other ones.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-19 6:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-17 21:11 [PATCH net-next] net: bgmac: make it clear when setting interface type to RMII Rafał Miłecki
2016-08-19 6:36 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®