mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 85/87] staging: wlang-ng: avoid new typedef: hfa384x_metacmd_t
@ 2016-09-28 17:17 Sergio Paracuellos
  0 siblings, 0 replies; 2+ messages in thread
From: Sergio Paracuellos @ 2016-09-28 17:17 UTC (permalink / raw)
  To: gregkh; +Cc: devel, linux-kernel

This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs

It applies for typedef hfa384x_metacmd_t

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
---
 drivers/staging/wlan-ng/hfa384x.h     |  4 ++--
 drivers/staging/wlan-ng/hfa384x_usb.c | 18 +++++++++---------
 2 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
index 736ac31..b97099d 100644
--- a/drivers/staging/wlan-ng/hfa384x.h
+++ b/drivers/staging/wlan-ng/hfa384x.h
@@ -1206,7 +1206,7 @@ struct hfa384x_usbctlxq {
 	struct list_head reapable;
 };
 
-typedef struct hfa484x_metacmd {
+struct hfa384x_metacmd {
 	u16 cmd;
 
 	u16 parm0;
@@ -1214,7 +1214,7 @@ struct hfa384x_usbctlxq {
 	u16 parm2;
 
 	struct hfa384x_cmdresult result;
-} hfa384x_metacmd_t;
+};
 
 #define	MAX_GRP_ADDR		32
 #define WLAN_COMMENT_MAX	80  /* Max. length of user comment string. */
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
index 1f0c428..7b0aae5 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -224,7 +224,7 @@ struct usbctlx_completor {
 static int
 hfa384x_docmd(hfa384x_t *hw,
 	      enum cmd_mode mode,
-	      hfa384x_metacmd_t *cmd,
+	      struct hfa384x_metacmd *cmd,
 	      ctlx_cmdcb_t cmdcb, ctlx_usercb_t usercb, void *usercb_data);
 
 static int
@@ -812,14 +812,14 @@ static void hfa384x_cb_status(hfa384x_t *hw, const struct hfa384x_usbctlx *ctlx)
 	}
 }
 
-static inline int hfa384x_docmd_wait(hfa384x_t *hw, hfa384x_metacmd_t *cmd)
+static inline int hfa384x_docmd_wait(hfa384x_t *hw, struct hfa384x_metacmd *cmd)
 {
 	return hfa384x_docmd(hw, DOWAIT, cmd, NULL, NULL, NULL);
 }
 
 static inline int
 hfa384x_docmd_async(hfa384x_t *hw,
-		    hfa384x_metacmd_t *cmd,
+		    struct hfa384x_metacmd *cmd,
 		    ctlx_cmdcb_t cmdcb, ctlx_usercb_t usercb, void *usercb_data)
 {
 	return hfa384x_docmd(hw, DOASYNC, cmd, cmdcb, usercb, usercb_data);
@@ -927,7 +927,7 @@ int hfa384x_cmd_initialize(hfa384x_t *hw)
 {
 	int result = 0;
 	int i;
-	hfa384x_metacmd_t cmd;
+	struct hfa384x_metacmd cmd;
 
 	cmd.cmd = HFA384x_CMDCODE_INIT;
 	cmd.parm0 = 0;
@@ -971,7 +971,7 @@ int hfa384x_cmd_initialize(hfa384x_t *hw)
 ----------------------------------------------------------------*/
 int hfa384x_cmd_disable(hfa384x_t *hw, u16 macport)
 {
-	hfa384x_metacmd_t cmd;
+	struct hfa384x_metacmd cmd;
 
 	cmd.cmd = HFA384x_CMD_CMDCODE_SET(HFA384x_CMDCODE_DISABLE) |
 	    HFA384x_CMD_MACPORT_SET(macport);
@@ -1004,7 +1004,7 @@ int hfa384x_cmd_disable(hfa384x_t *hw, u16 macport)
 ----------------------------------------------------------------*/
 int hfa384x_cmd_enable(hfa384x_t *hw, u16 macport)
 {
-	hfa384x_metacmd_t cmd;
+	struct hfa384x_metacmd cmd;
 
 	cmd.cmd = HFA384x_CMD_CMDCODE_SET(HFA384x_CMDCODE_ENABLE) |
 	    HFA384x_CMD_MACPORT_SET(macport);
@@ -1046,7 +1046,7 @@ int hfa384x_cmd_enable(hfa384x_t *hw, u16 macport)
 ----------------------------------------------------------------*/
 int hfa384x_cmd_monitor(hfa384x_t *hw, u16 enable)
 {
-	hfa384x_metacmd_t cmd;
+	struct hfa384x_metacmd cmd;
 
 	cmd.cmd = HFA384x_CMD_CMDCODE_SET(HFA384x_CMDCODE_MONITOR) |
 	    HFA384x_CMD_AINFO_SET(enable);
@@ -1098,7 +1098,7 @@ int hfa384x_cmd_monitor(hfa384x_t *hw, u16 enable)
 int hfa384x_cmd_download(hfa384x_t *hw, u16 mode, u16 lowaddr,
 			 u16 highaddr, u16 codelen)
 {
-	hfa384x_metacmd_t cmd;
+	struct hfa384x_metacmd cmd;
 
 	pr_debug("mode=%d, lowaddr=0x%04x, highaddr=0x%04x, codelen=%d\n",
 		 mode, lowaddr, highaddr, codelen);
@@ -1291,7 +1291,7 @@ static int hfa384x_usbctlx_complete_sync(hfa384x_t *hw,
 static int
 hfa384x_docmd(hfa384x_t *hw,
 	      enum cmd_mode mode,
-	      hfa384x_metacmd_t *cmd,
+	      struct hfa384x_metacmd *cmd,
 	      ctlx_cmdcb_t cmdcb, ctlx_usercb_t usercb, void *usercb_data)
 {
 	int result;
-- 
1.9.1

^ permalink raw reply	[flat|nested] 2+ messages in thread
* [PATCH 00/87] Fix some style warnings in hfa384x.h
@ 2016-09-28 18:18 Sergio Paracuellos
  2016-09-28 18:20 ` [PATCH 85/87] staging: wlang-ng: avoid new typedef: hfa384x_metacmd_t Sergio Paracuellos
  0 siblings, 1 reply; 2+ messages in thread
From: Sergio Paracuellos @ 2016-09-28 18:18 UTC (permalink / raw)
  To: gregkh; +Cc: devel, linux-kernel

This patch series fix some warnings reported by checkpatch.pl script in hfa384x.h:
WARNING: Block comments use * on subsequent lines
WARNING: Block comments use a trailing */ on a separate line
WARNING: do not add new typedefs

Sergio Paracuellos (87):
  staging: wlang-ng: avoid new typedef: hfa384x_bytestr32_t
  staging: wlang-ng: avoid new typedef: hfa384x_compident_t
  staging: wlang-ng: Fix block comments style warnings in hfa384x.h
  staging: wlang-ng: avoid new typedef: hfa384x_caplevel_t
  staging: wlang-ng: avoid new typedef: hfa384x_HostScanRequest_data_t
  staging: wlang-ng: avoid new typedef: hfa384x_JoinRequest_data_t
  staging: wlang-ng: avoid new typedef:
    hfa384x_authenticateStation_data_t
  staging: wlang-ng: avoid new typedef: hfa384x_WPAData_t
  staging: wlang-ng: avoid new typedef: hfa384x_downloadbuffer_t
  staging: wlang-ng: avoid new typedef: hfa384x_commsquality_t
  staging: wlang-ng: avoid new typedef: hfa384x_dbmcommsquality_t
  staging: wlang-ng: avoid new typedef: hfa384x_tx_frame_t
  staging: wlang-ng: avoid new typedef: hfa384x_rx_frame_t
  staging: wlang-ng: avoid new typedef: hfa384x_CommTallies16_t
  staging: wlang-ng: avoid new typedef: hfa384x_CommTallies32_t
  staging: wlang-ng: avoid new typedef: hfa384x_ScanResultSub_t
  staging: wlang-ng: avoid new typedef: hfa384x_ScanResult_t
  staging: wlang-ng: avoid new typedef: hfa384x_ChInfoResultSub_t
  staging: wlang-ng: avoid new typedef: hfa384x_ChInfoResult_t
  staging: wlang-ng: avoid new typedef: hfa384x_HScanResultSub_t
  staging: wlang-ng: avoid new typedef: hfa384x_HScanResult_t
  staging: wlang-ng: avoid new typedef: hfa384x_LinkStatus_t
  staging: wlang-ng: avoid new typedef: hfa384x_AssocStatus_t
  staging: wlang-ng: avoid new typedef: hfa384x_AuthReq_t
  staging: wlang-ng: avoid new typedef: hfa384x_PSUserCount_t
  staging: wlang-ng: avoid new typedef: hfa384x_KeyIDChanged_t
  staging: wlang-ng: avoid new typedef: hfa384x_infodata_t
  staging: wlang-ng: avoid new typedef: hfa384x_InfFrame_t
  staging: wlang-ng: avoid new typedef: hfa384x_usb_txfrm_t
  staging: wlang-ng: avoid new typedef: hfa384x_usb_cmdreq_t
  staging: wlang-ng: avoid new typedef: hfa384x_usb_wridreq_t
  staging: wlang-ng: avoid new typedef: hfa384x_usb_rridreq_t
  staging: wlang-ng: avoid new typedef: hfa384x_usb_wmemreq_t
  staging: wlang-ng: avoid new typedef: hfa384x_usb_rmemreq_t
  staging: wlang-ng: avoid new typedef: hfa384x_usb_rxfrm_t
  staging: wlang-ng: avoid new typedef: hfa384x_usb_infofrm_t
  staging: wlang-ng: avoid new typedef: hfa384x_usb_cmdresp_t
  staging: wlang-ng: avoid new typedef: hfa384x_usb_wridresp_t
  staging: wlang-ng: avoid new typedef: hfa384x_usb_rridresp_t
  staging: wlang-ng: avoid new typedef: hfa384x_usb_wmemresp_t
  staging: wlang-ng: avoid new typedef: hfa384x_usb_rmemresp_t
  staging: wlang-ng: avoid new typedef: hfa384x_usb_bufavail_t
  staging: wlang-ng: avoid new typedef: hfa384x_usb_error_t
  staging: wlang-ng: avoid new typedef: hfa384x_usbout_t
  staging: wlang-ng: avoid new typedef: hfa384x_usbin_t
  staging: wlang-ng: avoid new typedef: hfa384x_pdr_pcb_partnum_t
  staging: wlang-ng: avoid new typedef: hfa384x_pdr_pcb_tracenum_t
  staging: wlang-ng: avoid new typedef: hfa384x_pdr_nic_serial_t
  staging: wlang-ng: avoid new typedef: hfa384x_pdr_mkk_measurements_t
  staging: wlang-ng: avoid new typedef: hfa384x_pdr_nic_ramsize_t
  staging: wlang-ng: avoid new typedef: hfa384x_pdr_mfisuprange_t
  staging: wlang-ng: avoid new typedef: hfa384x_pdr_cfisuprange_t
  staging: wlang-ng: avoid new typedef: hfa384x_pdr_nicid_t
  staging: wlang-ng: avoid new typedef:
    hfa384x_pdr_refdac_measurements_t
  staging: wlang-ng: avoid new typedef: hfa384x_pdr_vgdac_measurements_t
  staging: wlang-ng: avoid new typedef:
    hfa384x_pdr_level_compc_measurements_t
  staging: wlang-ng: avoid new typedef: hfa384x_pdr_mac_address_t
  staging: wlang-ng: avoid new typedef: hfa384x_pdr_mkk_callname_t
  staging: wlang-ng: avoid new typedef: hfa384x_pdr_regdomain_t
  staging: wlang-ng: avoid new typedef: hfa384x_pdr_allowed_channel_t
  staging: wlang-ng: avoid new typedef: hfa384x_pdr_default_channel_t
  staging: wlang-ng: avoid new typedef: hfa384x_pdr_privacy_option_t
  staging: wlang-ng: avoid new typedef: hfa384x_pdr_temptype_t
  staging: wlang-ng: avoid new typedef: hfa384x_pdr_refdac_setup_t
  staging: wlang-ng: avoid new typedef: hfa384x_pdr_vgdac_setup_t
  staging: wlang-ng: avoid new typedef: hfa384x_pdr_level_comp_setup_t
  staging: wlang-ng: avoid new typedef: hfa384x_pdr_trimdac_setup_t
  staging: wlang-ng: avoid new typedef: hfa384x_pdr_ifr_setting_t
  staging: wlang-ng: avoid new typedef: hfa384x_pdr_rfr_setting_t
  staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_baseline_t
  staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_shadow_t
  staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_ifrf_t
  staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_chcalsp_t
  staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_chcali_t
  staging: wlang-ng: avoid new typedef: hfa384x_pdr_nic_config_t
  staging: wlang-ng: avoid new typedef: hfa384x_hfo_delay_t
  staging: wlang-ng: avoid new typedef:
    hfa384x_pdr_hfa3861_manf_testsp_t
  staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_manf_testi_t
  staging: wlang-ng: avoid new typedef: hfa384x_pdr_end_of_pda_t
  staging: wlang-ng: avoid new typedef: hfa384x_pdrec_t
  staging: wlang-ng: avoid new typedef: hfa384x_cmdresult_t
  staging: wlang-ng: avoid new typedef: hfa384x_rridresult_t
  staging: wlang-ng: avoid new typedef: hfa384x_usbctlx_t
  staging: wlang-ng: avoid new typedef: hfa384x_usbctlxq_t
  staging: wlang-ng: avoid new typedef: hfa384x_metacmd_t
  staging: wlang-ng: avoid new typedef: hfa384x_t
  staging: wlang-ng: Fix block comments style warnings in hfa384x.h

 drivers/staging/wlan-ng/hfa384x.h     | 874 +++++++++++++++++-----------------
 drivers/staging/wlan-ng/hfa384x_usb.c | 293 ++++++------
 drivers/staging/wlan-ng/prism2fw.c    |  22 +-
 drivers/staging/wlan-ng/prism2mgmt.c  |  26 +-
 drivers/staging/wlan-ng/prism2mgmt.h  |   7 +-
 drivers/staging/wlan-ng/prism2mib.c   |  38 +-
 drivers/staging/wlan-ng/prism2sta.c   | 130 ++---
 drivers/staging/wlan-ng/prism2usb.c   |  10 +-
 8 files changed, 712 insertions(+), 688 deletions(-)

-- 
1.9.1

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-28 18:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-28 17:17 [PATCH 85/87] staging: wlang-ng: avoid new typedef: hfa384x_metacmd_t Sergio Paracuellos
2016-09-28 18:18 [PATCH 00/87] Fix some style warnings in hfa384x.h Sergio Paracuellos
2016-09-28 18:20 ` [PATCH 85/87] staging: wlang-ng: avoid new typedef: hfa384x_metacmd_t Sergio Paracuellos

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®