* [PATCH] drm/amd/powerplay: fix spelling mistake and add KERN_WARNING to printks
@ 2016-10-24 22:30 Colin King
2016-10-24 23:05 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2016-10-24 22:30 UTC (permalink / raw)
To: Alex Deucher, Christian König, David Airlie, Rex Zhu,
Nils Wallménius, dri-devel
Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Fix trivial spelling mistake cant't -> can't and add KERN_WARNING to
printk messages.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c | 4 ++--
drivers/gpu/drm/amd/powerplay/smumgr/iceland_smc.c | 4 ++--
drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smc.c | 4 ++--
drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c | 4 ++--
4 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c b/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c
index 76310ac..747eb5d 100644
--- a/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c
+++ b/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c
@@ -2125,7 +2125,7 @@ uint32_t fiji_get_offsetof(uint32_t type, uint32_t member)
return offsetof(SMU73_Discrete_DpmTable, LowSclkInterruptThreshold);
}
}
- printk("cant't get the offset of type %x member %x \n", type, member);
+ printk(KERN_WARNING "can't get the offset of type %x member %x \n", type, member);
return 0;
}
@@ -2150,7 +2150,7 @@ uint32_t fiji_get_mac_definition(uint32_t value)
return SMU73_MAX_LEVELS_MVDD;
}
- printk("cant't get the mac of %x \n", value);
+ printk(KERN_WARNING "can't get the mac of %x \n", value);
return 0;
}
diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/iceland_smc.c b/drivers/gpu/drm/amd/powerplay/smumgr/iceland_smc.c
index 8c889ca..e471139 100644
--- a/drivers/gpu/drm/amd/powerplay/smumgr/iceland_smc.c
+++ b/drivers/gpu/drm/amd/powerplay/smumgr/iceland_smc.c
@@ -2140,7 +2140,7 @@ uint32_t iceland_get_offsetof(uint32_t type, uint32_t member)
return offsetof(SMU71_Discrete_DpmTable, LowSclkInterruptThreshold);
}
}
- printk("cant't get the offset of type %x member %x \n", type, member);
+ printk(KERN_WARNING "can't get the offset of type %x member %x \n", type, member);
return 0;
}
@@ -2163,7 +2163,7 @@ uint32_t iceland_get_mac_definition(uint32_t value)
return SMU71_MAX_LEVELS_MVDD;
}
- printk("cant't get the mac of %x \n", value);
+ printk(KERN_WARNING "can't get the mac of %x \n", value);
return 0;
}
diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smc.c b/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smc.c
index 4ccc0b7..7b4efcc 100644
--- a/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smc.c
+++ b/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smc.c
@@ -2174,7 +2174,7 @@ uint32_t polaris10_get_offsetof(uint32_t type, uint32_t member)
return offsetof(SMU74_Discrete_DpmTable, LowSclkInterruptThreshold);
}
}
- printk("cant't get the offset of type %x member %x \n", type, member);
+ printk(KERN_WARNING "can't get the offset of type %x member %x \n", type, member);
return 0;
}
@@ -2201,7 +2201,7 @@ uint32_t polaris10_get_mac_definition(uint32_t value)
return SMU7_UVD_MCLK_HANDSHAKE_DISABLE;
}
- printk("cant't get the mac of %x \n", value);
+ printk(KERN_WARNING "can't get the mac of %x \n", value);
return 0;
}
diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c b/drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c
index de2a24d..84868e8 100644
--- a/drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c
+++ b/drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c
@@ -2651,7 +2651,7 @@ uint32_t tonga_get_offsetof(uint32_t type, uint32_t member)
return offsetof(SMU72_Discrete_DpmTable, LowSclkInterruptThreshold);
}
}
- printk("cant't get the offset of type %x member %x\n", type, member);
+ printk(KERN_WARNING "can't get the offset of type %x member %x\n", type, member);
return 0;
}
@@ -2675,7 +2675,7 @@ uint32_t tonga_get_mac_definition(uint32_t value)
case SMU_MAX_LEVELS_MVDD:
return SMU72_MAX_LEVELS_MVDD;
}
- printk("cant't get the mac value %x\n", value);
+ printk(KERN_WARNING "can't get the mac value %x\n", value);
return 0;
}
--
2.9.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amd/powerplay: fix spelling mistake and add KERN_WARNING to printks
2016-10-24 22:30 [PATCH] drm/amd/powerplay: fix spelling mistake and add KERN_WARNING to printks Colin King
@ 2016-10-24 23:05 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2016-10-24 23:05 UTC (permalink / raw)
To: Colin King, Alex Deucher, Christian König, David Airlie,
Rex Zhu, Nils Wallménius, dri-devel
Cc: linux-kernel
On Mon, 2016-10-24 at 23:30 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Fix trivial spelling mistake cant't -> can't and add KERN_WARNING to
> printk messages.
trivia:
> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c b/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c
[]
> @@ -2125,7 +2125,7 @@ uint32_t fiji_get_offsetof(uint32_t type, uint32_t member)
> return offsetof(SMU73_Discrete_DpmTable, LowSclkInterruptThreshold);
> }
> }
> - printk("cant't get the offset of type %x member %x \n", type, member);
> + printk(KERN_WARNING "can't get the offset of type %x member %x \n", type, member);
you can also delete the spaces before a newline.
> return 0;
> }
>
> @@ -2150,7 +2150,7 @@ uint32_t fiji_get_mac_definition(uint32_t value)
> return SMU73_MAX_LEVELS_MVDD;
> }
>
> - printk("cant't get the mac of %x \n", value);
> + printk(KERN_WARNING "can't get the mac of %x \n", value);
et al, below
> return 0;
> }
>
> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/iceland_smc.c b/drivers/gpu/drm/amd/powerplay/smumgr/iceland_smc.c
[]
> @@ -2140,7 +2140,7 @@ uint32_t iceland_get_offsetof(uint32_t type, uint32_t member)
> return offsetof(SMU71_Discrete_DpmTable, LowSclkInterruptThreshold);
> }
> }
> - printk("cant't get the offset of type %x member %x \n", type, member);
> + printk(KERN_WARNING "can't get the offset of type %x member %x \n", type, member);
> return 0;
> }
>
> @@ -2163,7 +2163,7 @@ uint32_t iceland_get_mac_definition(uint32_t value)
> return SMU71_MAX_LEVELS_MVDD;
> }
>
> - printk("cant't get the mac of %x \n", value);
> + printk(KERN_WARNING "can't get the mac of %x \n", value);
> return 0;
> }
>
> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smc.c b/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smc.c
> index 4ccc0b7..7b4efcc 100644
> --- a/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smc.c
> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smc.c
> @@ -2174,7 +2174,7 @@ uint32_t polaris10_get_offsetof(uint32_t type, uint32_t member)
> return offsetof(SMU74_Discrete_DpmTable, LowSclkInterruptThreshold);
> }
> }
> - printk("cant't get the offset of type %x member %x \n", type, member);
> + printk(KERN_WARNING "can't get the offset of type %x member %x \n", type, member);
> return 0;
> }
>
> @@ -2201,7 +2201,7 @@ uint32_t polaris10_get_mac_definition(uint32_t value)
> return SMU7_UVD_MCLK_HANDSHAKE_DISABLE;
> }
>
> - printk("cant't get the mac of %x \n", value);
> + printk(KERN_WARNING "can't get the mac of %x \n", value);
> return 0;
> }
>
> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c b/drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c
> index de2a24d..84868e8 100644
> --- a/drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c
> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c
> @@ -2651,7 +2651,7 @@ uint32_t tonga_get_offsetof(uint32_t type, uint32_t member)
> return offsetof(SMU72_Discrete_DpmTable, LowSclkInterruptThreshold);
> }
> }
> - printk("cant't get the offset of type %x member %x\n", type, member);
> + printk(KERN_WARNING "can't get the offset of type %x member %x\n", type, member);
> return 0;
> }
>
> @@ -2675,7 +2675,7 @@ uint32_t tonga_get_mac_definition(uint32_t value)
> case SMU_MAX_LEVELS_MVDD:
> return SMU72_MAX_LEVELS_MVDD;
> }
> - printk("cant't get the mac value %x\n", value);
> + printk(KERN_WARNING "can't get the mac value %x\n", value);
>
> return 0;
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-24 23:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-24 22:30 [PATCH] drm/amd/powerplay: fix spelling mistake and add KERN_WARNING to printks Colin King
2016-10-24 23:05 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome