* [PATCH] usb: mtu3: declare functions static
@ 2016-11-13 20:45 Sudip Mukherjee
2016-11-14 1:37 ` Chunfeng Yun
0 siblings, 1 reply; 2+ messages in thread
From: Sudip Mukherjee @ 2016-11-13 20:45 UTC (permalink / raw)
To: Greg Kroah-Hartman, Chunfeng Yun; +Cc: linux-kernel, linux-usb, Sudip Mukherjee
The only user of the functions mtu3_irq() and gpd_ring_empty() are in
the same file. They can be declared as static.
Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
---
drivers/usb/mtu3/mtu3_core.c | 2 +-
drivers/usb/mtu3/mtu3_qmu.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/mtu3/mtu3_core.c b/drivers/usb/mtu3/mtu3_core.c
index 520e55a..603b7f84 100644
--- a/drivers/usb/mtu3/mtu3_core.c
+++ b/drivers/usb/mtu3/mtu3_core.c
@@ -696,7 +696,7 @@ static irqreturn_t mtu3_u2_common_isr(struct mtu3 *mtu)
return IRQ_HANDLED;
}
-irqreturn_t mtu3_irq(int irq, void *data)
+static irqreturn_t mtu3_irq(int irq, void *data)
{
struct mtu3 *mtu = (struct mtu3 *)data;
unsigned long flags;
diff --git a/drivers/usb/mtu3/mtu3_qmu.c b/drivers/usb/mtu3/mtu3_qmu.c
index a6dd292..7d9ba8a 100644
--- a/drivers/usb/mtu3/mtu3_qmu.c
+++ b/drivers/usb/mtu3/mtu3_qmu.c
@@ -168,7 +168,7 @@ static struct qmu_gpd *advance_deq_gpd(struct mtu3_gpd_ring *ring)
}
/* check if a ring is emtpy */
-int gpd_ring_empty(struct mtu3_gpd_ring *ring)
+static int gpd_ring_empty(struct mtu3_gpd_ring *ring)
{
struct qmu_gpd *enq = ring->enqueue;
struct qmu_gpd *next;
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: mtu3: declare functions static
2016-11-13 20:45 [PATCH] usb: mtu3: declare functions static Sudip Mukherjee
@ 2016-11-14 1:37 ` Chunfeng Yun
0 siblings, 0 replies; 2+ messages in thread
From: Chunfeng Yun @ 2016-11-14 1:37 UTC (permalink / raw)
To: Sudip Mukherjee; +Cc: Greg Kroah-Hartman, linux-kernel, linux-usb
Hi,
On Sun, 2016-11-13 at 20:45 +0000, Sudip Mukherjee wrote:
> The only user of the functions mtu3_irq() and gpd_ring_empty() are in
> the same file. They can be declared as static.
>
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> ---
> drivers/usb/mtu3/mtu3_core.c | 2 +-
> drivers/usb/mtu3/mtu3_qmu.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/mtu3/mtu3_core.c b/drivers/usb/mtu3/mtu3_core.c
> index 520e55a..603b7f84 100644
> --- a/drivers/usb/mtu3/mtu3_core.c
> +++ b/drivers/usb/mtu3/mtu3_core.c
> @@ -696,7 +696,7 @@ static irqreturn_t mtu3_u2_common_isr(struct mtu3 *mtu)
> return IRQ_HANDLED;
> }
>
> -irqreturn_t mtu3_irq(int irq, void *data)
> +static irqreturn_t mtu3_irq(int irq, void *data)
> {
> struct mtu3 *mtu = (struct mtu3 *)data;
> unsigned long flags;
> diff --git a/drivers/usb/mtu3/mtu3_qmu.c b/drivers/usb/mtu3/mtu3_qmu.c
> index a6dd292..7d9ba8a 100644
> --- a/drivers/usb/mtu3/mtu3_qmu.c
> +++ b/drivers/usb/mtu3/mtu3_qmu.c
> @@ -168,7 +168,7 @@ static struct qmu_gpd *advance_deq_gpd(struct mtu3_gpd_ring *ring)
> }
>
> /* check if a ring is emtpy */
> -int gpd_ring_empty(struct mtu3_gpd_ring *ring)
> +static int gpd_ring_empty(struct mtu3_gpd_ring *ring)
> {
> struct qmu_gpd *enq = ring->enqueue;
> struct qmu_gpd *next;
It's my carelessness.
Acked-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-14 1:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-13 20:45 [PATCH] usb: mtu3: declare functions static Sudip Mukherjee
2016-11-14 1:37 ` Chunfeng Yun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®