* [PATCH 1/1 v2] xen: xenbus: set error code on failure
@ 2016-12-05 8:22 Pan Bian
2016-12-05 9:00 ` Juergen Gross
2016-12-08 6:58 ` Juergen Gross
0 siblings, 2 replies; 3+ messages in thread
From: Pan Bian @ 2016-12-05 8:22 UTC (permalink / raw)
To: Juergen Gross, David Vrabel, Boris Ostrovsky, xen-devel
Cc: linux-kernel, Pan Bian
Variable err is initialized with 0. As a result, the return value may
be 0 even if get_zeroed_page() fails to allocate memory. This patch fixes
the bug, initializing err with "-ENOMEM".
v1 is reviewed by: Juergen Gross <jgross@suse.com>
Signed-off-by: Pan Bian <bianpan2016@163.com>
---
drivers/xen/xenbus/xenbus_probe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/xen/xenbus/xenbus_probe.c b/drivers/xen/xenbus/xenbus_probe.c
index 33a31cf..8178d5b 100644
--- a/drivers/xen/xenbus/xenbus_probe.c
+++ b/drivers/xen/xenbus/xenbus_probe.c
@@ -702,7 +702,7 @@ static int __init xenbus_probe_initcall(void)
*/
static int __init xenstored_local_init(void)
{
- int err = 0;
+ int err = -ENOMEM;
unsigned long page = 0;
struct evtchn_alloc_unbound alloc_unbound;
--
1.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1 v2] xen: xenbus: set error code on failure
2016-12-05 8:22 [PATCH 1/1 v2] xen: xenbus: set error code on failure Pan Bian
@ 2016-12-05 9:00 ` Juergen Gross
2016-12-08 6:58 ` Juergen Gross
1 sibling, 0 replies; 3+ messages in thread
From: Juergen Gross @ 2016-12-05 9:00 UTC (permalink / raw)
To: Pan Bian, David Vrabel, Boris Ostrovsky, xen-devel; +Cc: linux-kernel
On 05/12/16 09:22, Pan Bian wrote:
> Variable err is initialized with 0. As a result, the return value may
> be 0 even if get_zeroed_page() fails to allocate memory. This patch fixes
> the bug, initializing err with "-ENOMEM".
>
> v1 is reviewed by: Juergen Gross <jgross@suse.com>
I didn't say so.
> Signed-off-by: Pan Bian <bianpan2016@163.com>
Now I do:
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
> ---
> drivers/xen/xenbus/xenbus_probe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/xen/xenbus/xenbus_probe.c b/drivers/xen/xenbus/xenbus_probe.c
> index 33a31cf..8178d5b 100644
> --- a/drivers/xen/xenbus/xenbus_probe.c
> +++ b/drivers/xen/xenbus/xenbus_probe.c
> @@ -702,7 +702,7 @@ static int __init xenbus_probe_initcall(void)
> */
> static int __init xenstored_local_init(void)
> {
> - int err = 0;
> + int err = -ENOMEM;
> unsigned long page = 0;
> struct evtchn_alloc_unbound alloc_unbound;
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1 v2] xen: xenbus: set error code on failure
2016-12-05 8:22 [PATCH 1/1 v2] xen: xenbus: set error code on failure Pan Bian
2016-12-05 9:00 ` Juergen Gross
@ 2016-12-08 6:58 ` Juergen Gross
1 sibling, 0 replies; 3+ messages in thread
From: Juergen Gross @ 2016-12-08 6:58 UTC (permalink / raw)
To: Pan Bian, David Vrabel, Boris Ostrovsky, xen-devel; +Cc: linux-kernel
On 05/12/16 09:22, Pan Bian wrote:
> Variable err is initialized with 0. As a result, the return value may
> be 0 even if get_zeroed_page() fails to allocate memory. This patch fixes
> the bug, initializing err with "-ENOMEM".
>
> v1 is reviewed by: Juergen Gross <jgross@suse.com>
>
> Signed-off-by: Pan Bian <bianpan2016@163.com>
Commited to xen/tip.git for-linus-4.10
Juergen
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-12-08 6:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-05 8:22 [PATCH 1/1 v2] xen: xenbus: set error code on failure Pan Bian
2016-12-05 9:00 ` Juergen Gross
2016-12-08 6:58 ` Juergen Gross
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®