* [PATCH] eeprom: idt_89hpesx: Discard memory freeing allocated by devm_kmalloc
@ 2017-01-26 13:00 Serge Semin
0 siblings, 0 replies; only message in thread
From: Serge Semin @ 2017-01-26 13:00 UTC (permalink / raw)
To: gregkh, julia.lawall; +Cc: Sergey.Semin, linux-kernel, Serge Semin
Indeed, the data structure is allocated by device resource manager,
so the driver doesn't need to free anything on remove() callback.
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Serge Semin <fancer.lancer@gmail.com>
---
drivers/misc/eeprom/idt_89hpesx.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/misc/eeprom/idt_89hpesx.c
index 25d47d0..f73fd04 100644
--- a/drivers/misc/eeprom/idt_89hpesx.c
+++ b/drivers/misc/eeprom/idt_89hpesx.c
@@ -1227,9 +1227,6 @@ static void idt_free_pdev(struct idt_89hpesx_dev *pdev)
{
/* Clear driver data from device private field */
i2c_set_clientdata(pdev->client, NULL);
-
- /* Just free memory allocated for data */
- devm_kfree(&pdev->client->dev, pdev);
}
/*
--
2.6.6
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-01-26 13:00 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-26 13:00 [PATCH] eeprom: idt_89hpesx: Discard memory freeing allocated by devm_kmalloc Serge Semin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome