mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kishon Vijay Abraham I <kishon@ti.com>
To: <gregkh@linuxfoundation.org>
Cc: <kishon@ti.com>, <linux-kernel@vger.kernel.org>
Subject: [PATCH 13/14] phy: fix rockchip-inno-usb2 build errors
Date: Mon, 30 Jan 2017 17:19:49 +0530	[thread overview]
Message-ID: <1485776992-8818-27-git-send-email-kishon@ti.com> (raw)
In-Reply-To: <1485776992-8818-1-git-send-email-kishon@ti.com>

From: Randy Dunlap <rdunlap@infradead.org>

Fix build errors in phy-rockchip-inno-usb2.c. The driver uses
extcon interfaces so it should depend on EXTCON.

Fixes these build errors:

drivers/built-in.o: In function `rockchip_usb2phy_otg_sm_work':
phy-rockchip-inno-usb2.c:(.text+0x2bcb): undefined reference to `extcon_get_state'
phy-rockchip-inno-usb2.c:(.text+0x2cd4): undefined reference to `extcon_set_state_sync'
phy-rockchip-inno-usb2.c:(.text+0x2cec): undefined reference to `extcon_set_state_sync'
phy-rockchip-inno-usb2.c:(.text+0x2d2d): undefined reference to `extcon_get_state'
drivers/built-in.o: In function `rockchip_usb2phy_probe':
phy-rockchip-inno-usb2.c:(.text+0x31d7): undefined reference to `extcon_get_edev_by_phandle'
phy-rockchip-inno-usb2.c:(.text+0x321a): undefined reference to `devm_extcon_dev_allocate'
phy-rockchip-inno-usb2.c:(.text+0x3230): undefined reference to `devm_extcon_dev_register'
phy-rockchip-inno-usb2.c:(.text+0x375a): undefined reference to `extcon_register_notifier'

Found in linux-next but is also needed in mainline.

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>
Cc: Heiko Stuebner <heiko@sntech.de>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 drivers/phy/Kconfig |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index eff994d..bb5cf6f 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -363,6 +363,7 @@ config PHY_ROCKCHIP_INNO_USB2
 	tristate "Rockchip INNO USB2PHY Driver"
 	depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF
 	depends on COMMON_CLK
+	depends on EXTCON
 	depends on USB_SUPPORT
 	select GENERIC_PHY
 	select USB_COMMON
-- 
1.7.9.5

  parent reply	other threads:[~2017-01-30 11:55 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-30 11:49 [GIT PULL] phy: for 4.11 Kishon Vijay Abraham I
2017-01-30 11:49 ` [PATCH 01/15] phy: rockchip-inno-usb2: Set EXTCON_USB when EXTCON_CHG_USB_SDP was set Kishon Vijay Abraham I
2017-01-30 11:49 ` [PATCH 01/14] phy: sun4i-usb: add support for V3s USB PHY Kishon Vijay Abraham I
2017-01-30 11:49 ` [PATCH 02/14] phy: rcar-gen3-usb2: Replace the deprecated extcon API Kishon Vijay Abraham I
2017-01-30 11:49 ` [PATCH 02/15] phy: sun4i-usb: add support for V3s USB PHY Kishon Vijay Abraham I
2017-01-30 11:49 ` [PATCH 03/15] phy: rcar-gen3-usb2: Replace the deprecated extcon API Kishon Vijay Abraham I
2017-01-30 11:49 ` [PATCH 03/14] phy: sun4i-usb: " Kishon Vijay Abraham I
2017-01-30 11:49 ` [PATCH 04/14] drivers: phy: constify phy_ops structures Kishon Vijay Abraham I
2017-01-30 11:49 ` [PATCH 04/15] phy: sun4i-usb: Replace the deprecated extcon API Kishon Vijay Abraham I
2017-01-30 11:49 ` [PATCH 05/15] drivers: phy: constify phy_ops structures Kishon Vijay Abraham I
2017-01-30 11:49 ` [PATCH 05/14] phy: Add support for Qualcomm's USB HSIC phy Kishon Vijay Abraham I
2017-01-30 11:49 ` [PATCH 06/14] phy: Add support for Qualcomm's USB HS phy Kishon Vijay Abraham I
2017-01-30 11:49 ` [PATCH 06/15] phy: Add support for Qualcomm's USB HSIC phy Kishon Vijay Abraham I
2017-01-30 11:49 ` [PATCH 07/15] phy: Add support for Qualcomm's USB HS phy Kishon Vijay Abraham I
2017-01-30 11:49 ` [PATCH 07/14] phy: qcom-ufs: Don't kfree devres resource Kishon Vijay Abraham I
2017-01-30 11:49 ` [PATCH 08/15] " Kishon Vijay Abraham I
2017-01-30 11:49 ` [PATCH 09/15] phy: qcom-ufs: Correct usage of regulator_get() Kishon Vijay Abraham I
2017-01-30 11:49 ` [PATCH 09/14] phy: qcom-ufs: Remove -always-on property Kishon Vijay Abraham I
2017-01-30 11:49 ` [PATCH 10/15] " Kishon Vijay Abraham I
2017-01-30 11:49 ` [PATCH 10/14] phy: qcom-ufs: Suppress extraneous logging Kishon Vijay Abraham I
2017-01-30 11:49 ` [PATCH 11/14] dt-bindings: phy: Add documentation for NSP USB3 PHY Kishon Vijay Abraham I
2017-01-30 11:49 ` [PATCH 11/15] phy: qcom-ufs: Suppress extraneous logging Kishon Vijay Abraham I
2017-01-30 11:49 ` [PATCH 12/15] dt-bindings: phy: Add documentation for NSP USB3 PHY Kishon Vijay Abraham I
2017-01-30 11:49 ` [PATCH 12/14] phy: Add USB3 PHY support for Broadcom NSP SoC Kishon Vijay Abraham I
2017-01-30 11:49 ` [PATCH 13/15] " Kishon Vijay Abraham I
2017-01-30 11:49 ` Kishon Vijay Abraham I [this message]
2017-01-30 11:49 ` [PATCH 14/15] phy: fix rockchip-inno-usb2 build errors Kishon Vijay Abraham I
2017-01-30 11:49 ` [PATCH 14/14] phy: qcom-ufs: Fix misplaced jump label Kishon Vijay Abraham I
2017-01-30 11:49 ` [PATCH 15/15] " Kishon Vijay Abraham I
2017-01-31  9:53 ` [GIT PULL] phy: for 4.11 Greg KH
2017-01-31 10:03   ` Kishon Vijay Abraham I

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1485776992-8818-27-git-send-email-kishon@ti.com \
    --to=kishon@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome