From: Yuriy Kolerov <yuriy.kolerov@synopsys.com>
To: linux-snps-arc@lists.infradead.org
Cc: Vineet.Gupta1@synopsys.com, Alexey.Brodkin@synopsys.com,
linux-kernel@vger.kernel.org, marc.zyngier@arm.com,
Yuriy Kolerov <yuriy.kolerov@synopsys.com>
Subject: [PATCH v2 4/4] ARCv2: IRQ: Set a default priority for all core interrupts
Date: Tue, 31 Jan 2017 14:45:24 +0300 [thread overview]
Message-ID: <1485863124-26426-5-git-send-email-yuriy.kolerov@synopsys.com> (raw)
In-Reply-To: <1485863124-26426-1-git-send-email-yuriy.kolerov@synopsys.com>
After reset all interrupts in the core interrupt controller has
the highest priority P0. If the platform supports Fast IRQs and
has more than 1 banks of registers then CPU automatically switch
banks of registers when P0 interrupt comes.
The problem is that the kernel expects that by default switching
of banks is not used by all interrupts. It is necessary to set a
default nonzero priority for all available interrupts to avoid
undefined behaviour.
Signed-off-by: Yuriy Kolerov <yuriy.kolerov@synopsys.com>
---
arch/arc/kernel/intc-arcv2.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/arch/arc/kernel/intc-arcv2.c b/arch/arc/kernel/intc-arcv2.c
index 31246cc..d4fa4a5 100644
--- a/arch/arc/kernel/intc-arcv2.c
+++ b/arch/arc/kernel/intc-arcv2.c
@@ -22,7 +22,7 @@
*/
void arc_init_IRQ(void)
{
- unsigned int tmp, irq_prio;
+ unsigned int tmp, irq_prio, i;
struct bcr_irq_arcv2 irq_bcr;
@@ -62,6 +62,16 @@ void arc_init_IRQ(void)
irq_prio + 1, ARCV2_IRQ_DEF_PRIO,
irq_bcr.firq ? " FIRQ (not used)":"");
+ /*
+ * Set a default priority for all available interrupts to prevent
+ * switching of register banks if Fast IRQ and multiple register banks
+ * are supported by CPU.
+ */
+ for (i = NR_EXCEPTIONS; i < irq_bcr.irqs + NR_EXCEPTIONS; i++) {
+ write_aux_reg(AUX_IRQ_SELECT, i);
+ write_aux_reg(AUX_IRQ_PRIORITY, ARCV2_IRQ_DEF_PRIO);
+ }
+
/* setup status32, don't enable intr yet as kernel doesn't want */
tmp = read_aux_reg(ARC_REG_STATUS32);
tmp |= STATUS_AD_MASK | (ARCV2_IRQ_DEF_PRIO << 1);
--
2.7.4
next prev parent reply other threads:[~2017-01-31 11:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 11:45 [PATCH v2 0/4] Use build registers for getting numbers of interrupts Yuriy Kolerov
2017-01-31 11:45 ` [PATCH v2 1/4] ARCv2: IRQ: Move structure for build register of core intc to the header Yuriy Kolerov
2017-01-31 17:40 ` Vineet Gupta
2017-01-31 18:15 ` Vineet Gupta
2017-01-31 11:45 ` [PATCH v2 2/4] ARCv2: IRQ: Remove option for setting number of interrupts Yuriy Kolerov
2017-01-31 17:40 ` Vineet Gupta
2017-01-31 11:45 ` [PATCH v2 3/4] ARCv2: IRQ: Use build registers for getting numbers " Yuriy Kolerov
2017-01-31 17:46 ` Vineet Gupta
2017-01-31 11:45 ` Yuriy Kolerov [this message]
2017-01-31 17:54 ` [PATCH v2 4/4] ARCv2: IRQ: Set a default priority for all core interrupts Vineet Gupta
2017-02-01 12:54 ` Yuriy Kolerov
2017-02-01 20:58 ` [PATCH v2 0/4] Use build registers for getting numbers of interrupts Vineet Gupta
2017-02-01 23:59 ` Yuriy Kolerov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485863124-26426-5-git-send-email-yuriy.kolerov@synopsys.com \
--to=yuriy.kolerov@synopsys.com \
--cc=Alexey.Brodkin@synopsys.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=marc.zyngier@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®