* [PATCH] Staging: arch/x86/kernel/setup.c : fixed empty line style issue
@ 2017-02-11 17:30 Kishore Karanala
2017-02-11 19:53 ` Thomas Gleixner
0 siblings, 1 reply; 2+ messages in thread
From: Kishore Karanala @ 2017-02-11 17:30 UTC (permalink / raw)
To: glx, mingo, hpa, x86, linux-kernel, matt, rafael.j.wysocki,
thgarnie, arbab, dave.hansen
Cc: kishore.karanala
From: Kishore <kishore.karanala@gmail.com>
Fixed empty line style issue
Signed-off-by: Kishore Karanala <kishore.karanala@gmail.com>
---
arch/x86/kernel/setup.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 4cfba94..6d35649 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -723,7 +723,6 @@ static void __init trim_snb_memory(void)
* already been reserved.
*/
memblock_reserve(0, 1<<20);
-
for (i = 0; i < ARRAY_SIZE(bad_pages); i++) {
if (memblock_reserve(bad_pages[i], PAGE_SIZE))
printk(KERN_WARNING "failed to reserve 0x%08lx\n",
@@ -815,7 +814,6 @@ static void __init trim_low_memory_range(void)
{
memblock_reserve(0, ALIGN(reserve_low, PAGE_SIZE));
}
-
/*
* Dump out kernel offset information on panic.
*/
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: arch/x86/kernel/setup.c : fixed empty line style issue
2017-02-11 17:30 [PATCH] Staging: arch/x86/kernel/setup.c : fixed empty line style issue Kishore Karanala
@ 2017-02-11 19:53 ` Thomas Gleixner
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Gleixner @ 2017-02-11 19:53 UTC (permalink / raw)
To: Kishore Karanala
Cc: glx, mingo, hpa, x86, linux-kernel, matt, rafael.j.wysocki,
thgarnie, arbab, dave.hansen
On Sat, 11 Feb 2017, Kishore Karanala wrote:
> From: Kishore <kishore.karanala@gmail.com>
>
> Fixed empty line style issue
What? There is no issue. These empty lines are entirely correct and
removing them is just hurting readability.
Thanks,
tglx
> Signed-off-by: Kishore Karanala <kishore.karanala@gmail.com>
> ---
> arch/x86/kernel/setup.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index 4cfba94..6d35649 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -723,7 +723,6 @@ static void __init trim_snb_memory(void)
> * already been reserved.
> */
> memblock_reserve(0, 1<<20);
> -
> for (i = 0; i < ARRAY_SIZE(bad_pages); i++) {
> if (memblock_reserve(bad_pages[i], PAGE_SIZE))
> printk(KERN_WARNING "failed to reserve 0x%08lx\n",
> @@ -815,7 +814,6 @@ static void __init trim_low_memory_range(void)
> {
> memblock_reserve(0, ALIGN(reserve_low, PAGE_SIZE));
> }
> -
> /*
> * Dump out kernel offset information on panic.
> */
> --
> 2.7.4
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-11 19:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-11 17:30 [PATCH] Staging: arch/x86/kernel/setup.c : fixed empty line style issue Kishore Karanala
2017-02-11 19:53 ` Thomas Gleixner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®