* [PATCH 1/1] [media] cobalt: fix unchecked return values
@ 2017-04-23 12:18 Pan Bian
0 siblings, 0 replies; only message in thread
From: Pan Bian @ 2017-04-23 12:18 UTC (permalink / raw)
To: Hans Verkuil, Mauro Carvalho Chehab, linux-media; +Cc: linux-kernel, Pan Bian
From: Pan Bian <bianpan2016@163.com>
Function pci_find_ext_capability() may return 0, which is an invalid
address. In function cobalt_pcie_status_show(), its return value is used
without validation. This patch adds checks to validate the return
address.
Signed-off-by: Pan Bian <bianpan2016@163.com>
---
drivers/media/pci/cobalt/cobalt-driver.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/pci/cobalt/cobalt-driver.c b/drivers/media/pci/cobalt/cobalt-driver.c
index d5c911c..f8e173f 100644
--- a/drivers/media/pci/cobalt/cobalt-driver.c
+++ b/drivers/media/pci/cobalt/cobalt-driver.c
@@ -205,6 +205,8 @@ void cobalt_pcie_status_show(struct cobalt *cobalt)
offset = pci_find_capability(pci_dev, PCI_CAP_ID_EXP);
bus_offset = pci_find_capability(pci_bus_dev, PCI_CAP_ID_EXP);
+ if (!offset || !bus_offset)
+ return;
/* Device */
pci_read_config_dword(pci_dev, offset + PCI_EXP_DEVCAP, &capa);
--
1.9.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-04-23 12:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-23 12:18 [PATCH 1/1] [media] cobalt: fix unchecked return values Pan Bian
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®