From: Surender Polsani <surenderpolsani@gmail.com>
To: gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Surender Polsani <surenderpolsani@gmail.com>
Subject: [PATCH] staging : rtl8188eu : remove void function return
Date: Wed, 3 May 2017 16:51:14 +0530 [thread overview]
Message-ID: <1493810474-26794-1-git-send-email-surenderpolsani@gmail.com> (raw)
kernel coding style doesn't allow the return statement
in void function.
Signed-off-by: Surender Polsani <surenderpolsani@gmail.com>
---
Changes for v2:
corrected subject line as suggested
Changes for v3:
modified from line as suggested by Greg KH
placed a semicolon in label for fixing build error
Changes for v4:
removed label as suggested by Dan Carpenter
---
drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
index d04b7fb..f3871a5 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
@@ -144,8 +144,8 @@ void rtw_hal_dm_watchdog(struct adapter *Adapter)
hw_init_completed = Adapter->hw_init_completed;
- if (!hw_init_completed)
- goto skip_dm;
+ if (hw_init_completed)
+ {
/* ODM */
pmlmepriv = &Adapter->mlmepriv;
@@ -162,10 +162,9 @@ void rtw_hal_dm_watchdog(struct adapter *Adapter)
Adapter->HalData->odmpriv.bLinked = bLinked;
ODM_DMWatchdog(&Adapter->HalData->odmpriv);
-skip_dm:
+ }
/* Check GPIO to determine current RF on/off and Pbc status. */
/* Check Hardware Radio ON/OFF or not */
- return;
}
void rtw_hal_dm_init(struct adapter *Adapter)
--
1.9.1
next reply other threads:[~2017-05-03 11:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-03 11:21 Surender Polsani [this message]
2017-05-03 11:24 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2017-05-03 5:59 Surender Polsani
2017-05-03 10:46 ` Dan Carpenter
2017-04-21 3:54 surenderpolsani
2017-04-28 10:28 ` Greg KH
2017-04-15 6:27 surenderpolsani
2017-04-18 11:52 ` Greg KH
2017-04-18 12:03 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493810474-26794-1-git-send-email-surenderpolsani@gmail.com \
--to=surenderpolsani@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®