mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Surender Polsani <surenderpolsani@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging : rtl8188eu : remove void function return
Date: Wed, 3 May 2017 13:46:47 +0300	[thread overview]
Message-ID: <20170503104647.lpuoglfgonl7b2qr@mwanda> (raw)
In-Reply-To: <1493791140-3438-1-git-send-email-surenderpolsani@gmail.com>

On Wed, May 03, 2017 at 11:29:00AM +0530, Surender Polsani wrote:
> kernel coding style doesn't allow the return statement
> in void function.
> 
> Signed-off-by: Surender Polsani <surenderpolsani@gmail.com>
> ---
> Changes for v2:
> corrected subject line as suggested
> Changes for v3:
> modified from line as suggested by Greg KH
> placed a semicolon in label for fixing build error
> ---
>  drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
> index d04b7fb..428996e 100644
> --- a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
> +++ b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
> @@ -165,7 +165,7 @@ void rtw_hal_dm_watchdog(struct adapter *Adapter)
>  skip_dm:
>  	/*  Check GPIO to determine current RF on/off and Pbc status. */
>  	/*  Check Hardware Radio ON/OFF or not */
> -	return;
> +	;

Just get rid of the label.

regards,
dan carpenter

  reply	other threads:[~2017-05-03 10:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-03  5:59 Surender Polsani
2017-05-03 10:46 ` Dan Carpenter [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-05-03 11:21 Surender Polsani
2017-05-03 11:24 ` Dan Carpenter
2017-04-21  3:54 surenderpolsani
2017-04-28 10:28 ` Greg KH
2017-04-15  6:27 surenderpolsani
2017-04-18 11:52 ` Greg KH
2017-04-18 12:03   ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170503104647.lpuoglfgonl7b2qr@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=surenderpolsani@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®