* [PATCH 08/11] net: cadence: macb: constify pci_device_id.
@ 2017-07-17 18:11 Arvind Yadav
2017-07-17 20:38 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-07-17 18:11 UTC (permalink / raw)
To: nicolas.ferre, kvalo; +Cc: netdev, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
791 336 0 1127 467 net/ethernet/cadence/macb_pci.o
File size After adding 'const':
text data bss dec hex filename
855 272 0 1127 467 net/ethernet/cadence/macb_pci.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/net/ethernet/cadence/macb_pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/cadence/macb_pci.c b/drivers/net/ethernet/cadence/macb_pci.c
index 9906fda..248a8fc 100644
--- a/drivers/net/ethernet/cadence/macb_pci.c
+++ b/drivers/net/ethernet/cadence/macb_pci.c
@@ -128,7 +128,7 @@ static void macb_remove(struct pci_dev *pdev)
clk_unregister(plat_data->hclk);
}
-static struct pci_device_id dev_id_table[] = {
+static const struct pci_device_id dev_id_table[] = {
{ PCI_DEVICE(CDNS_VENDOR_ID, CDNS_DEVICE_ID), },
{ 0, }
};
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 08/11] net: cadence: macb: constify pci_device_id.
2017-07-17 18:11 [PATCH 08/11] net: cadence: macb: constify pci_device_id Arvind Yadav
@ 2017-07-17 20:38 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-07-17 20:38 UTC (permalink / raw)
To: arvind.yadav.cs; +Cc: nicolas.ferre, kvalo, netdev, linux-kernel
From: Arvind Yadav <arvind.yadav.cs@gmail.com>
Date: Mon, 17 Jul 2017 23:41:52 +0530
> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 791 336 0 1127 467 net/ethernet/cadence/macb_pci.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 855 272 0 1127 467 net/ethernet/cadence/macb_pci.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-17 20:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-17 18:11 [PATCH 08/11] net: cadence: macb: constify pci_device_id Arvind Yadav
2017-07-17 20:38 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®