From: Keerthy <j-keerthy@ti.com>
To: <linus.walleij@linaro.org>, <ssantosh@kernel.org>
Cc: <robh+dt@kernel.org>, <nsekhar@ti.com>, <s-anna@ti.com>,
<fcooper@ti.com>, <linux-gpio@vger.kernel.org>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <j-keerthy@ti.com>
Subject: [PATCH 2/4] gpio: davinci: Handle the return value of davinci_gpio_irq_setup function
Date: Tue, 18 Jul 2017 16:27:14 +0530 [thread overview]
Message-ID: <1500375436-9435-3-git-send-email-j-keerthy@ti.com> (raw)
In-Reply-To: <1500375436-9435-1-git-send-email-j-keerthy@ti.com>
Currently davinci_gpio_irq_setup return value is ignored. Handle the
return value appropriately.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
drivers/gpio/gpio-davinci.c | 18 +++++++++++++-----
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
index 2c88054..932f270 100644
--- a/drivers/gpio/gpio-davinci.c
+++ b/drivers/gpio/gpio-davinci.c
@@ -233,15 +233,23 @@ static int davinci_gpio_probe(struct platform_device *pdev)
chips->regs[bank] = gpio_base + offset_array[bank];
ret = devm_gpiochip_add_data(dev, &chips->chip, chips);
+ if (ret)
+ goto err;
+
+ platform_set_drvdata(pdev, chips);
+ ret = davinci_gpio_irq_setup(pdev);
if (ret) {
- ctrl_num = 0;
- bank_base = 0;
- return ret;
+ platform_set_drvdata(pdev, NULL);
+ goto err;
}
- platform_set_drvdata(pdev, chips);
- davinci_gpio_irq_setup(pdev);
return 0;
+
+err:
+ ctrl_num = 0;
+ bank_base = 0;
+
+ return ret;
}
/*--------------------------------------------------------------------------*/
--
1.9.1
next prev parent reply other threads:[~2017-07-18 10:58 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 10:57 [PATCH 0/4] gpio: davinci: Add keystone-k2g support and few clean ups Keerthy
2017-07-18 10:57 ` [PATCH 1/4] gpio: davinci: Use devm_gpiochip_add_data in place of gpiochip_add_data Keerthy
2017-07-18 16:50 ` Suman Anna
2017-07-18 17:45 ` Keerthy
2017-07-19 9:37 ` Johan Hovold
2017-07-19 9:58 ` Keerthy
2017-07-18 10:57 ` Keerthy [this message]
2017-07-18 16:54 ` [PATCH 2/4] gpio: davinci: Handle the return value of davinci_gpio_irq_setup function Suman Anna
2017-07-18 17:46 ` Keerthy
2017-07-19 11:10 ` Johan Hovold
2017-07-20 6:44 ` Keerthy
2017-07-20 9:10 ` Keerthy
2017-07-20 9:50 ` Johan Hovold
2017-07-20 10:02 ` Keerthy
2017-07-20 10:05 ` Johan Hovold
2017-07-20 10:10 ` Keerthy
2017-07-20 21:34 ` Grygorii Strashko
2017-07-21 3:53 ` Keerthy
2017-07-21 7:46 ` Johan Hovold
2017-07-18 10:57 ` [PATCH 3/4] gpio: davinci: Add a separate compatible for keystone-k2g soc Keerthy
2017-07-18 11:31 ` Sekhar Nori
2017-07-18 17:48 ` Keerthy
2017-07-24 18:24 ` Rob Herring
2017-07-25 3:22 ` Keerthy
2017-07-18 10:57 ` [PATCH 4/4] ARM: dts: keystone-k2g-evm: Add gpio nodes Keerthy
2017-07-18 19:13 ` Suman Anna
2017-07-19 4:06 ` Keerthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500375436-9435-3-git-send-email-j-keerthy@ti.com \
--to=j-keerthy@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=fcooper@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=robh+dt@kernel.org \
--cc=s-anna@ti.com \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®