From: Keerthy <j-keerthy@ti.com>
To: Johan Hovold <johan@kernel.org>
Cc: <linus.walleij@linaro.org>, <ssantosh@kernel.org>,
<devicetree@vger.kernel.org>, <nsekhar@ti.com>,
<linux-kernel@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
<robh+dt@kernel.org>, <linux-arm-kernel@lists.infradead.org>,
<fcooper@ti.com>
Subject: Re: [PATCH 1/4] gpio: davinci: Use devm_gpiochip_add_data in place of gpiochip_add_data
Date: Wed, 19 Jul 2017 15:28:21 +0530 [thread overview]
Message-ID: <32f70ccc-e52e-af86-87ec-f7a243d518b0@ti.com> (raw)
In-Reply-To: <20170719093722.GW29638@localhost>
On Wednesday 19 July 2017 03:07 PM, Johan Hovold wrote:
> On Tue, Jul 18, 2017 at 04:27:13PM +0530, Keerthy wrote:
>> Use the devm version of gpiochip_add_data and pass on the
>> return value. Reset the static variables to 0 before returning.
>
> You need to describe not just what you do, but also why you it. In this
> case, your fixing memory leaks and the gpio chip being left registered
> if this driver is unbound.
Sure i can add more description as mentioned above.
>
> Johan
>
next prev parent reply other threads:[~2017-07-19 9:59 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 10:57 [PATCH 0/4] gpio: davinci: Add keystone-k2g support and few clean ups Keerthy
2017-07-18 10:57 ` [PATCH 1/4] gpio: davinci: Use devm_gpiochip_add_data in place of gpiochip_add_data Keerthy
2017-07-18 16:50 ` Suman Anna
2017-07-18 17:45 ` Keerthy
2017-07-19 9:37 ` Johan Hovold
2017-07-19 9:58 ` Keerthy [this message]
2017-07-18 10:57 ` [PATCH 2/4] gpio: davinci: Handle the return value of davinci_gpio_irq_setup function Keerthy
2017-07-18 16:54 ` Suman Anna
2017-07-18 17:46 ` Keerthy
2017-07-19 11:10 ` Johan Hovold
2017-07-20 6:44 ` Keerthy
2017-07-20 9:10 ` Keerthy
2017-07-20 9:50 ` Johan Hovold
2017-07-20 10:02 ` Keerthy
2017-07-20 10:05 ` Johan Hovold
2017-07-20 10:10 ` Keerthy
2017-07-20 21:34 ` Grygorii Strashko
2017-07-21 3:53 ` Keerthy
2017-07-21 7:46 ` Johan Hovold
2017-07-18 10:57 ` [PATCH 3/4] gpio: davinci: Add a separate compatible for keystone-k2g soc Keerthy
2017-07-18 11:31 ` Sekhar Nori
2017-07-18 17:48 ` Keerthy
2017-07-24 18:24 ` Rob Herring
2017-07-25 3:22 ` Keerthy
2017-07-18 10:57 ` [PATCH 4/4] ARM: dts: keystone-k2g-evm: Add gpio nodes Keerthy
2017-07-18 19:13 ` Suman Anna
2017-07-19 4:06 ` Keerthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32f70ccc-e52e-af86-87ec-f7a243d518b0@ti.com \
--to=j-keerthy@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=fcooper@ti.com \
--cc=johan@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=robh+dt@kernel.org \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®