* [PATCH] staging: lustre: declare fiemap_for_stripe static
@ 2017-08-02 4:19 David Wittman
2017-08-03 17:27 ` James Simmons
0 siblings, 1 reply; 2+ messages in thread
From: David Wittman @ 2017-08-02 4:19 UTC (permalink / raw)
To: oleg.drokin, andreas.dilger, jinshan.xiong, bobijam.xu, gregkh,
john.hammond, di.wang
Cc: lustre-devel, devel, linux-kernel, David Wittman
Declare fiemap_for_stripe as static to fix sparse warnings:
> warning: symbol 'fiemap_for_stripe' was not declared. Should it be
> static?
Signed-off-by: David Wittman <dwittman@gmail.com>
---
drivers/staging/lustre/lustre/lov/lov_object.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/lustre/lustre/lov/lov_object.c b/drivers/staging/lustre/lustre/lov/lov_object.c
index 8fc0bcc..334ecb1 100644
--- a/drivers/staging/lustre/lustre/lov/lov_object.c
+++ b/drivers/staging/lustre/lustre/lov/lov_object.c
@@ -1141,11 +1141,11 @@ struct fiemap_state {
bool fs_enough;
};
-int fiemap_for_stripe(const struct lu_env *env, struct cl_object *obj,
- struct lov_stripe_md *lsm,
- struct fiemap *fiemap, size_t *buflen,
- struct ll_fiemap_info_key *fmkey, int stripeno,
- struct fiemap_state *fs)
+static int fiemap_for_stripe(const struct lu_env *env, struct cl_object *obj,
+ struct lov_stripe_md *lsm,
+ struct fiemap *fiemap, size_t *buflen,
+ struct ll_fiemap_info_key *fmkey, int stripeno,
+ struct fiemap_state *fs)
{
struct cl_object *subobj;
struct lov_obd *lov = lu2lov_dev(obj->co_lu.lo_dev)->ld_lov;
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: lustre: declare fiemap_for_stripe static
2017-08-02 4:19 [PATCH] staging: lustre: declare fiemap_for_stripe static David Wittman
@ 2017-08-03 17:27 ` James Simmons
0 siblings, 0 replies; 2+ messages in thread
From: James Simmons @ 2017-08-03 17:27 UTC (permalink / raw)
To: David Wittman
Cc: oleg.drokin, andreas.dilger, jinshan.xiong, bobijam.xu, gregkh,
john.hammond, di.wang, devel, linux-kernel, lustre-devel
> Declare fiemap_for_stripe as static to fix sparse warnings:
>
> > warning: symbol 'fiemap_for_stripe' was not declared. Should it be
> > static?
Acked-by: James Simmons <jsimmons@infradead.org>
> Signed-off-by: David Wittman <dwittman@gmail.com>
> ---
> drivers/staging/lustre/lustre/lov/lov_object.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/lov/lov_object.c b/drivers/staging/lustre/lustre/lov/lov_object.c
> index 8fc0bcc..334ecb1 100644
> --- a/drivers/staging/lustre/lustre/lov/lov_object.c
> +++ b/drivers/staging/lustre/lustre/lov/lov_object.c
> @@ -1141,11 +1141,11 @@ struct fiemap_state {
> bool fs_enough;
> };
>
> -int fiemap_for_stripe(const struct lu_env *env, struct cl_object *obj,
> - struct lov_stripe_md *lsm,
> - struct fiemap *fiemap, size_t *buflen,
> - struct ll_fiemap_info_key *fmkey, int stripeno,
> - struct fiemap_state *fs)
> +static int fiemap_for_stripe(const struct lu_env *env, struct cl_object *obj,
> + struct lov_stripe_md *lsm,
> + struct fiemap *fiemap, size_t *buflen,
> + struct ll_fiemap_info_key *fmkey, int stripeno,
> + struct fiemap_state *fs)
> {
> struct cl_object *subobj;
> struct lov_obd *lov = lu2lov_dev(obj->co_lu.lo_dev)->ld_lov;
> --
> 2.7.4
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-03 17:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-02 4:19 [PATCH] staging: lustre: declare fiemap_for_stripe static David Wittman
2017-08-03 17:27 ` James Simmons
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome