From: Kees Cook <keescook@chromium.org>
To: linux-kernel@vger.kernel.org
Cc: Kees Cook <keescook@chromium.org>,
Nick Kralevich <nnk@google.com>, Sebastian Schmidt <yath@yath.de>,
Tony Luck <tony.luck@intel.com>,
Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>, Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Patrick Tjin <pattjin@google.com>,
Mark Salyzyn <salyzyn@google.com>
Subject: [PATCH 1/2] pstore: Make default pstorefs root dir perms 0750
Date: Thu, 10 Aug 2017 13:36:34 -0700 [thread overview]
Message-ID: <1502397395-118652-2-git-send-email-keescook@chromium.org> (raw)
In-Reply-To: <1502397395-118652-1-git-send-email-keescook@chromium.org>
Currently only DMESG and CONSOLE record types are protected, and it isn't
obvious that they are using a capability check. Instead switch to explicit
root directory mode of 0750 to keep files private by default. This will
allow the removal of the capability check, which was non-obvious and
forces a process to have possibly too much privilege when simple post-boot
chgrp for readers would be possible without it.
Signed-off-by: Kees Cook <keescook@chromium.org>
---
fs/pstore/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/pstore/inode.c b/fs/pstore/inode.c
index fefd22611cf6..f1e88b695090 100644
--- a/fs/pstore/inode.c
+++ b/fs/pstore/inode.c
@@ -471,7 +471,7 @@ static int pstore_fill_super(struct super_block *sb, void *data, int silent)
inode = pstore_get_inode(sb);
if (inode) {
- inode->i_mode = S_IFDIR | 0755;
+ inode->i_mode = S_IFDIR | 0750;
inode->i_op = &pstore_dir_inode_operations;
inode->i_fop = &simple_dir_operations;
inc_nlink(inode);
--
2.7.4
next prev parent reply other threads:[~2017-08-10 20:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-10 20:36 [PATCH 0/2] " Kees Cook
2017-08-10 20:36 ` Kees Cook [this message]
2017-08-16 8:05 ` [PATCH 1/2] " Sergey Senozhatsky
2017-08-10 20:36 ` [PATCH 2/2] Revert "pstore: Honor dmesg_restrict sysctl on dmesg dumps" Kees Cook
2017-08-15 11:55 ` Petr Mladek
2017-08-15 19:01 ` Kees Cook
2017-08-16 0:21 ` Steven Rostedt
2017-08-16 0:29 ` Kees Cook
2017-08-16 0:35 ` Steven Rostedt
2017-08-16 7:59 ` Sergey Senozhatsky
2017-08-16 15:38 ` Kees Cook
2017-08-17 1:29 ` Sergey Senozhatsky
2017-08-17 23:01 ` Kees Cook
2017-08-17 23:24 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502397395-118652-2-git-send-email-keescook@chromium.org \
--to=keescook@chromium.org \
--cc=anton@enomsg.org \
--cc=ccross@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nnk@google.com \
--cc=pattjin@google.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=salyzyn@google.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=tony.luck@intel.com \
--cc=yath@yath.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®