From: Petr Mladek <pmladek@suse.com>
To: Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org, Nick Kralevich <nnk@google.com>,
Sebastian Schmidt <yath@yath.de>, Tony Luck <tony.luck@intel.com>,
Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Patrick Tjin <pattjin@google.com>,
Mark Salyzyn <salyzyn@google.com>
Subject: Re: [PATCH 2/2] Revert "pstore: Honor dmesg_restrict sysctl on dmesg dumps"
Date: Tue, 15 Aug 2017 13:55:13 +0200 [thread overview]
Message-ID: <20170815115513.GB2738@pathway.suse.cz> (raw)
In-Reply-To: <1502397395-118652-3-git-send-email-keescook@chromium.org>
On Thu 2017-08-10 13:36:35, Kees Cook wrote:
> This reverts commit 68c4a4f8abc60c9440ede9cd123d48b78325f7a3, with
> various conflict clean-ups.
>
> With the default root directory mode set to 0750 now, the capability
> check was redundant.
>
> Suggested-by: Nick Kralevich <nnk@google.com>
> Signed-off-by: Kees Cook <keescook@chromium.org>
The patch looks correct from the code side. I looked at
it because it touched printk.c. Note that I am not
security expert.
Reviewed-by: Petr Mladek <pmladek@suse.cz>
Best Regards,
Petr
next prev parent reply other threads:[~2017-08-15 11:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-10 20:36 [PATCH 0/2] pstore: Make default pstorefs root dir perms 0750 Kees Cook
2017-08-10 20:36 ` [PATCH 1/2] " Kees Cook
2017-08-16 8:05 ` Sergey Senozhatsky
2017-08-10 20:36 ` [PATCH 2/2] Revert "pstore: Honor dmesg_restrict sysctl on dmesg dumps" Kees Cook
2017-08-15 11:55 ` Petr Mladek [this message]
2017-08-15 19:01 ` Kees Cook
2017-08-16 0:21 ` Steven Rostedt
2017-08-16 0:29 ` Kees Cook
2017-08-16 0:35 ` Steven Rostedt
2017-08-16 7:59 ` Sergey Senozhatsky
2017-08-16 15:38 ` Kees Cook
2017-08-17 1:29 ` Sergey Senozhatsky
2017-08-17 23:01 ` Kees Cook
2017-08-17 23:24 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170815115513.GB2738@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=anton@enomsg.org \
--cc=ccross@android.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nnk@google.com \
--cc=pattjin@google.com \
--cc=rostedt@goodmis.org \
--cc=salyzyn@google.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=tony.luck@intel.com \
--cc=yath@yath.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®