mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Kees Cook <keescook@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Nick Kralevich <nnk@google.com>, Sebastian Schmidt <yath@yath.de>,
	Tony Luck <tony.luck@intel.com>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Petr Mladek <pmladek@suse.com>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Patrick Tjin <pattjin@google.com>,
	Mark Salyzyn <salyzyn@google.com>
Subject: Re: [PATCH 2/2] Revert "pstore: Honor dmesg_restrict sysctl on dmesg dumps"
Date: Tue, 15 Aug 2017 20:35:19 -0400	[thread overview]
Message-ID: <20170815203519.587fb1d7@gandalf.local.home> (raw)
In-Reply-To: <CAGXu5jLtJt1=t7242gU22yf39p-96G+DhLspKEcAgA3q5AFxvQ@mail.gmail.com>

On Tue, 15 Aug 2017 17:29:38 -0700
Kees Cook <keescook@chromium.org> wrote:

> On Tue, Aug 15, 2017 at 5:21 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> > On Thu, 10 Aug 2017 13:36:35 -0700
> > Kees Cook <keescook@chromium.org> wrote:
> >  
> >> This reverts commit 68c4a4f8abc60c9440ede9cd123d48b78325f7a3, with
> >> various conflict clean-ups.
> >>
> >> With the default root directory mode set to 0750 now, the capability
> >> check was redundant.  
> >
> > What's wrong with redundancy?  
> 
> In this case, it actually _blocks_ system builders from being able to
> define the access controls on pstore. :(

Then that should be stated in the change log, as it is the real reason
to revert, not just the fact that it is redundant.

Thanks,

-- Steve

  reply	other threads:[~2017-08-16  0:35 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-10 20:36 [PATCH 0/2] pstore: Make default pstorefs root dir perms 0750 Kees Cook
2017-08-10 20:36 ` [PATCH 1/2] " Kees Cook
2017-08-16  8:05   ` Sergey Senozhatsky
2017-08-10 20:36 ` [PATCH 2/2] Revert "pstore: Honor dmesg_restrict sysctl on dmesg dumps" Kees Cook
2017-08-15 11:55   ` Petr Mladek
2017-08-15 19:01     ` Kees Cook
2017-08-16  0:21   ` Steven Rostedt
2017-08-16  0:29     ` Kees Cook
2017-08-16  0:35       ` Steven Rostedt [this message]
2017-08-16  7:59   ` Sergey Senozhatsky
2017-08-16 15:38     ` Kees Cook
2017-08-17  1:29       ` Sergey Senozhatsky
2017-08-17 23:01         ` Kees Cook
2017-08-17 23:24           ` Sergey Senozhatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170815203519.587fb1d7@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=anton@enomsg.org \
    --cc=ccross@android.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nnk@google.com \
    --cc=pattjin@google.com \
    --cc=pmladek@suse.com \
    --cc=salyzyn@google.com \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=tony.luck@intel.com \
    --cc=yath@yath.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®