mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: linux-kernel@vger.kernel.org
Cc: Bard Liao <bardliao@realtek.com>,
	Oder Chiou <oder_chiou@realtek.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	alsa-devel@alsa-project.org,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Mark Brown <broonie@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs
Date: Tue, 22 Aug 2017 21:51:46 -0400	[thread overview]
Message-ID: <1503453106-5564-1-git-send-email-trini@konsulko.com> (raw)

Not all devices with ACPI and this combination of sound devices will
have the required information provided via ACPI.  Reintroduce the I2C
device ID to restore sound functionality on on the Chromebook 'Samus'
model.

Fixes: a36afb0ab648 ("ASoC: rt5677: Introduce proper table for ACPI enumeration")
Cc: Bard Liao <bardliao@realtek.com>
Cc: Oder Chiou <oder_chiou@realtek.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.com>
Cc: alsa-devel@alsa-project.org
CC: linux-kernel@vger.kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Tom Rini <trini@konsulko.com>
---
This is a regression from v4.12 on my laptop (a Chromebook 'Samus'
that's not running ChromeOS).  My fault for getting out of the habit of
trying -rc1 when it comes out and not spotting this sooner.  I'm not
100% sure if this fix is correct for all cases as I'm only able to test
my hardware here, and this does fix my laptop.
---
 sound/soc/codecs/rt5677.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c
index 36e530a36c82..6f629278d982 100644
--- a/sound/soc/codecs/rt5677.c
+++ b/sound/soc/codecs/rt5677.c
@@ -5021,6 +5021,7 @@ static int rt5677_write(void *context, unsigned int reg, unsigned int val)
 static const struct i2c_device_id rt5677_i2c_id[] = {
 	{ "rt5677", RT5677 },
 	{ "rt5676", RT5676 },
+	{ "RT5677CE:00", RT5677 },
 	{ }
 };
 MODULE_DEVICE_TABLE(i2c, rt5677_i2c_id);
-- 
1.9.1

             reply	other threads:[~2017-08-23  1:52 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-23  1:51 Tom Rini [this message]
2017-08-23  9:28 ` Mark Brown
2017-08-23 22:35   ` Tom Rini
2017-08-23 22:47     ` Mark Brown
2017-08-23 22:54       ` Tom Rini
2017-08-23 23:15         ` Mark Brown
2017-08-23 23:02       ` Mark Brown
2017-08-23 14:29 ` Andy Shevchenko
2017-08-23 17:39   ` Tom Rini
2017-08-24  0:05     ` Tom Rini
2017-08-24  7:39       ` Andy Shevchenko
2017-08-24 11:15         ` Tom Rini
2017-08-24 12:26           ` Andy Shevchenko
2017-08-24 13:41             ` Mark Brown
2017-08-24 13:47             ` Tom Rini
2017-08-24 14:28       ` [alsa-devel] " Takashi Iwai
2017-08-24 14:31         ` Takashi Iwai
2017-08-24 14:41           ` Tom Rini
2017-08-24 15:42             ` Takashi Iwai
2017-08-24 15:52               ` Mark Brown
2017-08-24 15:54                 ` Takashi Iwai
2017-08-24 15:54                 ` Tom Rini
2017-08-24 16:06                   ` Takashi Iwai
2017-08-24 16:08                     ` Tom Rini
2017-08-24 17:16                     ` Andy Shevchenko
2017-08-24 17:44                       ` Takashi Iwai
2017-08-25 13:48                         ` Mark Brown
2017-08-25 13:09                     ` Mark Brown
2017-08-25 13:17                       ` Takashi Iwai
2017-08-25 13:56 ` Andy Shevchenko
2017-08-25 14:24   ` Tom Rini
2017-08-25 14:49     ` Andy Shevchenko
2017-08-25 16:05     ` John Keeping
2017-08-25 16:42       ` Andy Shevchenko
2017-08-25 17:09         ` John Keeping
2017-08-25 19:33         ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1503453106-5564-1-git-send-email-trini@konsulko.com \
    --to=trini@konsulko.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bardliao@realtek.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oder_chiou@realtek.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome