Re: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 2272 bytes --]

On Thu, Aug 24, 2017 at 10:39:09AM +0300, Andy Shevchenko wrote:
> On Wed, 2017-08-23 at 20:05 -0400, Tom Rini wrote:
> > On Wed, Aug 23, 2017 at 01:39:12PM -0400, Tom Rini wrote:
> > > On Wed, Aug 23, 2017 at 05:29:33PM +0300, Andy Shevchenko wrote:
> > > 
> > > > On Tue, 2017-08-22 at 21:51 -0400, Tom Rini wrote:
> > > > > Not all devices with ACPI and this combination of sound devices
> > > > > will
> > > > > have the required information provided via ACPI.  Reintroduce
> > > > > the I2C
> > > > > device ID to restore sound functionality on on the Chromebook
> > > > > 'Samus'
> > > > > model.
> > > > > This is a regression from v4.12 on my laptop (a Chromebook
> > > > > 'Samus'
> > > > > that's not running ChromeOS).  My fault for getting out of the
> > > > > habit
> > > > > of
> > > > > trying -rc1 when it comes out and not spotting this sooner.  I'm
> > > > > not
> > > > > 100% sure if this fix is correct for all cases as I'm only able
> > > > > to
> > > > > test
> > > > > my hardware here, and this does fix my laptop.
> > > > 
> > > > Are you sure the commit ddc9e69b9dc2 ("ASoC: rt5677: Hide platform
> > > > data
> > > > in the module sources") does not fix your issue?
> > > 
> > > As that's not in master yet I can't tell.  Can you give me a pointer
> > > to
> > > somewhere?
> 
> It's in ASoC next at least.
> 
> > >   Thanks!
> > 
> > OK, my bad, it has a different hash upstream, but no, that change
> > doesn't fix things as I see the problem on top of Linus'
> > tree.  Thanks!
> 
> Interesting...
> 
> The only bug so far I saw is the following one
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=196397
> 
> ...and above commit fixes it.
> 
> Can you place somewhere the bundle of the following:
> 
> 1. Output file (tables.dat) of
> 	% acpidump -o tables.dat

https://gist.github.com/trini/b9a9a547e37cb812506a22e18cd2aff5

> 2. Output of
> 	% cat /proc/interrupts

https://gist.github.com/trini/39a5d88a5ecb9b71336ff5fe9da7c720

> 3. Output of
> 	% lspci -vv -xx

https://gist.github.com/trini/e81ab21909eeaa05ea50dc0596d23c14

> 4. Output of
> 	% grep -H 15 /sys/bus/acpi/devices/*/status

https://gist.github.com/trini/698dc284634ad9e1cfbafad8e705de5f

-- 
Tom

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]