* [PATCH] btrfs: Clean up dead code in root-tree
@ 2017-09-09 14:29 Christos Gkekas
2017-09-11 17:06 ` David Sterba
0 siblings, 1 reply; 2+ messages in thread
From: Christos Gkekas @ 2017-09-09 14:29 UTC (permalink / raw)
To: Chris Mason, Josef Bacik, David Sterba, linux-btrfs, linux-kernel
Cc: Christos Gkekas
The value of variable 'can_recover' is never used after being set, thus
it should be removed.
Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
---
fs/btrfs/root-tree.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/fs/btrfs/root-tree.c b/fs/btrfs/root-tree.c
index 95bcc3c..3338407 100644
--- a/fs/btrfs/root-tree.c
+++ b/fs/btrfs/root-tree.c
@@ -226,10 +226,6 @@ int btrfs_find_orphan_roots(struct btrfs_fs_info *fs_info)
struct btrfs_root *root;
int err = 0;
int ret;
- bool can_recover = true;
-
- if (sb_rdonly(fs_info->sb))
- can_recover = false;
path = btrfs_alloc_path();
if (!path)
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] btrfs: Clean up dead code in root-tree
2017-09-09 14:29 [PATCH] btrfs: Clean up dead code in root-tree Christos Gkekas
@ 2017-09-11 17:06 ` David Sterba
0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2017-09-11 17:06 UTC (permalink / raw)
To: Christos Gkekas
Cc: Chris Mason, Josef Bacik, David Sterba, linux-btrfs, linux-kernel
On Sat, Sep 09, 2017 at 03:29:34PM +0100, Christos Gkekas wrote:
> The value of variable 'can_recover' is never used after being set, thus
> it should be removed.
Seems it has never been used since introduction in commit
68a7342c51c95042 .
Reviewed-by: David Sterba <dsterba@suse.com>
>
> Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
> ---
> fs/btrfs/root-tree.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/fs/btrfs/root-tree.c b/fs/btrfs/root-tree.c
> index 95bcc3c..3338407 100644
> --- a/fs/btrfs/root-tree.c
> +++ b/fs/btrfs/root-tree.c
> @@ -226,10 +226,6 @@ int btrfs_find_orphan_roots(struct btrfs_fs_info *fs_info)
> struct btrfs_root *root;
> int err = 0;
> int ret;
> - bool can_recover = true;
> -
> - if (sb_rdonly(fs_info->sb))
> - can_recover = false;
>
> path = btrfs_alloc_path();
> if (!path)
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-11 17:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-09 14:29 [PATCH] btrfs: Clean up dead code in root-tree Christos Gkekas
2017-09-11 17:06 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®