mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "subhashj@codeaurora.org" <subhashj@codeaurora.org>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
	"vinholikatti@gmail.com" <vinholikatti@gmail.com>
Subject: Re: [PATCH 1/3] scsi: ufs: Change HCI marco to actual bit position
Date: Mon, 2 Oct 2017 16:41:34 +0000	[thread overview]
Message-ID: <1506962493.3368.35.camel@wdc.com> (raw)
In-Reply-To: <1506752526-27014-1-git-send-email-alim.akhtar@samsung.com>

On Sat, 2017-09-30 at 11:52 +0530, Alim Akhtar wrote:
> Currently UFS HCI uses UFS_BIT() macro to get various bit
> position for the hardware registers status bits. Which makes
> code longer instead of shorter. This macro does not improve
> code readability as well.
> Lets re-write these macro definition with the actual bit position.

Can the three patches in this series be combined into a single patch?

> -#define UFS_BIT(x)	(1L << (x))
> [ ... ]
> +#define UFS_BIT(x)     (1L << (x))

If you want to keep the three patches separate, please make sure that this
patch does not modify the UFS_BIT() definition. Please also fix the spelling
of the title of this patch (marco -> macro).

Thanks,

Bart.

  parent reply	other threads:[~2017-10-02 16:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170930062956epcas1p1461ea07e21a275a9e5733b3b90b5896a@epcas1p1.samsung.com>
2017-09-30  6:22 ` Alim Akhtar
     [not found]   ` <CGME20170930062957epcas2p3ccba5b5b7614eed0e63b7a8424531022@epcas2p3.samsung.com>
2017-09-30  6:22     ` [PATCH 2/3] scsi: ufs-qcom: Remove uses of UFS_BIT() macro Alim Akhtar
     [not found]   ` <CGME20170930062958epcas2p281a91f030037be81ef81c657ec6f81b2@epcas2p2.samsung.com>
2017-09-30  6:22     ` [PATCH 3/3] scsi: ufs: Remove unused " Alim Akhtar
2017-10-02 16:41   ` Bart Van Assche [this message]
2017-10-03  8:28     ` [PATCH 1/3] scsi: ufs: Change HCI marco to actual bit position Alim Akhtar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1506962493.3368.35.camel@wdc.com \
    --to=bart.vanassche@wdc.com \
    --cc=alim.akhtar@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=subhashj@codeaurora.org \
    --cc=vinholikatti@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®