mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com,
	akpm@linux-foundation.org, mathieu.desnoyers@efficios.com,
	josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org,
	rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com,
	fweisbec@gmail.com, oleg@redhat.com,
	"Guilherme G. Piccoli" <gpiccoli@linux.vnet.ibm.com>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: [PATCH tip/core/rcu 16/16] Documentation: rewrite confusing statement about memory barriers
Date: Wed,  4 Oct 2017 14:21:26 -0700	[thread overview]
Message-ID: <1507152086-9791-16-git-send-email-paulmck@linux.vnet.ibm.com> (raw)
In-Reply-To: <20171004212051.GA8411@linux.vnet.ibm.com>

From: "Guilherme G. Piccoli" <gpiccoli@linux.vnet.ibm.com>

In this specific portion of the write memory barriers description,
the documentation mentions sequential order of stores, which is
confusing since sequential ordering is not guaranteed.

This patch tries to improve the doc in order to avoid any
mis-understanding.

Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Guilherme G. Piccoli <gpiccoli@linux.vnet.ibm.com>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
---
 Documentation/memory-barriers.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/memory-barriers.txt b/Documentation/memory-barriers.txt
index f37375544d71..519940ec767f 100644
--- a/Documentation/memory-barriers.txt
+++ b/Documentation/memory-barriers.txt
@@ -383,8 +383,8 @@ Memory barriers come in four basic varieties:
      to have any effect on loads.
 
      A CPU can be viewed as committing a sequence of store operations to the
-     memory system as time progresses.  All stores before a write barrier will
-     occur in the sequence _before_ all the stores after the write barrier.
+     memory system as time progresses.  All stores _before_ a write barrier
+     will occur _before_ all the stores after the write barrier.
 
      [!] Note that write barriers should normally be paired with read or data
      dependency barriers; see the "SMP barrier pairing" subsection.
-- 
2.5.2

      parent reply	other threads:[~2017-10-04 21:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-04 21:20 [PATCH tip/core/rcu 0/16] Documentation updates for v4.15 Paul E. McKenney
2017-10-04 21:21 ` [PATCH tip/core/rcu 01/16] documentation: RCU grace-period memory ordering guarantees Paul E. McKenney
2017-10-04 21:21 ` [PATCH tip/core/rcu 02/16] documentation: Long-running irq handlers can stall RCU grace periods Paul E. McKenney
2017-10-04 21:21 ` [PATCH tip/core/rcu 03/16] documentation: Slow systems " Paul E. McKenney
2017-10-04 21:21 ` [PATCH tip/core/rcu 04/16] documentation: Update RCU CPU stall warning messages Paul E. McKenney
2017-10-04 21:21 ` [PATCH tip/core/rcu 05/16] memory-barriers: Replace uses of "transitive" Paul E. McKenney
2017-10-04 21:21 ` [PATCH tip/core/rcu 06/16] memory-barriers: Rework multicopy-atomicity section Paul E. McKenney
2017-10-04 21:21 ` [PATCH tip/core/rcu 07/16] doc: Fix options for RCU options Paul E. McKenney
2017-10-04 21:21 ` [PATCH tip/core/rcu 08/16] doc: Add parameters to rcupdate.h docbook comments Paul E. McKenney
2017-10-04 21:21 ` [PATCH tip/core/rcu 09/16] rcu: Remove extra docbook comment in rculist.h Paul E. McKenney
2017-10-04 21:21 ` [PATCH tip/core/rcu 10/16] rcu: Fix docbook comments for rcu_sync functions Paul E. McKenney
2017-10-04 21:21 ` [PATCH tip/core/rcu 11/16] doc: Fix list and emphasis in rcupdate.h Paul E. McKenney
2017-10-04 21:21 ` [PATCH tip/core/rcu 12/16] doc: Flag code segment in rcu_pointer_handoff()'s docbook header Paul E. McKenney
2017-10-04 21:21 ` [PATCH tip/core/rcu 13/16] doc: Fix code display in rcu_pointer_handoff()'s docbook comment Paul E. McKenney
2017-10-04 21:21 ` [PATCH tip/core/rcu 14/16] doc: Fix tree.c bulleted lists in docbook comment headers Paul E. McKenney
2017-10-04 21:21 ` [PATCH tip/core/rcu 15/16] memory-barriers.txt: Fix typo in pairing example Paul E. McKenney
2017-10-04 21:21 ` Paul E. McKenney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1507152086-9791-16-git-send-email-paulmck@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=dipankar@in.ibm.com \
    --cc=edumazet@google.com \
    --cc=fweisbec@gmail.com \
    --cc=gpiccoli@linux.vnet.ibm.com \
    --cc=jiangshanlai@gmail.com \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mingo@kernel.org \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®