[PATCH] selftests: ftrace: add more config fragments

[PATCH] selftests: ftrace: add more config fragments

[lei.yang]

From: Lei Yang <Lei.Yang@windriver.com>

We need to enable more configs to make test more
without this patch,we got lots of "UNSUPPORTED"

before the patch:
http://pastebin.ubuntu.com/25784377/
after the patch:
http://pastebin.ubuntu.com/25784387/

Signed-off-by: Lei Yang <Lei.Yang@windriver.com>
---
 tools/testing/selftests/ftrace/config | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tools/testing/selftests/ftrace/config b/tools/testing/selftests/ftrace/config
index 8a1c9f9..b01924c 100644
--- a/tools/testing/selftests/ftrace/config
+++ b/tools/testing/selftests/ftrace/config
@@ -1,2 +1,6 @@
 CONFIG_KPROBES=y
 CONFIG_FTRACE=y
+CONFIG_FUNCTION_PROFILER=y
+CONFIG_TRACER_SNAPSHOT=y
+CONFIG_STACK_TRACER=y
+CONFIG_HIST_TRIGGERS=y
-- 
1.9.1

Re: [PATCH] selftests: ftrace: add more config fragments

[Shuah Khan]

On 10/21/2017 04:17 AM, lei.yang@windriver.com wrote:
> From: Lei Yang <Lei.Yang@windriver.com>
> 
> We need to enable more configs to make test more
> without this patch,we got lots of "UNSUPPORTED"
> 
> before the patch:
> http://pastebin.ubuntu.com/25784377/
> after the patch:
> http://pastebin.ubuntu.com/25784387/
> 
> Signed-off-by: Lei Yang <Lei.Yang@windriver.com>
> ---
>  tools/testing/selftests/ftrace/config | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tools/testing/selftests/ftrace/config b/tools/testing/selftests/ftrace/config
> index 8a1c9f9..b01924c 100644
> --- a/tools/testing/selftests/ftrace/config
> +++ b/tools/testing/selftests/ftrace/config
> @@ -1,2 +1,6 @@
>  CONFIG_KPROBES=y
>  CONFIG_FTRACE=y
> +CONFIG_FUNCTION_PROFILER=y
> +CONFIG_TRACER_SNAPSHOT=y
> +CONFIG_STACK_TRACER=y
> +CONFIG_HIST_TRIGGERS=y
> 

Hi Steve/Masami,

Are you good with this change. Please give me an Ack.

thanks,
-- Shuah

Re: [PATCH] selftests: ftrace: add more config fragments

[lyang0]

On 2017年11月02日 06:06, Shuah Khan wrote:
> On 10/21/2017 04:17 AM, lei.yang@windriver.com wrote:
>> From: Lei Yang <Lei.Yang@windriver.com>
>>
>> We need to enable more configs to make test more
>> without this patch,we got lots of "UNSUPPORTED"
>>
>> before the patch:
>> http://pastebin.ubuntu.com/25784377/
>> after the patch:
>> http://pastebin.ubuntu.com/25784387/
>>
>> Signed-off-by: Lei Yang <Lei.Yang@windriver.com>
>> ---
>>   tools/testing/selftests/ftrace/config | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/tools/testing/selftests/ftrace/config b/tools/testing/selftests/ftrace/config
>> index 8a1c9f9..b01924c 100644
>> --- a/tools/testing/selftests/ftrace/config
>> +++ b/tools/testing/selftests/ftrace/config
>> @@ -1,2 +1,6 @@
>>   CONFIG_KPROBES=y
>>   CONFIG_FTRACE=y
>> +CONFIG_FUNCTION_PROFILER=y
>> +CONFIG_TRACER_SNAPSHOT=y
>> +CONFIG_STACK_TRACER=y
>> +CONFIG_HIST_TRIGGERS=y
>>
> Hi Steve/Masami,
>
> Are you good with this change. Please give me an Ack.

Hi,

any comments ?

Lei

> thanks,
> -- Shuah

Re: [PATCH] selftests: ftrace: add more config fragments

[Steven Rostedt]

On Fri, 3 Nov 2017 15:23:56 +0800
lyang0 <lei.yang@windriver.com> wrote:


> >> diff --git a/tools/testing/selftests/ftrace/config b/tools/testing/selftests/ftrace/config
> >> index 8a1c9f9..b01924c 100644
> >> --- a/tools/testing/selftests/ftrace/config
> >> +++ b/tools/testing/selftests/ftrace/config
> >> @@ -1,2 +1,6 @@
> >>   CONFIG_KPROBES=y
> >>   CONFIG_FTRACE=y
> >> +CONFIG_FUNCTION_PROFILER=y
> >> +CONFIG_TRACER_SNAPSHOT=y
> >> +CONFIG_STACK_TRACER=y
> >> +CONFIG_HIST_TRIGGERS=y
> >>  
> > Hi Steve/Masami,
> >
> > Are you good with this change. Please give me an Ack.  
> 
> Hi,
> 
> any comments ?

You should have Cc'd me in the first email. Thanks to Shuah for
pointing it out to us.

Anyway, I'm fine with it.

Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

-- Steve

Re: [PATCH] selftests: ftrace: add more config fragments

[Shuah Khan]

On 11/03/2017 07:13 AM, Steven Rostedt wrote:
> On Fri, 3 Nov 2017 15:23:56 +0800
> lyang0 <lei.yang@windriver.com> wrote:
> 
> 
>>>> diff --git a/tools/testing/selftests/ftrace/config b/tools/testing/selftests/ftrace/config
>>>> index 8a1c9f9..b01924c 100644
>>>> --- a/tools/testing/selftests/ftrace/config
>>>> +++ b/tools/testing/selftests/ftrace/config
>>>> @@ -1,2 +1,6 @@
>>>>   CONFIG_KPROBES=y
>>>>   CONFIG_FTRACE=y
>>>> +CONFIG_FUNCTION_PROFILER=y
>>>> +CONFIG_TRACER_SNAPSHOT=y
>>>> +CONFIG_STACK_TRACER=y
>>>> +CONFIG_HIST_TRIGGERS=y
>>>>  
>>> Hi Steve/Masami,
>>>
>>> Are you good with this change. Please give me an Ack.  
>>
>> Hi,
>>
>> any comments ?
> 
> You should have Cc'd me in the first email. Thanks to Shuah for
> pointing it out to us.
> 
> Anyway, I'm fine with it.
> 
> Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> 

Thanks Steve. I will get this into linux-kselftest 4.15-rc1

Lei,

Please do the following when you send your future patches:

Not stating the obvious, make sure to test and include what does
this patch fix in your commit log.

1. Run scripts/checkpatch.pl
2. Run scripts/get_maintainer.pl
3. Please give us at least a week before pinging us. We have all
   been traveling all of last week and going through out Inboxes.

Please refer to Documentation/process/submitting-patches.rst
for details on how to send patches.

btw for this patch if you ran scripts/get_maintainer.pl, you would
have seen the correct list to send the patch to in the first place,
which would have made it easier.

Steven Rostedt <rostedt@goodmis.org> (maintainer:TRACING)
Ingo Molnar <mingo@redhat.com> (maintainer:TRACING)
Shuah Khan <shuah@kernel.org> (maintainer:KERNEL SELFTEST FRAMEWORK)
linux-kselftest@vger.kernel.org (open list:KERNEL SELFTEST FRAMEWORK)
linux-kernel@vger.kernel.org (open list)

thanks,
-- Shuah