mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Prasad Sodagudi <psodagud@codeaurora.org>
To: tglx@linutronix.de, mingo@kernel.org, viresh.kumar@linaro.org
Cc: psodagud@codeaurora.org, linux-kernel@vger.kernel.org
Subject: [PATCH] clockevents: Update clockevents device next_event
Date: Thu, 26 Oct 2017 11:37:22 -0700	[thread overview]
Message-ID: <1509043042-32486-1-git-send-email-psodagud@codeaurora.org> (raw)
In-Reply-To: <alpine.DEB.2.20.1710241212080.2369@nanos>

Usually clockevent device's next_event is updated in
clockevents_program_event() and next_event indicates
the next timer event on that cpu. Whenever there are
no timers on a CPU, corresponding clockevent device
is going into ONESHOT_STOPPED state but clockevent
device next_event is not updated, because
clockevents_program_event() not called.

As next_event is not updated properly, resulting in spurious
wakeups, so update the clockevent device next_event
with proper value(KTIME_MAX) to avoid spurious wakeups.

Signed-off-by: Prasad Sodagudi <psodagud@codeaurora.org>
---
 kernel/time/tick-oneshot.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/time/tick-oneshot.c b/kernel/time/tick-oneshot.c
index 6b009c2..c1f518e 100644
--- a/kernel/time/tick-oneshot.c
+++ b/kernel/time/tick-oneshot.c
@@ -33,6 +33,7 @@ int tick_program_event(ktime_t expires, int force)
 		 * We don't need the clock event device any more, stop it.
 		 */
 		clockevents_switch_state(dev, CLOCK_EVT_STATE_ONESHOT_STOPPED);
+		dev->next_event = KTIME_MAX;
 		return 0;
 	}
 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

  reply	other threads:[~2017-10-26 18:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-24  4:33 clock event device’s next_event Sodagudi Prasad
2017-10-24  7:23 ` Thomas Gleixner
2017-10-24  7:56   ` Sodagudi Prasad
2017-10-24  8:06     ` [PATCH] Clockevents: Always call clockevents_program_event Prasad Sodagudi
2017-10-24  8:37       ` Thomas Gleixner
2017-10-24  9:21         ` Sodagudi Prasad
2017-10-24 10:13           ` Thomas Gleixner
2017-10-26 18:37             ` Prasad Sodagudi [this message]
2017-11-01 17:25               ` [tip:timers/core] clockevents: Update clockevents device next_event on stop tip-bot for Prasad Sodagudi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1509043042-32486-1-git-send-email-psodagud@codeaurora.org \
    --to=psodagud@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome