From: Thomas Gleixner <tglx@linutronix.de>
To: Prasad Sodagudi <psodagud@codeaurora.org>
Cc: mingo@kernel.org, viresh.kumar@linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Clockevents: Always call clockevents_program_event
Date: Tue, 24 Oct 2017 10:37:21 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1710241034350.2369@nanos> (raw)
In-Reply-To: <1508832388-30929-1-git-send-email-psodagud@codeaurora.org>
On Tue, 24 Oct 2017, Prasad Sodagudi wrote:
> Currently tick_program_event function is not calling
> clockevents_program_event when 'expires == KTIME_MAX',
> it is just updating clockevent state to CLOCK_EVT_STATE_ONESHOT_STOPPED.
> clockevents_program_event function updates clockevent
> device next_event by checking clockevent device state,
> so always call clockevents_program_event() from tick_program_event.
No. This is fundmentally wrong. If the clockevent is in oneshot stopped
mode then you cannot call clockevents_program_event(). There is even a
warning in that code which will trigger.
Thanks,
tglx
next prev parent reply other threads:[~2017-10-24 8:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-24 4:33 clock event device’s next_event Sodagudi Prasad
2017-10-24 7:23 ` Thomas Gleixner
2017-10-24 7:56 ` Sodagudi Prasad
2017-10-24 8:06 ` [PATCH] Clockevents: Always call clockevents_program_event Prasad Sodagudi
2017-10-24 8:37 ` Thomas Gleixner [this message]
2017-10-24 9:21 ` Sodagudi Prasad
2017-10-24 10:13 ` Thomas Gleixner
2017-10-26 18:37 ` [PATCH] clockevents: Update clockevents device next_event Prasad Sodagudi
2017-11-01 17:25 ` [tip:timers/core] clockevents: Update clockevents device next_event on stop tip-bot for Prasad Sodagudi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1710241034350.2369@nanos \
--to=tglx@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=psodagud@codeaurora.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®