mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: tglx@linutronix.de, daniel.lezcano@linaro.org
Cc: linux-kernel@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	Marc Zyngier <marc.zyngier@arm.com>
Subject: [PATCH 14/17] clocksource/drivers/arm_arch_timer: Fix DEFINE_PER_CPU expansion
Date: Sun, 29 Oct 2017 22:20:31 +0100	[thread overview]
Message-ID: <1509312035-17368-14-git-send-email-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <1509312035-17368-1-git-send-email-daniel.lezcano@linaro.org>

From: Mark Rutland <mark.rutland@arm.com>

Our ctags mangling script can't handle newlines inside of a
DEFINE_PER_CPU(), leading to an annoying message whenever tags are
built:

  ctags: Warning: drivers/clocksource/arm_arch_timer.c:302: null expansion of name pattern "\1"

This was dealt with elsewhere in commit:

  25528213fe9f75f4 ("tags: Fix DEFINE_PER_CPU expansions")

... by ensuring each DEFINE_PER_CPU() was contained on a single line,
even where this would violate the usual code style (checkpatch warnings
and all).

Let's do the same for the arch timer driver, and get rid of the
distraction.

Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/clocksource/arm_arch_timer.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
index 14e2419..0ecf5be 100644
--- a/drivers/clocksource/arm_arch_timer.c
+++ b/drivers/clocksource/arm_arch_timer.c
@@ -299,8 +299,7 @@ static u64 notrace arm64_858921_read_cntvct_el0(void)
 #endif
 
 #ifdef CONFIG_ARM_ARCH_TIMER_OOL_WORKAROUND
-DEFINE_PER_CPU(const struct arch_timer_erratum_workaround *,
-	       timer_unstable_counter_workaround);
+DEFINE_PER_CPU(const struct arch_timer_erratum_workaround *, timer_unstable_counter_workaround);
 EXPORT_SYMBOL_GPL(timer_unstable_counter_workaround);
 
 DEFINE_STATIC_KEY_FALSE(arch_timer_read_ool_enabled);
-- 
2.7.4

  parent reply	other threads:[~2017-10-29 21:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-29 21:20 [GIT PULL] clockevents / clocksources for 4.15 Daniel Lezcano
2017-10-29 21:20 ` [PATCH 01/17] dt-bindings: timer: renesas, cmt: Fix SoC-specific compatible values Daniel Lezcano
2017-10-29 21:20   ` [PATCH 02/17] clocksource/drivers/sh_cmt: Use 0x3f mask for SH_CMT_48BIT case Daniel Lezcano
2017-10-29 21:20   ` [PATCH 03/17] clocksource/drivers/sh_cmt: Support separate R-Car Gen2 CMT0/1 Daniel Lezcano
2017-10-29 21:20   ` [PATCH 04/17] clocksource/drivers/sh_cmt: Remove support for "renesas,cmt-32*" Daniel Lezcano
2017-10-29 21:20   ` [PATCH 05/17] clocksource/drivers/sh_cmt: Mark "renesas,cmt-48-gen2" deprecated Daniel Lezcano
2017-10-29 21:20   ` [PATCH 06/17] clocksource/drivers/sh_cmt: Remove unused "renesas, channels-mask" handling Daniel Lezcano
2017-10-29 21:20   ` [PATCH 07/17] clocksource/drivers/sh_cmt: Use of_device_get_match_data() helper Daniel Lezcano
2017-10-29 21:20   ` [PATCH 08/17] clocksource/drivers/fttmr010: pr_err() strings should end with newlines Daniel Lezcano
2017-10-29 21:20   ` [PATCH 09/17] clocksource/drivers/owl: " Daniel Lezcano
2017-10-29 21:20   ` [PATCH 10/17] clocksource/drivers/rockchip: " Daniel Lezcano
2017-10-29 21:20   ` [PATCH 11/17] clocksource: Improve GENERIC_CLOCKEVENTS dependency Daniel Lezcano
2017-10-29 21:20   ` [PATCH 12/17] MAINTAINERS: Fix path and add bindings to timers Daniel Lezcano
2017-10-29 21:20   ` [PATCH 13/17] clocksource/drivers/arm_arch_timer: Validate CNTFRQ after enabling frame Daniel Lezcano
2017-10-29 21:20   ` Daniel Lezcano [this message]
2017-10-29 21:20   ` [PATCH 15/17] clocksource/drivers/mips-gic-timer: Remove pointless irq_save,restore Daniel Lezcano
2017-10-29 21:20   ` [PATCH 16/17] clocksource/drivers/mips-gic-timer: Add fastpath for local timer updates Daniel Lezcano
2017-10-29 21:20   ` [PATCH 17/17] clocksource/drivers/timer-of: Add timer_of_exit function Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1509312035-17368-14-git-send-email-daniel.lezcano@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®