mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: tglx@linutronix.de, daniel.lezcano@linaro.org
Cc: linux-kernel@vger.kernel.org,
	Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH 06/17] clocksource/drivers/sh_cmt: Remove unused "renesas, channels-mask" handling
Date: Sun, 29 Oct 2017 22:20:23 +0100	[thread overview]
Message-ID: <1509312035-17368-6-git-send-email-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <1509312035-17368-1-git-send-email-daniel.lezcano@linaro.org>

From: Geert Uytterhoeven <geert+renesas@glider.be>

The in-driver channel configuration in sh_cmt_info.channels_mask is now
always set for all CMT devices instantiated from DT.

Hence the "renesas,channels-mask" property is no longer checked, and its
handling can be removed, cfr. commit 4e18111ff38f0664 ("devicetree:
bindings: Remove deprecated properties").

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/clocksource/sh_cmt.c | 18 +-----------------
 1 file changed, 1 insertion(+), 17 deletions(-)

diff --git a/drivers/clocksource/sh_cmt.c b/drivers/clocksource/sh_cmt.c
index 61a9225..89c514c 100644
--- a/drivers/clocksource/sh_cmt.c
+++ b/drivers/clocksource/sh_cmt.c
@@ -946,14 +946,6 @@ static const struct of_device_id sh_cmt_of_table[] __maybe_unused = {
 };
 MODULE_DEVICE_TABLE(of, sh_cmt_of_table);
 
-static int sh_cmt_parse_dt(struct sh_cmt_device *cmt)
-{
-	struct device_node *np = cmt->pdev->dev.of_node;
-
-	return of_property_read_u32(np, "renesas,channels-mask",
-				    &cmt->hw_channels);
-}
-
 static int sh_cmt_setup(struct sh_cmt_device *cmt, struct platform_device *pdev)
 {
 	unsigned int mask;
@@ -968,15 +960,7 @@ static int sh_cmt_setup(struct sh_cmt_device *cmt, struct platform_device *pdev)
 
 		id = of_match_node(sh_cmt_of_table, pdev->dev.of_node);
 		cmt->info = id->data;
-
-		/* prefer in-driver channel configuration over DT */
-		if (cmt->info->channels_mask) {
-			cmt->hw_channels = cmt->info->channels_mask;
-		} else {
-			ret = sh_cmt_parse_dt(cmt);
-			if (ret < 0)
-				return ret;
-		}
+		cmt->hw_channels = cmt->info->channels_mask;
 	} else if (pdev->dev.platform_data) {
 		struct sh_timer_config *cfg = pdev->dev.platform_data;
 		const struct platform_device_id *id = pdev->id_entry;
-- 
2.7.4

  parent reply	other threads:[~2017-10-29 21:27 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-29 21:20 [GIT PULL] clockevents / clocksources for 4.15 Daniel Lezcano
2017-10-29 21:20 ` [PATCH 01/17] dt-bindings: timer: renesas, cmt: Fix SoC-specific compatible values Daniel Lezcano
2017-10-29 21:20   ` [PATCH 02/17] clocksource/drivers/sh_cmt: Use 0x3f mask for SH_CMT_48BIT case Daniel Lezcano
2017-10-29 21:20   ` [PATCH 03/17] clocksource/drivers/sh_cmt: Support separate R-Car Gen2 CMT0/1 Daniel Lezcano
2017-10-29 21:20   ` [PATCH 04/17] clocksource/drivers/sh_cmt: Remove support for "renesas,cmt-32*" Daniel Lezcano
2017-10-29 21:20   ` [PATCH 05/17] clocksource/drivers/sh_cmt: Mark "renesas,cmt-48-gen2" deprecated Daniel Lezcano
2017-10-29 21:20   ` Daniel Lezcano [this message]
2017-10-29 21:20   ` [PATCH 07/17] clocksource/drivers/sh_cmt: Use of_device_get_match_data() helper Daniel Lezcano
2017-10-29 21:20   ` [PATCH 08/17] clocksource/drivers/fttmr010: pr_err() strings should end with newlines Daniel Lezcano
2017-10-29 21:20   ` [PATCH 09/17] clocksource/drivers/owl: " Daniel Lezcano
2017-10-29 21:20   ` [PATCH 10/17] clocksource/drivers/rockchip: " Daniel Lezcano
2017-10-29 21:20   ` [PATCH 11/17] clocksource: Improve GENERIC_CLOCKEVENTS dependency Daniel Lezcano
2017-10-29 21:20   ` [PATCH 12/17] MAINTAINERS: Fix path and add bindings to timers Daniel Lezcano
2017-10-29 21:20   ` [PATCH 13/17] clocksource/drivers/arm_arch_timer: Validate CNTFRQ after enabling frame Daniel Lezcano
2017-10-29 21:20   ` [PATCH 14/17] clocksource/drivers/arm_arch_timer: Fix DEFINE_PER_CPU expansion Daniel Lezcano
2017-10-29 21:20   ` [PATCH 15/17] clocksource/drivers/mips-gic-timer: Remove pointless irq_save,restore Daniel Lezcano
2017-10-29 21:20   ` [PATCH 16/17] clocksource/drivers/mips-gic-timer: Add fastpath for local timer updates Daniel Lezcano
2017-10-29 21:20   ` [PATCH 17/17] clocksource/drivers/timer-of: Add timer_of_exit function Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1509312035-17368-6-git-send-email-daniel.lezcano@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=geert+renesas@glider.be \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®