From: Joe Perches <joe@perches.com>
To: Rolf Evers-Fischer <embedded24@evers-fischer.de>,
apw@canonical.com, linux-kernel@vger.kernel.org
Subject: Re: Checkpatch ignores spelling error by using -f
Date: Wed, 06 Dec 2017 06:52:34 -0800 [thread overview]
Message-ID: <1512571954.16419.12.camel@perches.com> (raw)
In-Reply-To: <alpine.LNX.2.20.1712061458490.6399@5HSWXM1.fritz.box>
On Wed, 2017-12-06 at 15:13 +0100, Rolf Evers-Fischer wrote:
> Hello,
> I've just checked the file drivers/tty/serial/8250/8250_omap.c, using
> checkpatch.pl, but I forgot the '-f' option (for file).
>
> Surprisingly the checkpatch script reported a misspelling:
>
> "WARNING: 'additionaly' may be misspelled - perhaps 'additionally'?
> #417:
> * We enable TRIG_GRANU for RX and TX and additionaly we set"
>
> Additionally it reported that the file does not appear to be a
> unified-diff (due to my mistake).
>
> Running checkpatch again with '-f', it didn't report any problems:
>
> "drivers/tty/serial/8250/8250_omap.c has no obvious style problems and is
> ready for submission."
>
> Is this a bug in checkpatch.pl? Or is it a feature?
feature. kinda.
checkpatch reports spelling errors in commit messages.
Without the -f, checkpatch is reading its input as a
commit message before expecting to find a diff/patch.
next prev parent reply other threads:[~2017-12-06 14:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 14:13 Rolf Evers-Fischer
2017-12-06 14:52 ` Joe Perches [this message]
2017-12-06 15:01 ` Rolf Evers-Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1512571954.16419.12.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=embedded24@evers-fischer.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®