* Checkpatch ignores spelling error by using -f
@ 2017-12-06 14:13 Rolf Evers-Fischer
2017-12-06 14:52 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: Rolf Evers-Fischer @ 2017-12-06 14:13 UTC (permalink / raw)
To: apw, joe, linux-kernel
Hello,
I've just checked the file drivers/tty/serial/8250/8250_omap.c, using
checkpatch.pl, but I forgot the '-f' option (for file).
Surprisingly the checkpatch script reported a misspelling:
"WARNING: 'additionaly' may be misspelled - perhaps 'additionally'?
#417:
* We enable TRIG_GRANU for RX and TX and additionaly we set"
Additionally it reported that the file does not appear to be a
unified-diff (due to my mistake).
Running checkpatch again with '-f', it didn't report any problems:
"drivers/tty/serial/8250/8250_omap.c has no obvious style problems and is
ready for submission."
Is this a bug in checkpatch.pl? Or is it a feature?
Kind regards,
Rolf
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: Checkpatch ignores spelling error by using -f
2017-12-06 14:13 Checkpatch ignores spelling error by using -f Rolf Evers-Fischer
@ 2017-12-06 14:52 ` Joe Perches
2017-12-06 15:01 ` Rolf Evers-Fischer
0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2017-12-06 14:52 UTC (permalink / raw)
To: Rolf Evers-Fischer, apw, linux-kernel
On Wed, 2017-12-06 at 15:13 +0100, Rolf Evers-Fischer wrote:
> Hello,
> I've just checked the file drivers/tty/serial/8250/8250_omap.c, using
> checkpatch.pl, but I forgot the '-f' option (for file).
>
> Surprisingly the checkpatch script reported a misspelling:
>
> "WARNING: 'additionaly' may be misspelled - perhaps 'additionally'?
> #417:
> * We enable TRIG_GRANU for RX and TX and additionaly we set"
>
> Additionally it reported that the file does not appear to be a
> unified-diff (due to my mistake).
>
> Running checkpatch again with '-f', it didn't report any problems:
>
> "drivers/tty/serial/8250/8250_omap.c has no obvious style problems and is
> ready for submission."
>
> Is this a bug in checkpatch.pl? Or is it a feature?
feature. kinda.
checkpatch reports spelling errors in commit messages.
Without the -f, checkpatch is reading its input as a
commit message before expecting to find a diff/patch.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Checkpatch ignores spelling error by using -f
2017-12-06 14:52 ` Joe Perches
@ 2017-12-06 15:01 ` Rolf Evers-Fischer
0 siblings, 0 replies; 3+ messages in thread
From: Rolf Evers-Fischer @ 2017-12-06 15:01 UTC (permalink / raw)
To: Joe Perches; +Cc: Rolf Evers-Fischer, apw, linux-kernel
On Wed, 6 Dec 2017, Joe Perches wrote:
> On Wed, 2017-12-06 at 15:13 +0100, Rolf Evers-Fischer wrote:
> > Hello,
> > I've just checked the file drivers/tty/serial/8250/8250_omap.c, using
> > checkpatch.pl, but I forgot the '-f' option (for file).
> >
> > Surprisingly the checkpatch script reported a misspelling:
> >
> > "WARNING: 'additionaly' may be misspelled - perhaps 'additionally'?
> > #417:
> > * We enable TRIG_GRANU for RX and TX and additionaly we set"
> >
> > Additionally it reported that the file does not appear to be a
> > unified-diff (due to my mistake).
> >
> > Running checkpatch again with '-f', it didn't report any problems:
> >
> > "drivers/tty/serial/8250/8250_omap.c has no obvious style problems and is
> > ready for submission."
> >
> > Is this a bug in checkpatch.pl? Or is it a feature?
>
> feature. kinda.
>
> checkpatch reports spelling errors in commit messages.
>
> Without the -f, checkpatch is reading its input as a
> commit message before expecting to find a diff/patch.
>
>
>
>
Thank you very much for this explanation.
Best regards,
Rolf
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-06 15:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-06 14:13 Checkpatch ignores spelling error by using -f Rolf Evers-Fischer
2017-12-06 14:52 ` Joe Perches
2017-12-06 15:01 ` Rolf Evers-Fischer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®