From: kan.liang@intel.com
To: acme@kernel.org, peterz@infradead.org, mingo@redhat.com,
linux-kernel@vger.kernel.org
Cc: jolsa@kernel.org, wangnan0@huawei.com, namhyung@kernel.org,
ak@linux.intel.com, yao.jin@linux.intel.com,
Kan Liang <kan.liang@intel.com>
Subject: [PATCH V2 0/8] perf top overwrite mode
Date: Wed, 6 Dec 2017 15:32:55 -0800 [thread overview]
Message-ID: <1512603183-42754-1-git-send-email-kan.liang@intel.com> (raw)
From: Kan Liang <kan.liang@intel.com>
perf_top__mmap_read has severe performance issue in
Knights Landing/Mill, when monitoring in heavy load system. It costs
several minutes to finish, which is unacceptable.
Currently, perf top is non overwrite mode. For non overwrite mode, it
tries to read everything in the ringbuffer and doesn't pause the
ringbuffer. Once there are lots of samples delivered persistently,
the processing time could be very long. Also, the latest samples could
be lost when the ringbuffer is full.
It's better to change it to overwrite mode, which takes a snapshot for
the system by pausing the ringbuffer and could significantly reducing
the processing time (from several minutes to several seconds).
Also, the overwrite mode always keep the latest samples.
Patch 1-4: Modify perf_mmap__read_catchup and perf_mmap__read_backward.
Introduce perf_mmap__read_event
Make generic code ready for overwrite mode
Patch 5-7: Perf top should only support either overwrite or non-overwrite
mode.
Switch default mode to overwrite mode
If kernel doesn't support overwrite mode, fall back to
non-overwrite mode.
Patch 8: The latency could be still higher than refresh time in some
extreme cases. Give user some hints to reduce the latency.
Changes since V1:
- New patches 4-6
- Support both overwrite mode and non-overwrite mode.
If kernel doesn't support default overwrite mode, fall back to
non-overwrite mode.
Kan Liang (8):
perf tools: remove stale perf evlist mmap read for backward
perf tools: rewrite perf mmap read for overwrite
perf tools: reuse perf_mmap__read_catchup in perf_mmap__push
perf tools: introduce perf_mmap__read_event
perf top: check per event overwrite term
perf top: add overwrite fall back
perf top: switch default mode to overwrite mode
perf top: check the latency of perf_top__mmap_read
tools/perf/builtin-top.c | 139 +++++++++++++++++++++++++++----
tools/perf/tests/backward-ring-buffer.c | 9 +-
tools/perf/ui/browsers/hists.c | 12 ++-
tools/perf/util/evlist.c | 17 ----
tools/perf/util/evlist.h | 4 -
tools/perf/util/mmap.c | 140 ++++++++++++++++++--------------
tools/perf/util/mmap.h | 10 ++-
7 files changed, 229 insertions(+), 102 deletions(-)
--
2.5.5
next reply other threads:[~2017-12-06 23:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 23:32 kan.liang [this message]
2017-12-06 23:32 ` [PATCH V2 1/8] perf tools: remove stale perf evlist mmap read for backward kan.liang
2017-12-18 6:44 ` Wangnan (F)
2017-12-06 23:32 ` [PATCH V2 2/8] perf tools: rewrite perf mmap read for overwrite kan.liang
2017-12-18 8:49 ` Wangnan (F)
2017-12-18 19:07 ` Liang, Kan
2017-12-19 3:04 ` Wangnan (F)
2017-12-19 15:23 ` Liang, Kan
2017-12-06 23:32 ` [PATCH V2 3/8] perf tools: reuse perf_mmap__read_catchup in perf_mmap__push kan.liang
2017-12-06 23:32 ` [PATCH V2 4/8] perf tools: introduce perf_mmap__read_event kan.liang
2017-12-06 23:33 ` [PATCH V2 5/8] perf top: check per event overwrite term kan.liang
2017-12-06 23:33 ` [PATCH V2 6/8] perf top: add overwrite fall back kan.liang
2017-12-18 9:23 ` Wangnan (F)
2017-12-18 19:13 ` Liang, Kan
2017-12-06 23:33 ` [PATCH V2 7/8] perf top: switch default mode to overwrite mode kan.liang
2017-12-06 23:33 ` [PATCH V2 8/8] perf top: check the latency of perf_top__mmap_read kan.liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1512603183-42754-1-git-send-email-kan.liang@intel.com \
--to=kan.liang@intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=wangnan0@huawei.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®