From: kan.liang@intel.com
To: acme@kernel.org, peterz@infradead.org, mingo@redhat.com,
linux-kernel@vger.kernel.org
Cc: jolsa@kernel.org, wangnan0@huawei.com, namhyung@kernel.org,
ak@linux.intel.com, yao.jin@linux.intel.com,
Kan Liang <kan.liang@intel.com>
Subject: [PATCH V2 6/8] perf top: add overwrite fall back
Date: Wed, 6 Dec 2017 15:33:01 -0800 [thread overview]
Message-ID: <1512603183-42754-7-git-send-email-kan.liang@intel.com> (raw)
In-Reply-To: <1512603183-42754-1-git-send-email-kan.liang@intel.com>
From: Kan Liang <kan.liang@intel.com>
Switch to non-overwrite mode if kernel doesnot support overwrite
ringbuffer.
It's only effect when overwrite mode is supported.
No change to current behavior.
Signed-off-by: Kan Liang <kan.liang@intel.com>
---
tools/perf/builtin-top.c | 35 +++++++++++++++++++++++++++++++++++
1 file changed, 35 insertions(+)
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index 5e15d27..7c462d6 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -931,6 +931,27 @@ static int perf_top_overwrite_check(struct perf_top *top)
return 0;
}
+static int perf_top_overwrite_fallback(struct perf_top *top,
+ struct perf_evsel *evsel)
+{
+ struct record_opts *opts = &top->record_opts;
+ struct perf_evlist *evlist = top->evlist;
+ struct perf_evsel *counter;
+
+ if (!opts->overwrite)
+ return 0;
+
+ /* only fall back when first event fails */
+ if (evsel != perf_evlist__first(evlist))
+ return 0;
+
+ evlist__for_each_entry(evlist, counter)
+ counter->attr.write_backward = false;
+ opts->overwrite = false;
+ ui__warning("fall back to non-overwrite mode\n");
+ return 1;
+}
+
static int perf_top__start_counters(struct perf_top *top)
{
char msg[BUFSIZ];
@@ -954,6 +975,20 @@ static int perf_top__start_counters(struct perf_top *top)
try_again:
if (perf_evsel__open(counter, top->evlist->cpus,
top->evlist->threads) < 0) {
+
+ /*
+ * Specially handle overwrite fall back.
+ * Because perf top is the only tool which has
+ * overwrite mode by default, support
+ * both overwrite and non-overwrite mode, and
+ * require consistent mode for all events.
+ *
+ * May move it to generic code with more tools
+ * have similar attribute.
+ */
+ if (perf_top_overwrite_fallback(top, counter))
+ goto try_again;
+
if (perf_evsel__fallback(counter, errno, msg, sizeof(msg))) {
if (verbose > 0)
ui__warning("%s\n", msg);
--
2.5.5
next prev parent reply other threads:[~2017-12-06 23:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 23:32 [PATCH V2 0/8] perf top overwrite mode kan.liang
2017-12-06 23:32 ` [PATCH V2 1/8] perf tools: remove stale perf evlist mmap read for backward kan.liang
2017-12-18 6:44 ` Wangnan (F)
2017-12-06 23:32 ` [PATCH V2 2/8] perf tools: rewrite perf mmap read for overwrite kan.liang
2017-12-18 8:49 ` Wangnan (F)
2017-12-18 19:07 ` Liang, Kan
2017-12-19 3:04 ` Wangnan (F)
2017-12-19 15:23 ` Liang, Kan
2017-12-06 23:32 ` [PATCH V2 3/8] perf tools: reuse perf_mmap__read_catchup in perf_mmap__push kan.liang
2017-12-06 23:32 ` [PATCH V2 4/8] perf tools: introduce perf_mmap__read_event kan.liang
2017-12-06 23:33 ` [PATCH V2 5/8] perf top: check per event overwrite term kan.liang
2017-12-06 23:33 ` kan.liang [this message]
2017-12-18 9:23 ` [PATCH V2 6/8] perf top: add overwrite fall back Wangnan (F)
2017-12-18 19:13 ` Liang, Kan
2017-12-06 23:33 ` [PATCH V2 7/8] perf top: switch default mode to overwrite mode kan.liang
2017-12-06 23:33 ` [PATCH V2 8/8] perf top: check the latency of perf_top__mmap_read kan.liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1512603183-42754-7-git-send-email-kan.liang@intel.com \
--to=kan.liang@intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=wangnan0@huawei.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®