mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kan.liang@intel.com
To: acme@kernel.org, peterz@infradead.org, mingo@redhat.com,
	linux-kernel@vger.kernel.org
Cc: jolsa@kernel.org, wangnan0@huawei.com, namhyung@kernel.org,
	ak@linux.intel.com, yao.jin@linux.intel.com,
	Kan Liang <kan.liang@intel.com>
Subject: [PATCH V2 3/8] perf tools: reuse perf_mmap__read_catchup in perf_mmap__push
Date: Wed,  6 Dec 2017 15:32:58 -0800	[thread overview]
Message-ID: <1512603183-42754-4-git-send-email-kan.liang@intel.com> (raw)
In-Reply-To: <1512603183-42754-1-git-send-email-kan.liang@intel.com>

From: Kan Liang <kan.liang@intel.com>

perf_mmap__push uses the same codes as perf_mmap__read_catchup to
calculate the ring buffer start, end and size.

No funcational change.

Signed-off-by: Kan Liang <kan.liang@intel.com>
---
 tools/perf/util/mmap.c | 31 ++++++-------------------------
 1 file changed, 6 insertions(+), 25 deletions(-)

diff --git a/tools/perf/util/mmap.c b/tools/perf/util/mmap.c
index bf67460..61237eb 100644
--- a/tools/perf/util/mmap.c
+++ b/tools/perf/util/mmap.c
@@ -285,36 +285,16 @@ int perf_mmap__push(struct perf_mmap *md, bool overwrite,
 		    void *to, int push(void *to, void *buf, size_t size))
 {
 	u64 head = perf_mmap__read_head(md);
-	u64 old = md->prev;
-	u64 end = head, start = old;
+	u64 end, start;
 	unsigned char *data = md->base + page_size;
 	unsigned long size;
 	void *buf;
-	int rc = 0;
+	int rc;
 
-	start = overwrite ? head : old;
-	end = overwrite ? old : head;
 
-	if (start == end)
-		return 0;
-
-	size = end - start;
-	if (size > (unsigned long)(md->mask) + 1) {
-		if (!overwrite) {
-			WARN_ONCE(1, "failed to keep up with mmap data. (warn only once)\n");
-
-			md->prev = head;
-			perf_mmap__consume(md, overwrite);
-			return 0;
-		}
-
-		/*
-		 * Backward ring buffer is full. We still have a chance to read
-		 * most of data from it.
-		 */
-		if (overwrite_rb_find_range(data, md->mask, head, &start, &end))
-			return -1;
-	}
+	rc = perf_mmap__read_catchup(md, overwrite, &start, &end, &size);
+	if (rc < 1)
+		return rc;
 
 	if ((start & md->mask) + size != (end & md->mask)) {
 		buf = &data[start & md->mask];
@@ -338,6 +318,7 @@ int perf_mmap__push(struct perf_mmap *md, bool overwrite,
 
 	md->prev = head;
 	perf_mmap__consume(md, overwrite);
+	rc = 0;
 out:
 	return rc;
 }
-- 
2.5.5

  parent reply	other threads:[~2017-12-06 23:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-06 23:32 [PATCH V2 0/8] perf top overwrite mode kan.liang
2017-12-06 23:32 ` [PATCH V2 1/8] perf tools: remove stale perf evlist mmap read for backward kan.liang
2017-12-18  6:44   ` Wangnan (F)
2017-12-06 23:32 ` [PATCH V2 2/8] perf tools: rewrite perf mmap read for overwrite kan.liang
2017-12-18  8:49   ` Wangnan (F)
2017-12-18 19:07     ` Liang, Kan
2017-12-19  3:04       ` Wangnan (F)
2017-12-19 15:23         ` Liang, Kan
2017-12-06 23:32 ` kan.liang [this message]
2017-12-06 23:32 ` [PATCH V2 4/8] perf tools: introduce perf_mmap__read_event kan.liang
2017-12-06 23:33 ` [PATCH V2 5/8] perf top: check per event overwrite term kan.liang
2017-12-06 23:33 ` [PATCH V2 6/8] perf top: add overwrite fall back kan.liang
2017-12-18  9:23   ` Wangnan (F)
2017-12-18 19:13     ` Liang, Kan
2017-12-06 23:33 ` [PATCH V2 7/8] perf top: switch default mode to overwrite mode kan.liang
2017-12-06 23:33 ` [PATCH V2 8/8] perf top: check the latency of perf_top__mmap_read kan.liang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1512603183-42754-4-git-send-email-kan.liang@intel.com \
    --to=kan.liang@intel.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=wangnan0@huawei.com \
    --cc=yao.jin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®